Basic 송미진 #46
Merged
Basic 송미진 #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
Feb 3, 2025
Collaborator
dongqui
left a comment
dongqui
left a comment
There was a problem hiding this comment.
미진님 이번 미션도 고생 많으셨습니다!
요구사항도 잘 챙겨주셨고, 역시 css에 능숙하시네요👍
| <meta property="og:title" content="판다마켓,쇼핑몰"> | ||
| <meta property="og:description" content="안녕하세요. 판다마켓입니다."> | ||
| <meta property="og:url" content=""> | ||
| <meta name="Description" content="일상의 모든 물건을 거래해보세요" /> |
| footer .inner .left { position: absolute; top:65px; } | ||
| .section .box_inner { padding:50px 0 0;} | ||
|
|
||
| .inner { padding-left:16px!important; padding-right:16px!important; } |
Collaborator
There was a problem hiding this comment.
important는 정말 필요한지 확인해보셔야 합니다! :)
| .font_2 { font-size:1.5rem; } | ||
| .font_3 { font-size:1rem; } | ||
| /* tablet */ | ||
| @media (max-width: 1199px) { |
| @@ -0,0 +1,2 @@ | |||
|
|
|||
| - [ Netlify link ] https://pandamall001.netlify.app/ No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
패스워드 아이콘이 background image로 되어있는데, 해당 속성의 경우 시각적인 역할만 하게 됩니다! 이후 미션에서 다루시게 되겠지만, 기능적으로 역할하거나 보여줘야하는 정보라면 background-image는 지양하시는 것이 접근성에 좋습니다 :)
Collaborator
Author
There was a problem hiding this comment.
아아! 넵! 다른방식으로 수정하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
공통
랜딩 페이지
로그인, 회원가입 페이지 공통
심화
주요 변경사항
스크린샷
멘토에게