-
Notifications
You must be signed in to change notification settings - Fork 39
[문혜란] Sprint3 #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GANGYIKIM
merged 7 commits into
codeit-bootcamp-frontend:Basic-문혜란
from
gpfksdlrn:Basic-문혜란-sprint3
Mar 20, 2025
The head ref may contain hidden characters: "Basic-\uBB38\uD61C\uB780-sprint3"
Merged
[문혜란] Sprint3 #103
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b8bf2e0
style: reset.css와 palette.css 병합 및 색상표 정리
gpfksdlrn 4d668ce
refactor: 클래스명 변경하여 가독성 개선
gpfksdlrn 6910ec9
chore: git 대소문자 구분 설정 변경 및 파일명 수정
gpfksdlrn 27b2090
feat: 반응형 기능 추가
gpfksdlrn 508322d
style: input placeholder 문구 수정
gpfksdlrn a032be5
feat: 랜딩 페이지에 메타 태그 추가
gpfksdlrn 27851e9
chore: 메타 태그 이미지 수정
gpfksdlrn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ 수정요청
특정 코드를 분류하는 기준을 추측할 수 있는 가장 큰 단서가 이름이라고 생각합니다.
reset 이라는 파일명을 통해 브라우저 스타일을 초기화하는 코드의 모음이라고 예상할 수 있습니다~
다만 css 변수 선언은 이러한 기준과 잘 맞지 않는다고 생각합니다!
만약 변수만 파일을 분리하시는 것이 싫으셨던 것이라면 해당 변수는 모든 페이지에서 걸쳐서 사용되는 코드이므로 common.css, base.css와 같은 식으로 공통 코드들을 모아두는 파일을 생성하시고 그 안에 두시면 좋겠습니다!