Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"liveServer.settings.port": 5501
}
9 changes: 9 additions & 0 deletions faq.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다마켓</title>
</head>
<body></body>
</html>
Binary file added image/Img_home_01.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
해당 이미지 파일의 크기를 보면 588× 444로 되어 있습니다.
저희는 반응형 사이트를 만들고 있고, 이런 이미지들은 모바일에서도 사용할 것이기 때문에 추출하실때, 1배수가 아닌 2배수로 추출해주시는 것이 화질면에서 좋습니다.
아래처럼 figma export 탭에서 2x 로 설정하고 추출해주세요~

스크린샷 2025-02-24 오전 9 58 17 스크린샷 2025-02-24 오전 9 59 10

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/main1.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ 질문
main1.png, main2.png 가 어떤 경우 필요할까요? 구현에 불필요한 이미지라면 없어도 될 것 같아요~

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/main2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/main3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
107 changes: 107 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
<!DOCTYPE html>
<html lang="ko">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 칭찬
html lang을 ko로 설정해주신 것 좋습니다~ 다음에는 다른 페이지들도 변경해주시면 좋겠네요~

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다마켓</title>

<link rel="stylesheet" href="style.css" />
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css" />
</head>
<body>
<header>
<div class="header_wrap">
<a href="/"><img src="/image/logo.png" alt="판다마켓 로고" class="logo" /></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 칭찬
img 태그의 alt 속성은 alternative 라는 의미로, 이미지 파일을 다운로드하는 것에 실패해서 이미지 파일을 보여줄 수 없을 때
어떤 이미지인지 파악할 수 있게 대신 제공되거나, 스크린리더로 읽혀지는 문자를 의미합니다.
적절한 alt 태그 사용 좋습니다

<a href="/login.html" class="login">로그인</a>
</div>
</header>
<main>
<div class="heading">
<div class="text_box">
<h1 class="heading_title">
<span>일상의 모든 물건을 </span>
<span>거래해 보세요</span>
</h1>
<a href="/items.html" class="view_button">구경하러 가기</a>
</div>
<img src="/image/Img_home_top.png" />
</div>

<div class="hot_item content_wrap">
<div class="category_box">
<img src="/image/Img_home_01.png" />
<div class="category_description">
<h3 class="category_title">Hot item</h3>
<h1 class="title">인기 상품을<br />확인해 보세요</h1>
<p class="description">
가장 HOT한 중고거래 물품을<br />
판다 마켓에서 확인해 보세요
</p>
</div>
</div>
</div>

<div class="search content_wrap">
<div class="category_box">
<img src="/image/Img_home_02.png" />
<div class="category_description">
<h3 class="category_title">Search</h3>
<h1 class="title">
구매를 원하는<br />
상품을 검색하세요
</h1>
<p class="description">
구매하고 싶은 물품은 검색해서<br />
쉽게 찾아보세요
</p>
</div>
</div>
</div>

<div class="register content_wrap">
<div class="category_box">
<img src="/image/Img_home_03.png" />
<div class="category_description">
<h3 class="category_title">Register</h3>
<h1 class="title">
판매를 원하는<br />
상품을 등록하세요
</h1>
<p class="description">
어떤 물건이든 판매하고 싶은 상품을<br />
쉽게 등록하세요
</p>
</div>
</div>
</div>

<div class="ad">
<h1 class="title">믿을 수 있는<br />판다마켓 중고 거래</h1>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
h1 태그는 heading 1이라는 의미의 태그입니다. 이러한 h1~h6까지의 태그들은 시멘틱한 작성에 중요한 역할을 합니다.
그중 h1 태그는 제목에 해당하는 친구입니다.
목차나 영화를 생각해보시면 제목은 늘 1개입니다. 그래서 h1태그는 한 페이지에 한번만 사용하는 것이 좋습니다.
다만 이는 접근성을 위한 권고사항일 뿐 필수사항은 아닙니다 그래도 권고니 지키는것이 더 좋습니다!

mdn

<img src="/image/Img_home_bottom.png" class="ad_img" />
</div>
</main>
<footer>
<div class="ft_content_wrap">
<span class="codeit">@codeit - 2024</span>
<div class="privacy_faq">
<a href="/privacy.html" class="policy">Privacy Policy</a>
<a href="faq.html">FAQ</a>
</div>
<div class="icons">
<a href="https://www.facebook.com/?locale=ko_KR" target="_blank"></a
><img src="/image/ic_facebook.png" alt="페이스북" />
<a href="https://x.com/?lang=ko" target="_blank"></a
><img src="/image/ic_twitter.png" alt="트위터" />
<a href="https://www.youtube.com/" target="_blank"></a
><img src="/image/ic_youtube.png" alt="유튜브" />
<a href="https://www.instagram.com/" target="_blank"></a
><img src="/image/ic_instagram.png" alt="인스타그램" />
</div>
Comment on lines +94 to +103
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
이 영역은 로고들의 모음이라고 할 수 있습니다. 관련된 요소들끼리 묶인 목록이니 의미록적인 마크업을 작성한다면 list 관련 태그로 작성하시는 것을 추천드립니다.
또한 의도하신 바가 각 sns의 아이콘을 눌렀을때 해당하는 sns 로의 이동이라면 a 태그안에 img 태그를 넣으시는 것을 추천드려요~

Suggested change
<div class="icons">
<a href="https://www.facebook.com/?locale=ko_KR" target="_blank"></a
><img src="/image/ic_facebook.png" alt="페이스북" />
<a href="https://x.com/?lang=ko" target="_blank"></a
><img src="/image/ic_twitter.png" alt="트위터" />
<a href="https://www.youtube.com/" target="_blank"></a
><img src="/image/ic_youtube.png" alt="유튜브" />
<a href="https://www.instagram.com/" target="_blank"></a
><img src="/image/ic_instagram.png" alt="인스타그램" />
</div>
<ul class="icons">
<li>
<a href="https://www.facebook.com/?locale=ko_KR" target="_blank">
<img src="/image/ic_facebook.png" alt="페이스북" />
</a>
</li>
</ul>

</div>
</footer>
</body>
</html>
9 changes: 9 additions & 0 deletions items.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다마켓</title>
</head>
<body></body>
</html>
9 changes: 9 additions & 0 deletions login.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다마켓</title>
</head>
<body></body>
</html>
9 changes: 9 additions & 0 deletions privacy.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다마켓</title>
</head>
<body></body>
</html>
Loading
Loading