Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions css/components/articles.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
.main-article {
display: flex;
justify-content: center;
align-items: center;
padding: 50px 0;
}

.main-article-container {
display: flex;
width: 988px;
height: 444px;
}

.main-article__text {
display: flex;
flex-direction: column;
justify-content: center;
background-color: #fcfcfc;
gap: 24px;
padding: 30px 40px;
h5 {
font-size: 18px;
font-weight: 700;
line-height: 26px;
color: #3692ff;
}
h2 {
font-size: 40px;
font-weight: 700;
line-height: 56px;
}
p {
font-size: 24px;
line-height: 32px;
font-weight: 500;
}
}

.main-article__text2 {
align-items: flex-end;
text-align: right;
}
53 changes: 53 additions & 0 deletions css/components/banner.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
.main-banner {
display: flex;
justify-content: center;
background-color: #cfe5ff;
width: 100%;
height: 540px;
}

banner {
display: flex;
align-items: flex-end;
justify-content: center;
width: 100%;
max-width: 1920px;
height: 100%;
}

.main-banner__content {
display: flex;
flex-direction: column;
align-items: flex-start;
width: 357px;
height: 260px;
font-size: 40px;
font-weight: 700;
line-height: 56px;
gap: 32px;
margin-bottom: 40px;
a {
width: 100%;
}
button {
display: flex;
align-items: center;
justify-content: center;
width: 100%;
height: 56px;
border-radius: 40px;
background-color: #3692ff;
color: #ffffff;
cursor: pointer;
}
}

.main-banner-bottom__content {
margin-bottom: 0;
}

@media (max-width: 1920px) {
banner {
width: calc(100% - 400px);
}
}
29 changes: 29 additions & 0 deletions css/components/footer.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
footer {
display: flex;
align-items: center;
justify-content: center;
width: 100vw;
height: 160px;
background-color: #111827;
}

.footer-container {
display: flex;
align-items: center;
justify-content: space-between;
width: 1120px;
color: #ffffff;
font-size: 16px;
line-height: 19.09px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
해당 line-height 값을 아마 figma에서 보고 추가하셨을 것 같아요.
다만 아래 속성값은 사실 의미가 없을 가능성이 큽니다.
피그마는 디자인을 보고 css 값들을 나열하고, 해당 값이 실제로 구현하는데 필수적인지는 알 수 없습니다.
그래서 피그마 속성값을 그대로 쓰시기보다 참고만해주세요~
그리고 line-height 값이 필요하시더라도 정수로 사용하시는 것이 좋습니다~

Suggested change
line-height: 19.09px;
line-height: 19px;

font-weight: 400;
}

.footer-middle {
display: flex;
gap: 30px;
}

.footer-right {
display: flex;
gap: 12px;
}
37 changes: 37 additions & 0 deletions css/components/nav.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
header {
display: flex;
justify-content: center;
}

nav {
display: flex;
justify-content: space-around;
align-items: center;
width: 100%;
max-width: 1920px;
height: 70px;
padding: 9px 0;
a {
height: 100%;
}
img {
height: 100%;
}
button {
width: 128px;
height: 48px;
padding: 0.5rem 1.45rem;
border-radius: 8px;
border: none;
color: #ffffff;
background-color: #3692ff;
cursor: pointer;
}
}

@media (max-width: 1920px) {
nav {
justify-content: space-between;
width: calc(100% - 400px);
}
}
129 changes: 129 additions & 0 deletions css/reset.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
/* http://meyerweb.com/eric/tools/css/reset/
v2.0 | 20110126
License: none (public domain)
*/

html,
body,
div,
span,
applet,
object,
iframe,
h1,
h2,
h3,
h4,
h5,
h6,
p,
blockquote,
pre,
a,
abbr,
acronym,
address,
big,
cite,
code,
del,
dfn,
em,
img,
ins,
kbd,
q,
s,
samp,
small,
strike,
strong,
sub,
sup,
tt,
var,
b,
u,
i,
center,
dl,
dt,
dd,
ol,
ul,
li,
fieldset,
form,
label,
legend,
table,
caption,
tbody,
tfoot,
thead,
tr,
th,
td,
article,
aside,
canvas,
details,
embed,
figure,
figcaption,
footer,
header,
hgroup,
menu,
nav,
output,
ruby,
section,
summary,
time,
mark,
audio,
video {
margin: 0;
padding: 0;
border: 0;
font-size: 100%;
font: inherit;
vertical-align: baseline;
}
/* HTML5 display-role reset for older browsers */
article,
aside,
details,
figcaption,
figure,
footer,
header,
hgroup,
menu,
nav,
section {
display: block;
}
body {
line-height: 1;
}
ol,
ul {
list-style: none;
}
blockquote,
q {
quotes: none;
}
blockquote:before,
blockquote:after,
q:before,
q:after {
content: "";
content: none;
}
table {
border-collapse: collapse;
border-spacing: 0;
}
33 changes: 33 additions & 0 deletions css/style.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 칭찬
용민님이 생각하시기에 목적에 따라 파일 분리해서 작성하신 점 좋습니다~

Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
@import "reset.css";

/* components */
@import "components/nav.css";
@import "components/banner.css";
@import "components/articles.css";
@import "components/footer.css";

@font-face {
font-family: "Pretendard-Regular";
src: url("https://fastly.jsdelivr.net/gh/Project-Noonnu/[email protected]/Pretendard-Regular.woff")
format("woff");
Comment on lines +10 to +12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안

용민님 폰트 잘 적용하셨습니다.
다만 최적화를 위해 가변 글꼴이나 다이나믹 폰트를 사용하시는 것이 좋습니다.
지금 import 하신 폰트 명을 보면 Pretendard-Regular라고 되어 있습니다.
즉 regular, 400에 해당하는 굵기의 폰트파일이라는 의미입니다.
이 폰트 파일을 기반으로 bold, semi bold와 같이 font-weight를 조정하셔도 되지만
그것이 Pretendard-Bold, Pretendard-SemiBold와 동일한 결과값이라고 보장할 수는 없습니다.
따라서 Pretendard Variable과 같이 가변 굵기용 폰트를 쓰시는 것을 추천드립니다.

이는 최적화를 위한 제안이므로 시간이 되실때 적용해보시면 좋을 것 같습니다~

pretendard github

font-weight: 400;
font-style: normal;
}

* {
box-sizing: border-box;
}

body {
font-family: "Pretendard-Regular";
width: 100vw;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
배포사이트에 들어가보시면 가로 스크롤이 생긴걸 확인할 수 있습니다. 이는 100vw 때문이에요~
해당 속성을 제거하셔도 body 태그는 따로 display 속성을 주지 않으셔도 block 요소처럼 동작하므로 해당 속성은 지우셔도 됩니다.
footer 태그에 있는 width: 100vw도 같이 지우시면 가로 스크롤이 없는 것을 확인하실 수 있습니다~

https://dev.to/tepythai/why-100vw-causes-horizontal-scrollbar-4nlm

}

button {
border: none;
}

a {
text-decoration: none;
color: inherit;
}
Comment on lines +26 to +33
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
브라우저 기본 스타일을 초기화하는 코드이므로 reset.css에 들어가는게 더 좋아보여요~

Binary file added img/Img_home_01.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
해당 이미지 파일의 크기를 보면 588× 444로 되어 있습니다.
저희는 반응형 사이트를 만들고 있고, 이런 이미지들은 모바일에서도 사용할 것이기 때문에 추출하실때, 1배수가 아닌 2배수로 추출해주시는 것이 화질면에서 좋습니다.
아래처럼 figma export 탭에서 2x 로 설정하고 추출해주세요~

스크린샷 2025-02-24 오전 9 58 17 스크린샷 2025-02-24 오전 9 59 10

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
한 레포에서는 같은 룰을 공유하는 것이 좋습니다. 따라서 이미지명도 같은 규칙을 기반으로 명명하는 것이 좋아요.
다른 이미지들처럼 소문자로 시작하는 파일명인 img_home_01.png 로 변경하시는 것을 추천드려요~

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading