-
Notifications
You must be signed in to change notification settings - Fork 39
[이태식] sprint3 #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GANGYIKIM
merged 12 commits into
codeit-bootcamp-frontend:Basic-이태식
from
leeetaesik:Basic-이태식-sprint3
Mar 26, 2025
The head ref may contain hidden characters: "Basic-\uC774\uD0DC\uC2DD-sprint3"
Merged
[이태식] sprint3 #144
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b7a00e9
prettier 사용
leeetaesik 912c5d2
login.css와 signup.css를 auth.css로 병합
leeetaesik 4eff2e6
이미지명 수정
leeetaesik 798548c
logo_lg를 여백 없는 이미지로 변경
leeetaesik 1b0fc3d
reset.css와 utility.css의 일부를 common.css로 분리
leeetaesik 4096a89
회원가입 버튼의 type 명시적으로 작성
leeetaesik bcc5eaa
눈 이미지 버튼으로 감싸줌
leeetaesik abca9e0
로그인 및 회원가입 input에 placeholder 추가
leeetaesik 48e027d
로그인, 회원가입 페이지 모바일 반응형 디자인 적용
leeetaesik 36f03c4
logo_sm 여백 제거, logo_typo 추가
leeetaesik 91972a9
메인 페이지 반응형 디자인 적용
leeetaesik 48a9717
og 메타태그 설정
leeetaesik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| html { | ||
| font-family: Pretendard, sans-serif; | ||
| font-size: 16px; | ||
| } | ||
|
|
||
| :root { | ||
| --gray900: #111827; | ||
| --gray800: #1F2937; | ||
| --gray700: #374151; | ||
| --gray600: #4B5563; | ||
| --gray500: #6B7280; | ||
| --gray400: #9CA3AF; | ||
| --gray200: #E5E7EB; | ||
| --gray100: #F3F4F6; | ||
| --gray50: #F9FAFB; | ||
| --blue: #3692FF; | ||
| } | ||
File renamed without changes
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💊 제안
css 변수들을 분리하신 점 좋습니다. 다만 figma에 정의된 색상 변수보다 수가 더 적은 것 같아요~
큰 이유가 없다면 figma와 동일하게 색상 변수를 선언하시는 것이 좋습니다.
그래야 figma에서 해당 색상 변수가 사용될때 확인하기 쉽고 색상값은 디자이너와 의사 소통할 일이 많은 값이라 소통 측면에서도 같은 이름을 쓰는 것이 좋기 때문입니다~