Skip to content

[유동환] sprint3 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GANGYIKIM merged 6 commits into from
Mar 27, 2025
Merged

[유동환] sprint3 #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ec3e47
config, change imagename
TopiaYu Mar 21, 2025
12a9d5a
add login-Signup.css
TopiaYu Mar 21, 2025
44fcc4d
Add @media() in login-Signup.css
TopiaYu Mar 21, 2025
3f70b2e
config style.css for Tablet size
TopiaYu Mar 21, 2025
85a88f8
complete style.css for Mobile size
TopiaYu Mar 22, 2025
d7c2293
fix footer layout
TopiaYu Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 image/판다얼굴.png → image/logo.png
View file
Open in desktop
File renamed without changes
0 image/판다마켓.png → image/typography.png
View file
Open in desktop
File renamed without changes
20 changes: 10 additions & 10 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
<header>
<a class="logo" href="index.html">
<div class="logo-image">
<img src="image/판다얼굴.png">
<img src="image/logo.png">
</div>
<div class="logo-text">
<img src="image/판다마켓.png">
<img src="image/typography.png">
</div>
</a>
<a class="login-button button" href="login.html">
Expand All @@ -35,8 +35,8 @@
<div class="top-banner">
<div class="top-banner-text">
<p>
일상의 모든 물건을<br>
거래해 보세요
일상의 모든 물건을
<span>거래해 보세요</span>
</p>
<a class="find-items-button button" href="items.html">
구경하러 가기
Expand All @@ -59,8 +59,8 @@
Hot item
</p>
<h2>
인기 상품을<br>
확인해 보세요
인기 상품을
<span>확인해 보세요</span>
</h2>
<h3>
가장 HOT한 중고거래 물품을<br>
Expand All @@ -77,8 +77,8 @@ <h3>
Search
</p>
<h2>
구매를 원하는<br>
상품을 검색하세요
구매를 원하는
<span>상품을 검색하세요</span>
</h2>
<h3>
구매하고 싶은 물품을 검색해서<br>
Expand All @@ -102,8 +102,8 @@ <h3>
Register
</p>
<h2>
판매를 원하는<br>
상품을 등록하세요
판매를 원하는
<span>상품을 등록하세요</span>
</h2>
<h3>
어떤 물건이든 판매하고 싶은 상품을<br>
Expand Down
237 changes: 237 additions & 0 deletions login-Signup.css
View file
Open in desktop
Copy link
Collaborator

@GANGYIKIM GANGYIKIM Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
이미 -로 단어를 구분해주셨으니 signup이 대문자로 시작할 필요가 없을 것 같아요. login-signup으로 변경하시는 것을 추천드려요!

Original file line number Diff line number Diff line change
@@ -0,0 +1,237 @@
* {
box-sizing: border-box;
}

@media (min-width: 375px) {
Copy link
Collaborator

@GANGYIKIM GANGYIKIM Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
min-width가 조건에 걸려있어 375px 미만으로 화면이 작아지게 되면 PC 스타일이 적용되네요~
body에 min-width: 375px를 추가하셔서 해당 사이즈 미만으로 작아지게 되면 가로 스크롤이 생기게 해주시거나
아니라면 min-width를 조건문에서 빼주시는 것을 추천드려요~


/* 버튼 관련 */
.buttons {
width: 100%;
height: 56px;
border-radius: 40px;
background-color: #9CA3AF;
display: flex;
flex-direction: row;
justify-content: center;
align-items: center;
color: #F3F4F6;
margin-bottom: 24px;
font-size: 20px;
font-weight: 600;
border: 0px;
}

/* 전체적인 틀 */
body {
font-family: "Pretendard Variable", Pretendard, sans-serif;

display: flex;
flex-direction: column;
align-items: center;
}

container {
margin-top: 80px;
width: 100%;
max-width: 400px;
height: auto;
margin-right: 16px;
margin-left: 16px;
}

/* 로고관련 */
#logo > a {
display: flex;
flex-direction: row;
justify-content: center;
align-items: center;
gap: 11px;
margin-bottom: 24px;
}

#logo img:first-child {
width: 52px;
}

#logo img:last-child {
width: 133px;
}

/* 폼테그 관련 */
form {
display: flex;
flex-direction: column;
color: #1F2937;
font-size: 18px;
font-weight: 700;
}

form > label {
margin-bottom: 8px;
}

form > input {
width: 100%;
Comment on lines +73 to +74
Copy link
Collaborator

@GANGYIKIM GANGYIKIM Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
인풋에 값을 입력시 너무 좌우에 딱 붙어서 입력이되네요!
디자인을 확인해보시고 적절한 padding값을 추가해주세요~

스크린샷 2025-03-27 오전 11 40 42
Suggested change
form > input {
width: 100%;
form > input {
padding: 0 16px;
width: 100%;

height: 56px;
border: 0;
background-color: #F3F4F6;
border-radius: 12px;
margin-bottom: 16px;
}

input::placeholder {
font-size: 16px;
padding: 24px;
}

/* sns 로그인 관련 */
.sns-login {
display: flex;
flex-direction: row;
align-items: center;
justify-content: space-between;
background-color: #E6F2FF;
padding: 16px 23px;
border-radius: 8px;
margin-bottom: 24px;
font-size: 16px;
font-weight: 500;
}

.sns-login-image {
display: flex;
flex-direction: row;
gap: 16px;
}

.sns-login-image img {
width: 42px;
height: 42px;
}

/* footer 관련 */
.footer {
display: flex;
flex-direction: row;
align-items: center;
justify-content: center;
gap: 4px;
}

.footer p {
margin: 0px;
}

.footer a {
color: #3692FF;
}
}

@media (min-width: 768px) {
/* 버튼 관련 */
.buttons {
width: 100%;
height: 56px;
border-radius: 40px;
background-color: #9CA3AF;
display: flex;
flex-direction: row;
justify-content: center;
align-items: center;
color: #F3F4F6;
margin-bottom: 24px;
font-size: 20px;
font-weight: 600;
border: 0px;
}
Comment on lines +130 to +146
Copy link
Collaborator

@GANGYIKIM GANGYIKIM Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
해당 미디어 쿼리 조건을 보면 @media (min-width: 375px) 로 375px 이상의 화면에서는 해당 css가 적용되게 됩니다. 지금 작성하신 미디어 쿼리 조건인 @media (min-width: 768px)를 만족하면서 그 전 조건도 만족할 수 있기 때문에 중복으로 스타일링을 해주실 필요가 없습니다.

변경이 필요한 경우만 작성해주시고 중복되는 것은 지워주시는 것이 성능, 유지보수 및 가독성 측면에서 유리합니다~

Suggested change
@media (min-width: 768px) {
/* 버튼 관련 */
.buttons {
width: 100%;
height: 56px;
border-radius: 40px;
background-color: #9CA3AF;
display: flex;
flex-direction: row;
justify-content: center;
align-items: center;
color: #F3F4F6;
margin-bottom: 24px;
font-size: 20px;
font-weight: 600;
border: 0px;
}
@media (min-width: 768px) {


/* 전체적인 틀 */
body {
font-family: "Pretendard Variable", Pretendard, sans-serif;

display: flex;
flex-direction: column;
align-items: center;
}

container {
margin-top: 231px;
width: 640px;
height: auto;
}

/* 로고관련 */
#logo > a {
display: flex;
flex-direction: row;
justify-content: center;
align-items: center;
gap: 22px;
margin-bottom: 40px;
}

/* 폼테그 관련 */
form {
display: flex;
flex-direction: column;
color: #1F2937;
font-size: 18px;
font-weight: 700;
}

form > label {
margin-bottom: 16px;
}

form > input {
width: 100%;
height: 56px;
border: 0;
background-color: #F3F4F6;
border-radius: 12px;
margin-bottom: 24px;
}

input::placeholder {
font-size: 16px;
padding: 24px;
}

/* sns 로그인 관련 */
.sns-login {
display: flex;
flex-direction: row;
align-items: center;
justify-content: space-between;
background-color: #E6F2FF;
padding: 16px 23px;
border-radius: 8px;
margin-bottom: 24px;
font-size: 16px;
font-weight: 500;
}

.sns-login-image {
display: flex;
flex-direction: row;
gap: 16px;
}

.sns-login-image img {
width: 42px;
height: 42px;
}

/* footer 관련 */
.footer {
display: flex;
flex-direction: row;
align-items: center;
justify-content: center;
gap: 4px;
}

.footer a {
color: #3692FF;
}
}
18 changes: 3 additions & 15 deletions login.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
margin-bottom: 24px;
font-size: 20px;
font-weight: 600;
border: 0px;
}

/* 전체적인 틀 */
Expand Down Expand Up @@ -52,7 +53,7 @@ form {
font-weight: 700;
}

form > lable {
form > label {
margin-bottom: 16px;
}

Expand Down Expand Up @@ -106,17 +107,4 @@ input::placeholder {

.footer a {
color: #3692FF;
}













}
20 changes: 10 additions & 10 deletions login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,25 @@
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/variable/pretendardvariable.min.css" />
<link rel="stylesheet" href="login.css">
<title>Document</title>
<link rel="stylesheet" href="login-Signup.css">
Copy link
Collaborator

@GANGYIKIM GANGYIKIM Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
지금 코드를 봤을 때는 login-Signup.css 라는 로그인과 회원가입 공통의 파일을 만드시고, 해당 파일만 사용중이신 것 같아요!
그렇다면 사용하지 않는 파일은 지워주시는 것을 추천드려요.

<title>판다마켓 - 로그인</title>
</head>
<body>
<container>
<div id="logo">
<a href="index.html">
<img src="./image/판다얼굴.png">
<img src="./image/판다마켓.png">
<img src="./image/logo.png" alt="판다마켓 로고">
<img src="./image/typography.png" alt="판다마켓 로고 텍스트">
</a>
</div>
<form>
<lable>이메일</lable>
<input type="email" name="user-email" placeholder="이메일을 입력해주세요">
<lable>비밀번호</lable>
<input type="password" name="user-password" placeholder="비밀번호를 입력해주세요">
<div class="login-button">
<label for="email">이메일</label>
<input type="email" id="email" name="user-email" placeholder="이메일을 입력해주세요">
<label for="password">비밀번호</label>
<input type="password" id="password" name="user-password" placeholder="비밀번호를 입력해주세요">
<button type="submit" class="login-button buttons">
로그인
</div>
</button>
</form>
<div class="sns-login">
<p>간편 로그인하기</p>
Expand Down
3 changes: 2 additions & 1 deletion signup.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
margin-bottom: 24px;
font-size: 20px;
font-weight: 600;
border: 0px;
}

/* 전체적인 틀 */
Expand Down Expand Up @@ -52,7 +53,7 @@ form {
font-weight: 700;
}

form > lable {
form > label {
margin-bottom: 16px;
}

Expand Down
Loading
Loading