-
Notifications
You must be signed in to change notification settings - Fork 39
[김영현] Sprint5 #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GANGYIKIM
merged 53 commits into
codeit-bootcamp-frontend:React-김영현
from
0Hyunn:React-김영현-sprint5
Apr 11, 2025
The head ref may contain hidden characters: "React-\uAE40\uC601\uD604-sprint5"
Merged
[김영현] Sprint5 #172
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
b5162a0
init: CRA 제거 후 Vite 프로젝트 세팅 초기화
0Hyunn 217dd19
chore: readme.md 수정
0Hyunn 21b2638
feat: react-router-dom 설치 및 라우팅 기능 도입
0Hyunn 26c2e36
chore: 불필요한 파일 삭제 및 초기화
0Hyunn 8490944
chore: eslint 수정
0Hyunn ab7260b
chore: src/api와 src/components 폴더 버전관리 추가
0Hyunn ef4eaf8
chore: title 변경
0Hyunn dc24d45
feat: 상단 네비게이션 바 버튼 색상 추가
0Hyunn 5218ff0
feat: 라우터 및 라우팅 네비게이션 구조 구현
0Hyunn b225153
fix: 오타 수정
0Hyunn 085de57
Update README.md
0Hyunn 1751537
feat: Items 페이지 컴포넌트 생성 및 상품 리스트 렌더링 구현
0Hyunn cd8b459
feat: 설정된 라우팅에 /items 경로 추가
0Hyunn faadfcb
feat: 상품 목록 가져오는 getProducts 함수 추가
0Hyunn 955987b
chore: items.jsx 및 관련 스타일 제거
0Hyunn 70d9e64
chore: 진행상황 최신화
0Hyunn fb41d41
refactor: 파라미터로 query를 받도록 수정
0Hyunn 9e8d6a5
feat: 베스트 상품 출력 기능 구현
0Hyunn c63c91b
chore: 이미지가 없는 데이터에 default 사진 추가
0Hyunn 9b12db2
feat: 전체 상품 리스트 보여주는 컴포넌트 기능 구현
0Hyunn 71496d7
feat: 상품 카드 하나씩 보여주는 컴포넌트
0Hyunn 14f8d22
feat: 페이징 처리 구현
0Hyunn c6f96f4
style: 스타일 추가
0Hyunn 2d824f0
feat: 상품 데이터 처음 불러올때 전체 불러오도록 하는 기능 추가
0Hyunn d7ca17e
feat: 베스트 상품 top4 보여주는 컴포넌트
0Hyunn fe4ebb0
docs: Readme 수정
0Hyunn 02f53dd
feat: 로고 이미지, 상품 기본 이미지 추가
0Hyunn 2cabb8f
feat: 재사용성을 고려하여 상품 검색 입력 폼 컴포넌트 추가
0Hyunn 116f1fa
feat: 상품 등록하기 컴포넌트
0Hyunn 01710a3
docs: README 요구사항 달성 최신화
0Hyunn 5ed6990
feat: AddItem 페이지 연결 & 헤더 구현
0Hyunn d409f18
refactor: 베스트 상품 title 명 수정
0Hyunn 32b2c27
fix: 파일명 수정
0Hyunn cdaa44c
styles: 전체 레이아웃 스타일 설정
0Hyunn e9c7165
refactor: h2 삭제 및 스타일 적용
0Hyunn 19d1719
feat: 페이징 처리, 상품 등록, 검색 기능 추가
0Hyunn 1633a7e
feat: 페이징 처리 컴포넌트 추가 (5개씩 나눠서 페이징 처리)
0Hyunn f3b405a
styles: 페이징 버튼 스타일 추가
0Hyunn 22c40da
docs: 요구사항 달성률 최신화
0Hyunn 7b1dc4f
styles: 헤더부분 반응형 처리
0Hyunn 558368d
fix: max-width: 1200px로 수정
0Hyunn d7f4063
feat: 반응형 별 개수 반환 로직
0Hyunn 04d76cb
feat: resize 시, 마운트 시 width에 따른 카운트 반환 로직 추가
0Hyunn 2651ab2
feat: 이미지 없는 객체에 대한 에러 핸들링 로직 추가
0Hyunn b1e4cab
totalpage 이름 수정 (s 제거)
0Hyunn 7c4f6fc
refactor: BEM 방식의 className 수정
0Hyunn ea49b34
chore: 컴포넌트 주석 작성
0Hyunn a316537
refactor: BEM 방식으로 classname 수정
0Hyunn c55ce1c
chore: 컴포넌트 주석 작성
0Hyunn 2ff5b97
fix: useEffect에서 resize 이벤트 리스너 등록 및 정리 위치 수정
0Hyunn eac5b9e
refactor: BEM 방식으로 className 수정 및 주석 추가
0Hyunn 2500fb3
chore: 페이지 주석 추가
0Hyunn 9b9662b
refactor: className 수정
0Hyunn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,24 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.js | ||
|
|
||
| # testing | ||
| /coverage | ||
|
|
||
| # production | ||
| /build | ||
|
|
||
| # misc | ||
| .DS_Store | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
|
|
||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
| lerna-debug.log* | ||
|
|
||
| node_modules | ||
| dist | ||
| dist-ssr | ||
| *.local | ||
|
|
||
| # Editor directories and files | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| .DS_Store | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,70 +1,35 @@ | ||
| # Getting Started with Create React App | ||
| # 스프린트 미션 5 | ||
|
|
||
| This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
| ## [기본 요구사항] | ||
|
|
||
| ## Available Scripts | ||
| - [x] 중고마켓 페이지 주소는 "/items"입니다. | ||
| - [x] 페이지 주소가 “/items” 일때 상단네비게이션바의 “중고마켓" 버튼의 색상은 “3692FF”입니다. | ||
| - [x] 상단 네비게이션 바는 이전 미션에서 구현한 랜딩 페이지와 동일한 스타일로 만들어 주세요. | ||
| - [x] 전체 상품에서 드롭 다운으로 “최신 순” 또는 “좋아요 순”을 선택해서 정렬을 할 수 있습니다. | ||
| - [x] '상품 등록하기’ 버튼을 누르면 “/additem” 로 이동합니다 ( 빈 페이지 ) | ||
| - [x] 카드 데이터는 제공된 백엔드 API 페이지의 GET 메소드인 “/products”를 사용해주세요 | ||
| - [x] 미디어 쿼리를 사용하여 반응형 view 마다 물품 개수를 다르게 보여줍니다 (서버로 요청하는 값은 동일) | ||
|
|
||
| In the project directory, you can run: | ||
| ### 베스트 상품 기준 | ||
|
|
||
| ### `npm start` | ||
| - [x] 정렬: favorite | ||
| - [x] favorite가 가장 높은 상품 4가지 | ||
|
|
||
| Runs the app in the development mode.\ | ||
| Open [http://localhost:3000](http://localhost:3000) to view it in your browser. | ||
| ### 베스트 상품 | ||
|
|
||
| The page will reload when you make changes.\ | ||
| You may also see any lint errors in the console. | ||
| - [x] Desktop : 4개 보이기 | ||
| - [x] Tablet : 2개 보이기 | ||
| - [x] Mobile : 1개 보이기 | ||
|
|
||
| ### `npm test` | ||
| ### 전체 상품 | ||
|
|
||
| Launches the test runner in the interactive watch mode.\ | ||
| See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. | ||
| - [x] Desktop : 10개 보이기 | ||
| - [x] Tablet : 6개 보이기 | ||
| - [x] Mobile : 4개 보이기 | ||
|
|
||
| ### `npm run build` | ||
| --- | ||
|
|
||
| Builds the app for production to the `build` folder.\ | ||
| It correctly bundles React in production mode and optimizes the build for the best performance. | ||
| ## [심화 요구사항] | ||
|
|
||
| The build is minified and the filenames include the hashes.\ | ||
| Your app is ready to be deployed! | ||
|
|
||
| See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. | ||
|
|
||
| ### `npm run eject` | ||
|
|
||
| **Note: this is a one-way operation. Once you `eject`, you can't go back!** | ||
|
|
||
| If you aren't satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. | ||
|
|
||
| Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own. | ||
|
|
||
| You don't have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it. | ||
|
|
||
| ## Learn More | ||
|
|
||
| You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started). | ||
|
|
||
| To learn React, check out the [React documentation](https://reactjs.org/). | ||
|
|
||
| ### Code Splitting | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/code-splitting](https://facebook.github.io/create-react-app/docs/code-splitting) | ||
|
|
||
| ### Analyzing the Bundle Size | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size](https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size) | ||
|
|
||
| ### Making a Progressive Web App | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app](https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app) | ||
|
|
||
| ### Advanced Configuration | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/advanced-configuration](https://facebook.github.io/create-react-app/docs/advanced-configuration) | ||
|
|
||
| ### Deployment | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/deployment](https://facebook.github.io/create-react-app/docs/deployment) | ||
|
|
||
| ### `npm run build` fails to minify | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify](https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify) | ||
| - [x] 페이지 네이션 기능을 구현합니다. | ||
| - [ ] 반응형으로 보여지는 물품들의 개수를 다르게 설정할때 서버에 보내는 pageSize값을 적절하게 설정합니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import js from "@eslint/js"; | ||
| import globals from "globals"; | ||
| import reactHooks from "eslint-plugin-react-hooks"; | ||
| import reactRefresh from "eslint-plugin-react-refresh"; | ||
|
|
||
| export default [ | ||
| { ignores: ["dist"] }, | ||
| { | ||
| files: ["**/*.{js,jsx}"], | ||
| languageOptions: { | ||
| ecmaVersion: 2020, | ||
| globals: globals.browser, | ||
| parserOptions: { | ||
| ecmaVersion: "latest", | ||
| ecmaFeatures: { jsx: true }, | ||
| sourceType: "module", | ||
| }, | ||
| }, | ||
| plugins: { | ||
| "react-hooks": reactHooks, | ||
| "react-refresh": reactRefresh, | ||
| }, | ||
| rules: { | ||
| ...js.configs.recommended.rules, | ||
| ...react.configs.recommended.rules, | ||
| ...react.configs["jsx-runtime"].rules, | ||
| ...reactHooks.configs.recommended.rules, | ||
|
|
||
| "react/jsx-no-target-blank": "off", | ||
| "react-refresh/only-export-components": ["warn", { allowConstantExport: true }], | ||
| "no-unused-vars": ["warn", { varsIgnorePattern: "^[A-Z_]" }], | ||
| "react/prop-types": "off", | ||
| }, | ||
| }, | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="ko"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>판다마켓</title> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> | ||
| <script type="module" src="/src/main.jsx"></script> | ||
| </body> | ||
| </html> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💊 제안
3번째 미션에서 추가하셨던 메타 태그도 추가하시면 더 좋을 것 같아요!