-
Notifications
You must be signed in to change notification settings - Fork 39
[명지우] sprint5 #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GANGYIKIM
merged 33 commits into
codeit-bootcamp-frontend:React-명지우
from
MyungJiwoo:React-명지우-sprint5
May 12, 2025
The head ref may contain hidden characters: "React-\uBA85\uC9C0\uC6B0-sprint5"
Merged
[명지우] sprint5 #184
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
b2e37bd
reset
hanseulhee 6f8bbb0
Merge branch 'codeit-bootcamp-frontend:main' into main
hanseulhee e11e25f
fix: 머지 후 브랜치 삭제 github action 수정
hanseulhee 212e864
env: workflows 폴더로 이동
hanseulhee 4dc5dd0
Merge pull request #237 from hanseulhee/fix-github-actions
withyj-codeit 17e3a73
Merge branch 'React-명지우' of https://github.com/codeit-bootcamp-fronte…
MyungJiwoo f21f58b
chore: react(v19) + vite(v6) + emotion(v11)으로 프로젝트 초기 설정
MyungJiwoo 07fbe9a
feat: 모든 페이지에 Header 추가
MyungJiwoo 23325f2
chore: 레이아웃 확인용 dummy 페이지 생성
MyungJiwoo 06dbda7
docs: 메타 태그 추가 및 Title 수정
MyungJiwoo ba2bc39
feat: ProductCard 공통 컴포넌트 추가
MyungJiwoo 9d2c2bf
chore: axios 설치 및 instance 설정
MyungJiwoo 653eedb
fix: svg 프로퍼티명 수정
MyungJiwoo 6807b8e
refactor: ProductCard 합성 컴포넌트 내부에 자식 컴포넌트 추가
MyungJiwoo d57176e
refactor: 중복된 스타일 변수 제거
MyungJiwoo 3d917ab
feat: 베스트 상품 목록 구현
MyungJiwoo 0ccb644
refactor: breakpoints 상수 사용 및 변수명 변경
MyungJiwoo f81d4ad
feat: items 페이지 기본 레이아웃 설계
MyungJiwoo 181c993
feat: 파비콘 아이콘 추가
MyungJiwoo 248050d
chore: 필요한 아이콘 및 이미지 추가
MyungJiwoo 22ac992
chore: dummy 페이지 생성 (상품 추가 페이지)
MyungJiwoo 397c7c3
refactor: z-index 및 반응형별 헤더 레이아웃 수정
MyungJiwoo d62c582
refactor: 불필요한 주석 제거
MyungJiwoo 272c420
feat: 없는 상품 이미지 예외 처리
MyungJiwoo 9825fac
refactor: 컴포넌트에 key 추가
MyungJiwoo 000a2b0
feat: 전체 상품 목록 구현
MyungJiwoo e6fedc3
docs: 요구사항 목록 정리 및 체크
MyungJiwoo b6ac4c2
refactor: 서버에 요청할 데이터 개수 계산 커스텀 훅 생성
MyungJiwoo 1687925
refactor: useResponsivePageSize 훅 사용 및 코드 분리
MyungJiwoo b3e2771
deploy: netlify 배포 설정 (react)
MyungJiwoo 6b73307
refactor: 반응형 디자인 코드 정리
MyungJiwoo 38ae6a0
docs: README에 배포 url 추가
MyungJiwoo c277965
fix: 정렬시 페이지네이션 초기화
MyungJiwoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,24 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.js | ||
|
|
||
| # testing | ||
| /coverage | ||
|
|
||
| # production | ||
| /build | ||
|
|
||
| # misc | ||
| .DS_Store | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
|
|
||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
| lerna-debug.log* | ||
|
|
||
| node_modules | ||
| dist | ||
| dist-ssr | ||
| *.local | ||
|
|
||
| # Editor directories and files | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| .DS_Store | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,70 +1,44 @@ | ||
| # Getting Started with Create React App | ||
| ## 판다마켓 5 | ||
|
|
||
| This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
| **🌐 배포 url: https://myungjiwoo-pandamarket.netlify.app/items** | ||
|
|
||
| ## Available Scripts | ||
| ### 기본 요구사항 | ||
|
|
||
| In the project directory, you can run: | ||
| - [x] Github의 PR을 만들어서 미션을 제출한다. | ||
| - [x] 피그마 디자인에 맞게 페이지를 만든다. | ||
| - [x] React를 활용해서 구현한다. | ||
|
|
||
| ### `npm start` | ||
| ### 체크 리스트 (기본) | ||
|
|
||
| Runs the app in the development mode.\ | ||
| Open [http://localhost:3000](http://localhost:3000) to view it in your browser. | ||
| - [x] 중고마켓 페이지 주소는 "/items"이다. | ||
| - [x] 페이지 주소가 "/items"일 때 상단 네비게이션바의 "중고마켓" 버튼의 색상은 "3692FF"이다. | ||
| - [x] 상단 네비게이션 바는 이전 미션에서 구현한 랜딩 페이지와 동일한 스타일로 제작한다. | ||
|
|
||
| The page will reload when you make changes.\ | ||
| You may also see any lint errors in the console. | ||
| **데이터 불러오기** | ||
|
|
||
| ### `npm test` | ||
| - [x] 카드 데이터는 제공된 백엔드 API 페이지의 GET 메소드인 "/products"를 사용한다. | ||
|
|
||
| Launches the test runner in the interactive watch mode.\ | ||
| See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. | ||
| **상품 정렬** | ||
|
|
||
| ### `npm run build` | ||
| - [x] 전체 상품에서 드롭 다운으로 "최신 순" 또는 "좋아요 순"을 선택해서 정렬할 수 있다. | ||
| - [x] "상품 등록하기" 버튼을 누르면 "/additem"으로 이동한다. (빈 페이지) | ||
| - [x] 베스트 상품 기준 | ||
| - 정렬 : favorite | ||
| - favorite가 가장 높은 상품 4가지 | ||
|
|
||
| Builds the app for production to the `build` folder.\ | ||
| It correctly bundles React in production mode and optimizes the build for the best performance. | ||
| **반응형 디자인** | ||
|
|
||
| The build is minified and the filenames include the hashes.\ | ||
| Your app is ready to be deployed! | ||
| - [x] 미디어 쿼리를 사용해서 반응형 view마다 물품의 개수를 다르게 보여준다. (서버로 요청하는 값은 동일) | ||
| - [x] 베스트 상품 | ||
| - Desktop : 4개 보이기 | ||
| - Tablet : 2개 보이기 | ||
| - Mobile : 1개 보이기 | ||
| - [x] 전체 상품 | ||
| - Desktop : 10개 보이기 | ||
| - Tablet : 6개 보이기 | ||
| - Mobile : 4개 보이기 | ||
|
|
||
| See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. | ||
| ### 체크 리스트 (심화) | ||
|
|
||
| ### `npm run eject` | ||
|
|
||
| **Note: this is a one-way operation. Once you `eject`, you can't go back!** | ||
|
|
||
| If you aren't satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. | ||
|
|
||
| Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own. | ||
|
|
||
| You don't have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it. | ||
|
|
||
| ## Learn More | ||
|
|
||
| You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started). | ||
|
|
||
| To learn React, check out the [React documentation](https://reactjs.org/). | ||
|
|
||
| ### Code Splitting | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/code-splitting](https://facebook.github.io/create-react-app/docs/code-splitting) | ||
|
|
||
| ### Analyzing the Bundle Size | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size](https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size) | ||
|
|
||
| ### Making a Progressive Web App | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app](https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app) | ||
|
|
||
| ### Advanced Configuration | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/advanced-configuration](https://facebook.github.io/create-react-app/docs/advanced-configuration) | ||
|
|
||
| ### Deployment | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/deployment](https://facebook.github.io/create-react-app/docs/deployment) | ||
|
|
||
| ### `npm run build` fails to minify | ||
|
|
||
| This section has moved here: [https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify](https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify) | ||
| - [x] 페이지네이션 기능을 구현한다. | ||
| - [x] 반응형으로 보여지는 물품들의 개수를 다르게 설정할 때 서버에 보내는 pageSize 값을 적절하게 설정한다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import js from '@eslint/js' | ||
| import globals from 'globals' | ||
| import reactHooks from 'eslint-plugin-react-hooks' | ||
| import reactRefresh from 'eslint-plugin-react-refresh' | ||
|
|
||
| export default [ | ||
| { ignores: ['dist'] }, | ||
| { | ||
| files: ['**/*.{js,jsx}'], | ||
| languageOptions: { | ||
| ecmaVersion: 2020, | ||
| globals: globals.browser, | ||
| parserOptions: { | ||
| ecmaVersion: 'latest', | ||
| ecmaFeatures: { jsx: true }, | ||
| sourceType: 'module', | ||
| }, | ||
| }, | ||
| plugins: { | ||
| 'react-hooks': reactHooks, | ||
| 'react-refresh': reactRefresh, | ||
| }, | ||
| rules: { | ||
| ...js.configs.recommended.rules, | ||
| ...reactHooks.configs.recommended.rules, | ||
| 'no-unused-vars': ['error', { varsIgnorePattern: '^[A-Z_]' }], | ||
| 'react-refresh/only-export-components': [ | ||
| 'warn', | ||
| { allowConstantExport: true }, | ||
| ], | ||
| }, | ||
| }, | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>판다마켓</title> | ||
| <meta name="title" content="판다 마켓" /> | ||
| <meta name="description" content="일상의 모든 물건을 거래해보세요" /> | ||
| <meta name="keywords" content="판다 마켓, 중고 거래, 일상 물건" /> | ||
| <meta property="og:title" content="판다 마켓" /> | ||
| <meta property="og:description" content="일상의 모든 물건을 거래해보세요" /> | ||
| <meta name="twitter:title" content="판다 마켓" /> | ||
| <meta | ||
| name="twitter:description" | ||
| content="일상의 모든 물건을 거래해보세요" | ||
| /> | ||
| <link rel="icon" href="/favicon.png" /> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> | ||
| <script type="module" src="/src/main.jsx"></script> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| [[redirects]] | ||
| from = "/*" | ||
| to = "/index.html" | ||
| status = 200 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ 수정요청