-
Notifications
You must be signed in to change notification settings - Fork 39
[유동환] sprint7 #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GANGYIKIM
merged 9 commits into
codeit-bootcamp-frontend:React-유동환
from
TopiaYu:React-유동환-sprint7
May 19, 2025
The head ref may contain hidden characters: "React-\uC720\uB3D9\uD658-sprint7"
Merged
[유동환] sprint7 #221
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
adf1573
allitem에서 선택시 호버, productId로 이동
TopiaYu 46ebd1a
itemDetail 라우팅 설정
TopiaYu 0452f0d
ui완성
TopiaYu 9771578
allitem, bestItem에 api 연결 및 컨텐츠 연결, ui 수정
TopiaYu ffb83f0
목록으로 돌아가기 구현
TopiaYu c33cafa
코멘트 남겼을때 버튼 색 변경
TopiaYu 8879b1a
아이템 default 이미지 추가, 코멘트 없을때 default이미지 추가
TopiaYu 906af6d
세부아이템 페이지에 들어가면 중고마켓 hearder 파란색으로 표시
TopiaYu ccaea14
반응형 수정
TopiaYu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -3,6 +3,7 @@ import { | |||||||||
| header, | ||||||||||
| title, | ||||||||||
| itemGrid, | ||||||||||
| itemLinkStyle, | ||||||||||
| pagenation | ||||||||||
| } from "./AllitemsStyle"; | ||||||||||
| import ItemList from "./ItemList"; | ||||||||||
|
|
@@ -21,7 +22,6 @@ const AllItems = ({ items, onChangeOrder }) => { | |||||||||
| <input placeholder="🔎 검색할 상품을 입력해주세요"></input> | ||||||||||
| <Link to={"/additems"}> | ||||||||||
| 상품 등록하기 | ||||||||||
| {/* <button >상품 등록하기</button> */} | ||||||||||
| </Link> | ||||||||||
| <select onChange={(e)=> onChangeOrder(e.target.value)}> | ||||||||||
| <option value={"recent"}>최신순</option> | ||||||||||
|
|
@@ -32,7 +32,9 @@ const AllItems = ({ items, onChangeOrder }) => { | |||||||||
| <div css={itemGrid} > | ||||||||||
| {items.map((item) => { | ||||||||||
| return( | ||||||||||
| <ItemList key={item.id} item={item} /> | ||||||||||
| <Link to={`/Items/${item.id}`} css={itemLinkStyle} > | ||||||||||
| <ItemList key={item.id} item={item} /> | ||||||||||
|
Comment on lines
+35
to
+36
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❗️ 수정요청
Suggested change
|
||||||||||
| </Link> | ||||||||||
| ) | ||||||||||
| })} | ||||||||||
| </div> | ||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,9 @@ | ||||||||||
| import { Link } from "react-router-dom"; | ||||||||||
| import { | ||||||||||
| constainer, | ||||||||||
| title, | ||||||||||
| itemGrid, | ||||||||||
| linkStyle, | ||||||||||
| } from "./BestItemStyle"; | ||||||||||
| import ItemList from "./ItemList"; | ||||||||||
|
|
||||||||||
|
|
@@ -18,8 +20,12 @@ const BestItem = ({ items }) => { | |||||||||
|
|
||||||||||
| <div css={itemGrid} > | ||||||||||
| {bestItems.map((item) => { | ||||||||||
| return <ItemList key={item.id} item={item}/> | ||||||||||
| })} | ||||||||||
| return ( | ||||||||||
| <Link to={`${item.id}`} css={linkStyle}> | ||||||||||
| <ItemList key={item.id} item={item}/> | ||||||||||
|
Comment on lines
+24
to
+25
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❗️ 수정요청
Suggested change
|
||||||||||
| </Link> | ||||||||||
| ) | ||||||||||
| })} | ||||||||||
| </div> | ||||||||||
| </div> | ||||||||||
| ) | ||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ 수정요청
지금은 고정값으로 코멘트를 불러오고 있어요~
모든 코멘트가 보이도록 무한스크롤 방식으로 구현해주시면 좋겠습니다!