[문주영] Sprint9 #227
Merged
[문주영] Sprint9 #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
불필요한 코드들 삭제
border 값 고려한 크기로 변경
GANGYIKIM
approved these changes
Jul 1, 2025
Collaborator
GANGYIKIM
left a comment
GANGYIKIM
left a comment
There was a problem hiding this comment.
주영님 9번째 미션 작업 수고하셨습니다!
next를 사용하는 첫번째 미션이신데 정말 잘 하셨어요.
다음 미션도 화이팅입니다!
➕ 커밋 단위를 잘게 쪼개시고 컨벤셔널하게 커밋 메시지를 남기시는 습관도 너무 좋습니다!
Collaborator
There was a problem hiding this comment.
💊 제안
체크박스의 경우 해당 이미지 없이도 구현이 가능하니, html과 css만으로 구현하시는 것이 성능이나 유지보수 측면에서 더 좋을 것 같아요!
Collaborator
There was a problem hiding this comment.
💊 제안
svg로 추출하셨으니 이미지 하나를 가지고 코드를 통해 이미지의 크기나 색을 변경하셔서 사용하시는 것을 추천드려요!
Comment on lines
+2
to
+3
| import "@/styles/global.css"; | ||
| import "@/styles/reset.css"; |
Collaborator
There was a problem hiding this comment.
👍 칭찬
기본적인 스타일들 추가하신 것 좋습니다!
Comment on lines
+6
to
+8
| <Head> | ||
| <link rel="icon" href="/favicon.ico" /> | ||
| </Head> |
Collaborator
There was a problem hiding this comment.
👍 칭찬
파비콘 추가해주신 것 좋아요~ title과 같은 다른 메타 태그도 추가해주시면 더 좋을 것 같아요!
Comment on lines
+104
to
+106
| {items.filter((item) => item.isCompleted).length ? ( | ||
| items | ||
| .filter((item) => item.isCompleted) |
Collaborator
There was a problem hiding this comment.
💊 제안
filter를 두번 호출하고 계시니 한번만 호출할 수 있도록 수정하시면 더 좋을 것 같아요!
const completedItems = items.filter((item) => item.isCompleted)
...
{completedItems.length ? completedItems.map(...) : ... }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
.env.local에 넣어 환경변수로 처리했습니다.스크린샷
멘토에게