[이태식] sprint1 #32
There are no files selected for viewing
|
Collaborator
There was a problem hiding this comment. 💊 제안 |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
|
Collaborator
There was a problem hiding this comment. ❗️ 수정요청
Collaborator
There was a problem hiding this comment. 💬 여담
Collaborator
There was a problem hiding this comment. ❗️ 수정요청 |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,127 @@ | ||||||
| <!DOCTYPE html> | ||||||
| <html lang="ko"> | ||||||
| <head> | ||||||
| <meta charset="UTF-8"> | ||||||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||||||
| <title>판다마켓</title> | ||||||
| <link rel="stylesheet" href="style.css"> | ||||||
| </head> | ||||||
| <body> | ||||||
| <header> | ||||||
| <div class="gnb wrap"> | ||||||
| <a href="/" class="logo"> | ||||||
| <img src="./images/Property 1=sm.png" alt="판다마켓 로고"> | ||||||
|
Collaborator
There was a problem hiding this comment. 💊 제안
Suggested change
|
||||||
| </a> | ||||||
| <a href="/login" class="btn-login Text-lg semibold">로그인</a> | ||||||
|
Collaborator
There was a problem hiding this comment. ❗️ 수정요청 /login의 의미는 root 폴더의 login으로 접근하라는 의미라서, 만약 login.html 파일이 root 파일에 위치해있고
Suggested change
|
||||||
| </div> | ||||||
| </header> | ||||||
|
|
||||||
| <main> | ||||||
| <section class="home-top-section"> | ||||||
| <div class="home-top wrap"> | ||||||
| <div class="home-top-content"> | ||||||
| <p class="text-4xl bold"> | ||||||
|
Collaborator
There was a problem hiding this comment. 👍 칭찬 |
||||||
| 일상의 모든 물건을 <br> | ||||||
| 거래해 보세요 | ||||||
| </p> | ||||||
| <a href="/items" class="btn-large text-xl semibold">구경하러 가기</a> | ||||||
| </div> | ||||||
| <img src="./images/Img_home_top.png" alt="판다 이미지"> | ||||||
| </div> | ||||||
| </section> | ||||||
|
|
||||||
| <section class="home-section"> | ||||||
| <div class="home"> | ||||||
| <div class="home-content"> | ||||||
| <img src="./images/Img_home_01.png" alt="인기 상품"> | ||||||
| <div class="home-content-1"> | ||||||
| <p class="keyword text-2lg bold"> | ||||||
| Hot item | ||||||
| </p> | ||||||
| <p class="text-4xl bold"> | ||||||
| 인기 상품을<br> | ||||||
| 확인해 보세요 | ||||||
| </p> | ||||||
| <p class="home-describe text-2xl medium"> | ||||||
| 가장 HOT한 중고거래 물품을<br> | ||||||
| 판다 마켓에서 확인해 보세요 | ||||||
| </p> | ||||||
| </div> | ||||||
| </div> | ||||||
| </div> | ||||||
| <div class="home"> | ||||||
| <div class="home-content"> | ||||||
| <div class="home-content-2"> | ||||||
| <p class="keyword text-2lg bold"> | ||||||
| Search | ||||||
| </p> | ||||||
| <p class="text-4xl bold"> | ||||||
| 구매를 원하는<br> | ||||||
| 상품을 검색하세요 | ||||||
| </p> | ||||||
| <p class="home-describe text-2xl medium"> | ||||||
| 구매하고 싶은 물품은 검색해서<br> | ||||||
| 쉽게 찾아보세요 | ||||||
| </p> | ||||||
| </div> | ||||||
| <img src="./images/Img_home_02.png" alt="상품 검색"> | ||||||
| </div> | ||||||
| </div> | ||||||
| <div class="home"> | ||||||
| <div class="home-content"> | ||||||
| <img src="./images/Img_home_03.png" alt="상품 등록"> | ||||||
| <div class="home-content-3"> | ||||||
| <p class="keyword text-2lg bold"> | ||||||
| Register | ||||||
| </p> | ||||||
| <p class="text-4xl bold"> | ||||||
| 판매를 원하는<br> | ||||||
| 상품을 등록하세요 | ||||||
| </p> | ||||||
| <p class="home-describe text-2xl medium"> | ||||||
| 어떤 물건이든 판매하고 싶은 상품을<br> | ||||||
| 쉽게 등록하세요 | ||||||
| </p> | ||||||
| </div> | ||||||
| </div> | ||||||
| </div> | ||||||
| </section> | ||||||
|
|
||||||
| <section class="home-bottom-section"> | ||||||
| <div class="home-bottom wrap"> | ||||||
| <div class="home-bottom-content"> | ||||||
| <p class="text-4xl bold"> | ||||||
| 믿을 수 있는 <br> | ||||||
|
Collaborator
There was a problem hiding this comment. ❗️ 수정요청 지금 디자인에서 괜찮을 것 같지만 공백은 의도치 않은 동작을 발생시킬 수 있습니다~
Suggested change
|
||||||
| 판다마켓 중고 거래 | ||||||
| </p> | ||||||
| </div> | ||||||
| <img src="./images/Img_home_bottom.png" alt="판다 이미지"> | ||||||
| </div> | ||||||
| </section> | ||||||
| </main> | ||||||
|
|
||||||
| <footer> | ||||||
| <div class="footer-content wrap"> | ||||||
| <p class="copyright">@codeit - 2024</p> | ||||||
| <div class="faq"> | ||||||
| <a href="/privacy">Privacy Policy</a> | ||||||
| <a href="/faq">FAQ</a> | ||||||
| </div> | ||||||
| <div class="sns"> | ||||||
| <a href="https://facebook.com" target="_blank"> | ||||||
| <img src="./images/ic_facebook.png" alt="페이스북"> | ||||||
| </a> | ||||||
| <a href="https://twitter.com" target="_blank"> | ||||||
| <img src="./images/ic_twitter.png" alt="트위터"> | ||||||
| </a> | ||||||
| <a href="https://youtube.com" target="_blank"> | ||||||
| <img src="./images/ic_youtube.png" alt="유튜브"> | ||||||
| </a> | ||||||
| <a href="https://instagram.com" target="_blank"> | ||||||
| <img src="./images/ic_instagram.png" alt="인스타그램"> | ||||||
| </a> | ||||||
| </div> | ||||||
|
Comment on lines
+110
to
+123
Collaborator
There was a problem hiding this comment. 💊 제안 |
||||||
| </div> | ||||||
| </footer> | ||||||
| </body> | ||||||
| </html> | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,235 @@ | ||
| * { | ||
| box-sizing: border-box; | ||
| font-family: Pretendard, sans-serif; | ||
|
Collaborator
There was a problem hiding this comment. 💊 제안 font-family는 상속되는 속성이므로, 모든 태그에 개별적으로 지정하기보다 html이나 body 같은 상위 태그에 한 번만 적용하는 것이 더 효율적입니다. 이렇게 하면 하위 태그들이 자연스럽게 상속받아 일관된 스타일을 유지할 수 있어요. |
||
| color: #374151; | ||
| font-size: 16px; | ||
| } | ||
|
|
||
| a { | ||
| text-decoration: none; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| p { | ||
| margin: 0; | ||
| } | ||
|
Comment on lines
+1
to
+15
Collaborator
There was a problem hiding this comment. 💊 제안 간략한 reset css 속성들이라 따로 분리하지 않으시고 한 파일에 작성하셨나봐요~ |
||
|
|
||
| body { | ||
| margin: 0; | ||
| background-color: #FCFCFC; | ||
| } | ||
|
|
||
| header { | ||
| background-color: #FFFFFF; | ||
| border-bottom: 1px solid #DDE0E3 | ||
| } | ||
|
|
||
| footer { | ||
| background-color: #111827; | ||
| height: 10rem; | ||
| } | ||
|
|
||
| .gnb { | ||
| padding: 9px 400px; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .gnb img { | ||
| max-width: 10rem; | ||
| } | ||
|
|
||
| .wrap { | ||
| max-width: 1920px; | ||
| width: 100%; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .home-top-section img, .home-bottom-section img { | ||
| max-width: 45rem; | ||
| } | ||
|
|
||
| .home-top-section { | ||
| background-color: #CFE5FF; | ||
| height: 34rem; | ||
| } | ||
|
|
||
| .home-top { | ||
| height: 100%; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: flex-end; | ||
| } | ||
|
|
||
| .home-top-content{ | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 2rem; | ||
| padding-bottom: 4%; | ||
| } | ||
|
|
||
| .home-section img { | ||
| max-width: 36rem; | ||
| } | ||
|
|
||
| .home { | ||
| background-color: #FFFFFF; | ||
| height: 45rem; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .home-content{ | ||
| background-color: #FCFCFC; | ||
| display: flex; | ||
| justify-content: center; | ||
| gap: 4rem; | ||
| border-radius: 12px; | ||
| width: 65rem; | ||
| } | ||
|
|
||
| .home-content-1, .home-content-2, .home-content-3 { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| margin-right: 0.75rem; | ||
| } | ||
|
|
||
| .home-content-2 { | ||
| text-align: end; | ||
| margin-right: 0; | ||
| margin-left: 0.75rem; | ||
| } | ||
|
|
||
| .home-describe { | ||
| margin-top: 1.5rem; | ||
| } | ||
|
|
||
| .home-bottom-section { | ||
| background-color: #CFE5FF; | ||
| height: 33.75rem; | ||
| } | ||
|
|
||
| .home-bottom { | ||
| height: 100%; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: flex-end; | ||
| gap: 4rem; | ||
| } | ||
|
|
||
| .home-bottom-content { | ||
| padding-bottom: 10%; | ||
| } | ||
|
|
||
| .footer-content { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| max-width: 70rem; | ||
| padding-top: 1.5%; | ||
| } | ||
|
|
||
| .faq, .sns { | ||
| display: flex; | ||
| } | ||
|
|
||
| .faq { | ||
| gap: 2rem; | ||
| } | ||
|
|
||
| .sns { | ||
| gap: 0.75rem; | ||
| } | ||
|
|
||
| .btn-large, .btn-login { | ||
| background-color: #3692FF; | ||
| } | ||
|
|
||
| .btn-large:hover, .btn-login:hover { | ||
| background-color: #1967D6; | ||
| } | ||
|
|
||
| .btn-large:active, .btn-login:active { | ||
| background-color: #1251AA; | ||
| } | ||
|
|
||
| .btn-login { | ||
| color: #F3F4F6; | ||
| width: 8rem; | ||
| height: 3rem; | ||
| padding: 0.75rem 1.5rem; | ||
| border-radius: 8px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .btn-large { | ||
| color: #F9FAFB; | ||
| padding: 1rem 7.75rem; | ||
| border-radius: 40px; | ||
| } | ||
|
|
||
| .keyword { | ||
| color: #3692FF; | ||
| margin-bottom: 0.75rem; | ||
| } | ||
|
|
||
| .copyright, .faq { | ||
| font-size: 1rem; | ||
| font-weight: 400; | ||
| } | ||
|
|
||
| .copyright { | ||
| color: #9CA3AF; | ||
| } | ||
|
|
||
| .faq a { | ||
| color: #E5E7EB; | ||
| } | ||
|
|
||
| .bold { | ||
| font-weight: 700; | ||
| } | ||
|
|
||
| .semibold { | ||
| font-weight: 600; | ||
| } | ||
|
|
||
| .medium { | ||
| font-weight: 500; | ||
| } | ||
|
|
||
| .text-4xl { | ||
| font-size: 2.5rem; | ||
| line-height: 3.5rem; | ||
| letter-spacing: -0.125rem; | ||
| } | ||
|
|
||
| .text-2xl { | ||
| font-size: 1.5rem; | ||
| line-height: 2rem; | ||
| letter-spacing: -0.0625rem; | ||
| } | ||
|
|
||
| .text-xl { | ||
| font-size: 1.25rem; | ||
| line-height: 2rem; | ||
| } | ||
|
|
||
| .text-2lg { | ||
| font-size: 1.125rem; | ||
| line-height: 1.625rem; | ||
| } | ||
|
Comment on lines
+191
to
+223
Collaborator
There was a problem hiding this comment. 💊 제안
|
||
|
|
||
| @media (max-width:1920px) { | ||
| .gnb { | ||
| padding: 9px 200px | ||
| } | ||
| } | ||
|
|
||
| @media (max-width:1280px) { | ||
| * { | ||
| font-size: 12px; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.