Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added footer/faq.html
Empty file.
11 changes: 11 additions & 0 deletions footer/privacy.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>

</body>
</html>
Binary file added images/Component 2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Component [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Component [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Component 3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Component [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Component [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Group 19.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청

파일명을 Group 19.png처럼 작성하면 어떤 이미지인지 바로 알기 어렵고, 유지보수 시 파악하기 어렵습니다.

가능하면 이미지의 용도를 알 수 있는 의미 있는 이름으로 변경하는 것이 좋습니다.
해당 이미지의 경우 logo.png로 작성하면 파일명을 보자마자 로고라는 것을 알 수 있습니다.

또한, 띄어쓰기 대신 하이픈(-)이나 언더스코어(_)를 사용하면 코드 작성 시 불필요한 오류를 방지할 수 있어요!
그러니 자세한 이름, 공백 미사용, 그리고 동일한 네이밍 룰을 이용해 이미지명을 지으시는 것을 추천드려요!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
로고이미지가 여러개가 존재하네요~ 필요한 이미지만 남기시는 것을 추천드려요.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_01.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
해당 이미지 파일의 크기를 보면 588× 444로 되어 있습니다.
저희는 반응형 사이트를 만들고 있고, 이런 이미지들은 모바일에서도 사용할 것이기 때문에 추출하실때, 1배수가 아닌 2배수로 추출해주시는 것이 화질면에서 좋습니다.
아래처럼 figma export 탭에서 2x 로 설정하고 추출해주세요~

스크린샷 2025-02-24 오전 9 58 17 스크린샷 2025-02-24 오전 9 59 10

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions images/ic_facebook.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions images/ic_instagram.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions images/ic_twitter.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions images/ic_youtube.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/loginLogo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
330 changes: 330 additions & 0 deletions index.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,330 @@
* {
margin: 0;
padding: 0;
box-sizing: border-box;
overflow-x: hidden;
}
a {color: inherit; text-decoration: none; outline: none} a:hover, a:active {text-decoration: none;}
Comment on lines +1 to +7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안

간략한 reset css 속성들이라 따로 분리하지 않으시고 한 파일에 작성하셨나봐요~
하지만 필요시 특정 태그의 스타일을 초기화하는건 번거로운 일이고, 이를 염두에 두고 css 작성을 해야하니 가능하면 처음부터 브라우저 스타일을 초기화하시고 reset.css로 분리하시고 작업하시는 것을 추천드립니다!

구글에 reset.css, normalize.css로 검색해보시면 미리 작성된 css 파일이 있으니 확인해보시고 추가해보세요~

Comment on lines +1 to +7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
한 파일내에서는 같은 룰을 공유하는 것이 좋습니다. 또한 적절한 개행은 가독성에 도움이됩니다. 이 부분도 다른 부분처럼 개행하시는 것을 추천드려요~

Suggested change
* {
margin: 0;
padding: 0;
box-sizing: border-box;
overflow-x: hidden;
}
a {color: inherit; text-decoration: none; outline: none} a:hover, a:active {text-decoration: none;}
* {
margin: 0;
padding: 0;
box-sizing: border-box;
overflow-x: hidden;
}
a {
color: inherit; text-decoration: none; outline: none
a:hover, a:active {
text-decoration: none;
}

.wrap {
width: 100%;
height: auto;
}
header {
width: 100%;
height: 70px;
background: #fff;
}
header .container {
width: calc(100% - 27vw);
padding: 10px;
margin: 0 auto;
display: flex;
justify-content: space-between;
align-items: center;

}
.icon {
background-image: url(/images/Group\ 19.png);
width: 153px;
height: 51px;
cursor: pointer;
}
.login {
background: #3692FF;
width: 128px;
height: 48px;
border-radius: 8px;
color: #fff;
display: flex;
justify-content: center;
align-items: center;
cursor: pointer;
}
.login:hover {
background: #1251AA;
}
nav {
width: 100%;
height: 540px;
background: #cfe5ff;
display: flex;
}
nav .container {
width: calc(100% - 27vw);
margin: 0 auto;
display: grid;
grid-template: 1fr / 1fr 1fr;
align-items: end;
flex-direction: row;
}
.navDesc h4{
font-size: 1.4em;
color: #374151;
}
.navDesc button {
margin-bottom: 30%;
margin-top: 30px;
width: 20vw;
height: 46px;
color: #fff;
background: #3692FF;
border-radius: 40px;
border: none;
}
.navDesc button:hover {
background: #1251AA;
}
.navImgWrap {
width: 51vw;
height: 21vw;
}
.navImg {
background-image: url(/images/Img_home_top.png);
width: 100%;
height: 100%;
background-repeat: no-repeat;
background-size: contain;
}

main {
width: 100%;
height: auto;
background: #fff;
padding-bottom: 10%;
}
main .container {
width: calc(100% - 32vw);
margin: 0 auto;
/* background: #000; */
height: auto;
}
.mainWrap {
width: 100%;
height: 444px;
display: flex;
background: #fcfcfc;
margin-top: 10%;
}
.hotImg{
background-image: url(/images/Img_home_01.png);
width: 60%;
height: 444px;
background-repeat: no-repeat;
background-size: cover;
}
.searImg{
background-image: url(/images/Img_home_02.png);
width: 60%;
height: 444px;
background-repeat: no-repeat;
background-size: cover;
}

.mainTxt {
display: flex;
justify-content: center;
width: 40%;
}
.txtWrap {
width: calc(100% - 100px);
margin: 0 auto;
text-align: left;
display: flex;
flex-direction: column;
align-items: flex-start;
justify-content: center;
}
.searchtxtWrap {
width: calc(100% - 100px);
margin: 0 auto;
text-align: right;
display: flex;
flex-direction: column;
align-items: flex-start;
justify-content: center;
}

.SPANtitleTxt {
font-weight: bold;
font-size: 18px;
color: #3692FF;
line-height: 4;
}
.h4titleTxt {
font-weight: bold;
font-size: 30px;
}
.PtitleTxt {
margin-top: 20px;
font-size: 24px;
white-space: nowrap;

}
aside {
width: 100%;
height: 540px;
background: #cfe5ff;
display: flex;
}
aside .container {
width: calc(100% - 37vw);
margin: 0 auto;
display: grid;
grid-template: 1fr / 1fr 1fr;
align-items: end;
flex-direction: row;
}
aside h4{
font-size: 2em;
color: #374151;
margin-bottom: 30%;
}
.asideImgWrap {
width: 44vw;
height: 22vw;
}
.asideImg {
background-image: url(/images/Img_home_bottom.png);
width: 100%;
height: 100%;
background-repeat: no-repeat;
background-size: cover;
}
footer {
width: 100%;
height: 160px;
background: #111827;
display: flex;
padding-top: 30px;
}
.footerTxtWrap {
display: flex;
gap: 20px;
}

footer .container {
width: calc(100% - 27vw);
margin: 0 auto;
height: auto;
/* background: #fff; */
}
.footerTxt {
color: #9ca3af;
font-size: 16px;
display: flex;
justify-content: space-between;
}
.iconWrap {
display: flex;
gap: 20px;
}
.facebook {
width: 20px;
height: 20px;
background-size: cover;
background-image: url(/images/ic_facebook.svg);
cursor: pointer;
}
.twitter {
width: 20px;
height: 20px;
background-size: cover;
background-image: url(/images/ic_twitter.svg);
cursor: pointer;
}
.youtube {
width: 20px;
height: 20px;
background-size: cover;
background-image: url(/images/ic_youtube.svg);
cursor: pointer;
}
.insta {
width: 20px;
height: 20px;
background-size: cover;
background-image: url(/images/ic_instagram.svg);
cursor: pointer;
}
.txt2, .txt3 {
cursor: pointer;
color: #374151;
}
@media (max-width: 800px) {
header .container {
width: 100%;
padding: 10px;
}
nav {
height: 771px;
position: relative;
background: #cfe5ff;
}
nav .container {
display: flex;
width: auto;
width: 100%;

text-align: center;
}
nav .navImgWrap {
width: 100%;
height: 23vh;
}
nav .navImgWrap .navImg {
background-size: cover;
background-repeat: no-repeat;
}
.navDesc {
position: absolute;
top: 10%;
}
.navDesc h4 {
font-size: 2vw;
white-space: nowrap;
margin-bottom: 20px;
}
.navDesc button {
margin-bottom: 0;
margin-top: 0;
width: 357px;
}
}
@media (max-width: 375px) {
nav {
height: 540px;
position: relative;
background: #cfe5ff;
}
nav .container {
display: flex;
width: auto;
width: 100%;
text-align: center;
}
nav .navImgWrap {
width: 120vw;
height: 10vh;
}
nav .navImgWrap .navImg {
width: 100%;
height: 10vh;
background-repeat: no-repeat;
}
.navDesc {
display: flex; /* 중앙 정렬을 위해 flexbox 사용 */
justify-content: center; /* 가로 중앙 정렬 */
align-items: center; /* 세로 중앙 정렬 */
flex-direction: column; /* 텍스트와 버튼을 세로로 배치 */
Comment on lines +314 to +318
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
주석을 다는 것은 좋은 습관입니다. 다만 주석또한 읽어야하는 정보라 중복되지 않는 내용을 입력해주시는 것이 가독성면에서 더 좋아요.
지금 주석은 css 를 통해 파악할 수 있는 내용이라 없어도 될 것 같습니다~

text-align: center;
}
.navDesc h4 {
font-size: 40px;
margin-bottom: 20px;
}
.navDesc button {
margin-bottom: 0;
margin-top: 0;
width: 240px;
}
}
Loading
Loading