Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .DS_Store
Binary file not shown.
4 changes: 4 additions & 0 deletions .gitignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 칭찬
깃에 올라가지 않을 파일을 관리해주시는 것 좋습니다~

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.DS_Store
._.DS_Store
**/.DS_Store
**/._.DS_Store
Binary file removed image/.DS_Store
Binary file not shown.
Binary file modified image/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified image/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified image/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified image/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified image/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed image/btn_large.png
Binary file not shown.
Binary file removed image/btn_small.png
Binary file not shown.
Binary file removed image/desktop_01.png
Binary file not shown.
Binary file removed image/desktop_02.png
Binary file not shown.
Binary file removed image/desktop_03.png
Binary file not shown.
Binary file removed image/desktop_04.png
Binary file not shown.
Binary file removed image/desktop_05.png
Binary file not shown.
Binary file added image/google_logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified image/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified image/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified image/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified image/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/kakao_logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed image/판다 얼굴.png
Binary file not shown.
Binary file modified image/판다마켓.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/판다얼굴.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
67 changes: 35 additions & 32 deletions index.html
Original file line number Diff line number Diff line change
@@ -1,34 +1,31 @@

<!DOCTYPE html>
<html lang = "en">
<html lang = "ko">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/variable/pretendardvariable.min.css" />
<link rel="stylesheet" href="style.css">
<!-- <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/reset.min.css"/> -->


<title>판다마켓</title>
</head>
<body>
<div class="conatiner">
<div class="container">
<div class="header-wrapper">
<header>
<a class="logo" href="index.html">
<div class="logo-image">
<img src="image/판다 얼굴.png">
<img src="image/판다얼굴.png">
</div>
<div class="logo-text">
<img src="image/판다마켓.png">
</div>
</a>
<div class="login">
<a class="login-button" href="login.html">
<button class="login-button">
로그인
</button>
<a class="login-button button" href="login.html">
로그인
</a>
</div>
</header>
</div>

Expand All @@ -41,10 +38,8 @@
일상의 모든 물건을<br>
거래해 보세요
</p>
<a class="find-items-button" href="items.html">
<button class="find-items-button">
<a class="find-items-button button" href="items.html">
구경하러 가기
</button>
</a>
</div>

Expand All @@ -60,9 +55,9 @@
<img src="image/Img_home_01.png">
</div>
<div class="hot-item-text">
<h1>
<p>
Hot item
</h1>
</p>
<h2>
인기 상품을<br>
확인해 보세요
Expand All @@ -78,9 +73,9 @@ <h3>
<section class="Search">
<div class="Search">
<div class="search-text">
<h1>
<p>
Search
</h1>
</p>
<h2>
구매를 원하는<br>
상품을 검색하세요
Expand All @@ -103,9 +98,9 @@ <h3>
<img src="image/Img_home_03.png">
</div>
<div class="register-text">
<h1>
<p>
Register
</h1>
</p>
<h2>
판매를 원하는<br>
상품을 등록하세요
Expand Down Expand Up @@ -153,20 +148,28 @@ <h3>
</a>
</div>

<div class="footer-right-sns">
<a href="/faq.html">
<img src="/image/ic_facebook.png" alt="페이스북">
</a>
<a href="/faq.html">
<img src="/image/ic_twitter.png" alt="트위터">
</a>
<a href="/faq.html">
<img src="/image/ic_youtube.png" alt="유튜브">
</a>
<a href="/faq.html">
<img src="/image/ic_instagram.png" alt="인스타">
</a>
</div>
<ul class="footer-right-sns">
<li>
<a href="/faq.html">
<img src="/image/ic_facebook.png" alt="페이스북">
</a>
</li>
<li>
<a href="/faq.html">
<img src="/image/ic_twitter.png" alt="트위터">
</a>
</li>
<li>
<a href="/faq.html">
<img src="/image/ic_youtube.png" alt="유튜브">
</a>
</li>
<li>
<a href="/faq.html">
<img src="/image/ic_instagram.png" alt="인스타">
</a>
</li>
</ul>
</div>
</footer>
</div>
Expand Down
2 changes: 1 addition & 1 deletion items.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en">
<html lang="ko">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
Expand Down
122 changes: 122 additions & 0 deletions login.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
로그인 페이지와 회원 가입 페이지가 디자인이 비슷한만큼 공통적으로 사용하는 css가 많아 보입니다.
이러한 중복을 줄이기 위해 공통 CSS 파일을 작성하시면 유지보수 및 가독성 측면에서 더 좋을 것 같습니다.

auth.css // login, sign-up 페이지에서 공통으로 쓰는 것들의 모음
login.css 
signup.css 

만약 login.css, signup.css 파일에서 작성되는 css가 너무 적다면, 즉 분리할 필요를 못 느끼신다면
하나로 합치셔서 관리해도 좋을 것 같아요~

Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
* {
box-sizing: border-box;
}

/* 버튼 관련 */
.login-button {
width: 100%;
height: 56px;
border-radius: 40px;
background-color: #3692FF;
display: flex;
flex-direction: row;
justify-content: center;
align-items: center;
color: #F3F4F6;
margin-bottom: 24px;
font-size: 20px;
font-weight: 600;
}

/* 전체적인 틀 */
body {
font-family: "Pretendard Variable", Pretendard, sans-serif;

display: flex;
flex-direction: column;
align-items: center;
}

container {
margin-top: 231px;
width: 640px;
height: auto;
}

/* 로고관련 */
#logo > a {
display: flex;
flex-direction: row;
justify-content: center;
align-items: center;
gap: 22px;
margin-bottom: 40px;
}

/* 폼테그 관련 */
form {
display: flex;
flex-direction: column;
color: #1F2937;
font-size: 18px;
font-weight: 700;
}

form > lable {
margin-bottom: 16px;
}

form > input {
width: 100%;
height: 56px;
border: 0;
background-color: #F3F4F6;
border-radius: 12px;
margin-bottom: 24px;
}

input::placeholder {
font-size: 16px;
padding: 24px;
}

/* sns 로그인 관련 */
.sns-login {
display: flex;
flex-direction: row;
align-items: center;
justify-content: space-between;
background-color: #E6F2FF;
padding: 16px 23px;
border-radius: 8px;
margin-bottom: 24px;
font-size: 16px;
font-weight: 500;
}

.sns-login-image {
display: flex;
flex-direction: row;
gap: 16px;
}

.sns-login-image img {
width: 42px;
height: 42px;
}

/* footer 관련 */
.footer {
display: flex;
flex-direction: row;
align-items: center;
justify-content: center;
gap: 4px;
}

.footer a {
color: #3692FF;
}













Comment on lines +110 to +122
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
불필요한 공백은 지워주세요~

Suggested change

37 changes: 35 additions & 2 deletions login.html
Original file line number Diff line number Diff line change
@@ -1,11 +1,44 @@
<!DOCTYPE html>
<html lang="en">
<html lang="ko">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/variable/pretendardvariable.min.css" />
<link rel="stylesheet" href="login.css">
<title>Document</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
타이틀은 브라우저 탭에 표시되는 정보로 주로 어떤 사이트의 어떤 페이지에 머무르고 있는지를 표시합니다.
판다마켓 - 로그인 과 같은 형식으로 기입하셔서 유저에게 자세한 정보를 제공하시는 것을 추천드려요!

</head>
<body>
로그인 페이지
<container>
<div id="logo">
<a href="index.html">
<img src="./image/판다얼굴.png">
<img src="./image/판다마켓.png">
</a>
</div>
<form>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 칭찬
form 태그로 관련된 요소만 묶어 주신 것 좋습니다~

<lable>이메일</lable>
<input type="email" name="user-email" placeholder="이메일을 입력해주세요">
Comment on lines +19 to +20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
특정 input이 어떤 값을 받는지 설명하는 text들을 label 이라고 합니다.
이러한 친구들은 일반적으로 마우스로 선택시 연결된 input으로 focus가 이동하는 기능이 있습니다~
이를 위해, 그리고 명확한 연결관계 표시하기 위해 label 태그를 사용해주시는 것이 좋습니다~

또한 label인데 lable로 오타가 난 것 같으니 수정해주세요~

Suggested change
<lable>이메일</lable>
<input type="email" name="user-email" placeholder="이메일을 입력해주세요">
<label for='email'>이메일</label> // for 속성에 연결하고자하는 input id를 기입. 이렇게 하면 해당 태그 클릭시 연결된 input으로 포커스가 이동됩니다.
<input type="email" id="email" name="user-email" placeholder="이메일을 입력해주세요">

<lable>비밀번호</lable>
<input type="password" name="user-password" placeholder="비밀번호를 입력해주세요">
<div class="login-button">
로그인
</div>
Comment on lines +23 to +25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
해당 태그는 로그인 동작을 수행하는 태그이므로 button 태그가 더 적절합니다.
즉 form에서 제출 이벤트가 발생했을때 해당 form 안의 유저가 입력한 정보를 제출하는 역할을 하므로
button으로 작성해주세요!

Suggested change
<div class="login-button">
로그인
</div>
<button type="submit" class="login-button">
로그인
</button>

button 태그에서 type 속성은 해당 태그의 동작과 연관이 되어 있어 가능하면 늘 기입하시는 것이 좋습니다.
로그인 페이지의 form에서 로그인 버튼, 회원가입 페이지의 form에서 회원가입 버튼과 같은 경우는 submit 타입이고 그외 대부분의 버튼은 button 타입입니다.

</form>
<div class="sns-login">
<p>간편 로그인하기</p>
<div class="sns-login-image">
<a href="https://www.google.com/">
<img src="./image/google_logo.png" alt="구글로그인">
</a>
<a href="https://www.kakaocorp.com/page/">
<img src="./image/kakao_logo.png" alt="카카오톡 로그인">
</a>
</div>
</div>
<div class="footer">
<p>판다마켓이 처음인가요?</p>
<a href="./signup.html">회원가입</a>
</div>
</container>
</body>
</html>
48 changes: 48 additions & 0 deletions reset.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/* http://meyerweb.com/eric/tools/css/reset/
v2.0 | 20110126
License: none (public domain)
*/

html, body, div, span, applet, object, iframe,
h1, h2, h3, h4, h5, h6, p, blockquote, pre,
a, abbr, acronym, address, big, cite, code,
del, dfn, em, img, ins, kbd, q, s, samp,
small, strike, strong, sub, sup, tt, var,
b, u, i, center,
dl, dt, dd, ol, ul, li,
fieldset, form, label, legend,
table, caption, tbody, tfoot, thead, tr, th, td,
article, aside, canvas, details, embed,
figure, figcaption, footer, header, hgroup,
menu, nav, output, ruby, section, summary,
time, mark, audio, video {
margin: 0;
padding: 0;
border: 0;
font-size: 100%;
font: inherit;
vertical-align: baseline;
}
/* HTML5 display-role reset for older browsers */
article, aside, details, figcaption, figure,
footer, header, hgroup, menu, nav, section {
display: block;
}
body {
line-height: 1;
}
ol, ul {
list-style: none;
}
blockquote, q {
quotes: none;
}
blockquote:before, blockquote:after,
q:before, q:after {
content: '';
content: none;
}
table {
border-collapse: collapse;
border-spacing: 0;
}
Loading
Loading