Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
해당 파일은 mac에서 작업하실 때 생성되는 파일입니다.
해당 폴더에 대한 정보를 가지고 있는 파일로, 이러한 파일들은 git repo에 올라갈 이유가 없습니다~
git repo에는 공유할필요가 있는 파일들만 올라가면 되기 때문에 이러한 파일들은 git에 올라가지 않도록 관리하는 것이 좋습니다.
관련한 블로그 글이 있으니 읽어보시고, 제거하시는 것을 추천드릴께요~

블로그

Binary file not shown.
129 changes: 0 additions & 129 deletions .github/index.html

This file was deleted.

File renamed without changes
Binary file added img/google.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
Binary file added img/kakao.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
137 changes: 137 additions & 0 deletions index.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 제안
.github에 있던 파일을 밖으로 빼신 것 같아요~
다만 1주차에서 수정이 되지 않은 것 같으니 1주차 리뷰를 확인하시고 해당 파일의 코멘트들을 반영하시면 좋을 것 같습니다~

1회차 코드리뷰

Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="utf-8">
<title>판다마켓</title>
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.css">
<link rel="stylesheet" href="style.css">
</head>
<body>
<header>
<div class="container">
<div class="header-container">
<a class="login-link" href="/">
<img class="title-logo" src="img/logo.png">
</a>
<button class="login">
<a class="login-link" href="login.html">로그인</a>
</button>
</div>
</div>
</header>
<section class="blue-section">
<div class="container">
<div class="hero-section">
<div class="hero-content">
<h2 class="title">
일상의 모든 물건을<br>
거래해 보세요
</h2>
<button class="button-buy">
<a class="login-link" href="/items">구경하러 가기</a>
</button>
</div>
<img class="panda-pic" src="img/panda1.png" alt="fashionist_panda">
</div>
</div>
</section>
<section class="white-section">
<div class="container">
<div class="feature-section">
<img class="feature-image" src="img/hukuHeart.png" alt="panda_look_clothes">
<div class="contents">
<span class="section-heading">
Hot item
</span>
<h2 class="title">
인기 상품을<br>
확인해 보세요
</h2>
<p class="section-text">가장 HOT한 중고거래 물품을 판다 마켓에서 확인해 보세요</p>
</div>
</div>
</div>
</section>
<section class="white-section">
<div class="container">
<div class="feature-section">
<div class="contents">
<span class="section-heading">
Search
</span>
<h2 class="title">
구매를 원하는<br>
상품을 검색하세요
</h2>
<p class="section-text">구매하고 싶은 물품을 검색해서 쉽게 찾아보세요</p>
</div>
<img class="feature-image" src="img/zoom.png" alt="lens-pic">
</div>
</div>
</section>
<section class="white-section">
<div class="container">
<div class="feature-section">
<img class="feature-image" src="img/sq.png" alt="sellWishProduct">
<div class="contents">
<span class="section-heading">
Register
</span>
<h2 class="title">
판매를 원하는<br>
상품을 등록하세요
</h2>
<p class="section-text">어떤 물건이든 판매하고 싶은 상품을 쉽게 등록하세요</p>
</div>
</div>
</div>
</section>
<section class="blue-section">
<div class="container">
<div class="hero-section">
<div class="hero-content">
<h2 class="title">
믿을 수 있는<br>
판다마켓 중고 거래
</h2>
</div>
<img class="banner-image" src="img/pandaLa.png" alt="greeting_panda">
</div>
</div>
</section>
<footer>
<div class="foot-background">
<div class="footer-container">
<div class="codeit-2024">
@codeit-2024
</div>
<div class="footer-links">
<a class="link-line" href="/privacy">Privacy Policy</a>
<a class="link-line" href="/faq">FAQ</a>
</div>
<ul class="social-links">
<li>
<a href="https://www.facebook.com" target="_blank">
<img class="social-icon" src="img/Facebook.png" alt="Facebook">
</a>
</li>
<li>
<a href="https://www.twitter.com" target="_blank">
<img class="social-icon" src="img/twiter.png" alt="twitter">
</a>
</li>
<li>
<a href="https://www.youtube.com" target="_blank">
<img class="social-icon" src="img/youtube.png" alt="youtube">
</a>
</li>
<li>
<a href="https://www.instagram.com" target="_blank">
<img class="social-icon" src="img/instagram.png" alt="instagram">
</a>
</li>
</ul>
</div>
</div>
</footer>
</body>
47 changes: 47 additions & 0 deletions login.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="utf-8">
<title>로그인</title>
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.css">
<link rel="stylesheet" href="styleLogin.css">
</head>
<body>
<div class="content">
<div class="head-img">
<a class="login-link" href="/">
<img class="pandaMarketImg" src="img/logo.png">
</a>
</div>
<div>
<p>이메일</p>
<input type="email" name="userName" id="userName">
<p>비밀번호</p>
<input type="password" name="userPassword" id="userPassword">
</div>
<div class="content-login">
<a class="login-button" href="/login">로그인</a>
</div>
<div>
<div class="blue-section">
<p class="simpleLogin">간편 로그인하기</p>
<ul class="social-links">
<li>
<a href="https://www.google.com/" target="_blank">
<img class="social-icon" src="img/google.png" alt="google">
</a>
</li>
<li>
<a href="https://www.kakaocorp.com/page/" target="_blank">
<img class="social-icon" src="img/kakao.png" alt="kakao">
</a>
</li>
</ul>
</div>
</div>
<div class="foot-content">
<p class="insa">판다마켓은 처음이신가요?</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ 수정요청
변수나 클래스명, 이미지명과 같은 이름은 해당 파일이 어떤 역할을 하는 친구인지 나타내는 큰 단서가 되고 코드파악 및 유지보수에 중요한 역할을 합니다.
insa 라는 클래스명은 해당 태그를 잘 설명하지 못하니 변경해주시는 것을 추천드려요~
(insta라는 의미인지 인사라는 의미인지 의도가 궁금하네요~)

<a class="membership" href="signup.html">회원가입</a>
</div>
</div>
</body>
48 changes: 48 additions & 0 deletions reset.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/* http://meyerweb.com/eric/tools/css/reset/
v2.0 | 20110126
License: none (public domain)
*/

html, body, div, span, applet, object, iframe,
h1, h2, h3, h4, h5, h6, p, blockquote, pre,
a, abbr, acronym, address, big, cite, code,
del, dfn, em, img, ins, kbd, q, s, samp,
small, strike, strong, sub, sup, tt, var,
b, u, i, center,
dl, dt, dd, ol, ul, li,
fieldset, form, label, legend,
table, caption, tbody, tfoot, thead, tr, th, td,
article, aside, canvas, details, embed,
figure, figcaption, footer, header, hgroup,
menu, nav, output, ruby, section, summary,
time, mark, audio, video {
margin: 0;
padding: 0;
border: 0;
font-size: 100%;
font: inherit;
vertical-align: baseline;
}
/* HTML5 display-role reset for older browsers */
article, aside, details, figcaption, figure,
footer, header, hgroup, menu, nav, section {
display: block;
}
body {
line-height: 1;
}
ol, ul {
list-style: none;
}
blockquote, q {
quotes: none;
}
blockquote:before, blockquote:after,
q:before, q:after {
content: '';
content: none;
}
table {
border-collapse: collapse;
border-spacing: 0;
}
Loading
Loading