Skip to content

[하재호]sprint1 #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addiescode-sj merged 1 commit into from
May 7, 2025
Merged

[하재호]sprint1 #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added body1.PNG
View file
Open in desktop
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

투명 배경을 지원할 필요가 없으면 png보다는 jpg 파일 사용을 권장드립니다.

추천 드리자면:

  • 벡터 기반의 장점을 활용할수있거나, path 정보가 간단한 로고, 아이콘등의 파일: svg
  • 투명 배경을 지원할 필요가 있는 큰 이미지 파일: png
  • 투명 배경을 지원할 필요가 없는 큰 이미지 파일: 최소 2x의 고배율 jpg, jpeg => 고배율 이미지를 써야하므로 png, jpeg보다 압축률이 좋은 webp로 변환해 picture태그와 함께 사용 추천

컨텐츠의 특성 혹은 몇가지 조건에 따라 올바른 파일 포맷을 고르는것도 최적화에 포함됩니다.
제가 추천드린것말고도 여러가지 참고해보시고 적용해보세요 :)

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added body2.PNG
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added body3.PNG
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added bottom.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added facebook-logo.PNG
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Empty file added faq.html
View file
Open in desktop
Empty file.
126 changes: 126 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다마켓</title>
<link rel="icon" href="icon.png" />
<link rel="stylesheet" href="mission1.css" />
</head>

<body>

Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 공백은 제거해볼까요?

<header>

<a href="index.html"
><img
src="top-logo.png"
alt="판다마켓 홈"
width="153"
/>

<a href="login.html" id="loginLinkButton" class="button">로그인</a>
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린리더 사용자들을 위한 접근성 향상을 위해 aria-label을 사용해볼까요?

<a 
  href="/login" 
  class="login" 
  aria-label="로그인 페이지로 이동"
>
  로그인
</a>

접근성 개념에 대해 더 알고싶으시다면 아래 아티클 참고해보세요!

참고

</header>
<main>
<section id="hero" class="banner">
<div class="wrapper">
<h1>
일상의 모든 물건을<br />
거래해 보세요
</h1>
<a href="items.html" class="button pill-button">구경하러 가기</a>
</div>
</section>

<section id="bodt" class="wrapper">
<div class="body">

<img
src="body1.png"
alt="인기 상품"
width="50%"
/>
<div class="body-content">
<h2 class="body-tag">Hot item</h2>
<h1>인기 상품을<br />확인해 보세요</h1>
<p class="body-description">
가장 HOT한 중고거래 물품을<br />판다마켓에서 확인해 보세요
</p>
</div>
</div>
<div class="body">
<div class="body-content">
<h2 class="body-tag">Search</h2>
<h1>구매를 원하는<br />상품을 검색하세요</h1>
<p class="body-description">
구매하고 싶은 물품은 검색해서
<br />쉽게 찾아보세요
</p>
</div>
<img
src="body2.png"
alt="검색 기능"
width="50%"
/>
</div>
<div class="body">
<img
src="body3.png"
alt="판매 상품 등록"
width="50%"
/>
<div class="body-content">
<h2 class="body-tag">Register</h2>
<h1>판매를 원하는<br />상품을 등록하세요</h1>
<p class="body-description">
어떤 물건이든 판매하고 싶은 상품을
<br />쉽게 등록하세요
</p>
</div>
</div>
</section>

<section id="bottomBanner" class="banner">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

클래스이름을 지을때는 UI의 색상, 위치, 순서등이 포함되어있으면 디자인 변경 시 대응하기도 어려워지고 유지보수에 좋지 않아요. 이런 정보들을 포함하기보다는 항상 엘리먼트의 역할을 명확하게 나타낼수있는 네이밍을 써볼까요? :)

<div class="wrapper">
<h1>
믿을 수 있는
<br />
판다마켓 중고거래
</h1>
</div>
</section>
</main>

<footer>
<div>©codeit - 2024</div>
<div id="footerMenu">
<a href="privacy.html">Privacy Policy</a>
<a href="faq.html">FAQ</a>
</div>
<div id="socialMedia">

<a href="https://www.facebook.com/"
target="_blank"
rel="noopener noreferrer"
><img src="facebook-logo.png" alt="페이스북" width="20"
/></a>
<a href="https://twitter.com/" target="_blank" rel="noopener noreferrer"
><img src="twitter-logo.png" alt="트위터" width="20"
/></a>
<a href="https://www.youtube.com/"
target="_blank"
rel="noopener noreferrer"
><img src="youtube-logo.png" alt="유튜브" width="20"
/></a>
<a href="https://www.instagram.com/"
target="_blank"
rel="noopener noreferrer"
><img
src="instagram-logo.png"
alt="인스타그램"
width="20"
/></a>
</div>
</footer>
</body>
</html>
Binary file added instagram-logo.PNG
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Empty file added items.html
View file
Open in desktop
Empty file.
Empty file added login.html
View file
Open in desktop
Empty file.
159 changes: 159 additions & 0 deletions mission1.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,159 @@
* {
margin: 0;
padding: 0;
box-sizing: border-box;
}

a {
text-decoration: none;
color: inherit;
}

button {
background: none;
border: none;
outline: none;
box-shadow: none;
cursor: pointer;
}
Comment on lines +1 to +18
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

용도에 따라 CSS를 나눠서 관리해볼까요?

  • reset.css: CSS 초기화
  • common.css: 전역 스타일

이렇게 용도에 따라 파일을 나눠 관리하는건 어떤 이점을 가져다줄수있는지 한번 더 생각해볼수있어요.

  • 역할 분리가 되어 관리가 쉬움: 각 파일의 목적이 명확해서 수정이나 유지보수가 쉬워질거예요.
  • 사용성과 확장성 증가: 여러 페이지 혹은 프로젝트에서 거의 동일하게 재사용이 가능해요.
  • 스타일 우선순위가 더 예측 가능해짐: reset.css → common.css → 페이지나 컴포넌트별 스타일 순으로 로딩하면 우선순위가 명확해지고 스타일 충돌을 줄일 수 있어요.


img {
vertical-align: bottom;
}


body {
color: #374151;
word-break: keep-all;
font-family: "Pretendard", sans-serif;
}

header {
width: 100%;
height: 70px;
display: flex;
justify-content: space-between;
align-items: center;
padding: 0 200px;
background-color: #ffffff;
border-bottom: 1px solid #dfdfdf;
}

footer {
background-color: #111827;
color: #9ca3af;
display: flex;
justify-content: space-between;
align-items: center;
padding: 32px 200px 108px 200px;
font-size: 16px;
}

#footerMenu {
display: flex;
gap: 30px;
color: #e5e7eb;
}

#socialMedia {
display: flex;
gap: 12px;
}

.wrapper {
max-width: 1200px;
margin: 0 auto;
width: 100%;
}

h1 {
font-size: 40px;
font-weight: 700;
line-height: 56px;
letter-spacing: 0.02em;
}

.button {
background-color: #3692ff;
color: #ffffff;
display: inline-flex;
align-items: center;
justify-content: center;
}

.button:hover {
background-color: #1967d6;
}

.button:focus {
background-color: #1251aa;
}

.button:disabled {
background-color: #9ca3af;
cursor: default;
pointer-events: none;
}

.pill-button {
font-size: 20px;
font-weight: 700;
border-radius: 999px;
padding: 16px 124px;
}
.banner {
background-color: #cfe5ff;
height: 540px;
display: flex;
align-items: center;
background-repeat: no-repeat;
background-position: 80% bottom;
background-size: 55%;
}

#hero {
background-image: url("top.png");
}

#body {
padding-bottom: 138px;
}

#bottomBanner {
background-image: url("bottom.png");
}

#loginLinkButton {
font-size: 16px;
font-weight: 600;
border-radius: 8px;
padding: 11.5px 23px;
}

.banner .pill-button {
margin-top: 32px;
}

.body {
padding: 138px 0;
display: flex;
align-items: center;
gap: 5%;
}


.body-tag {
color: #3692ff;
font-size: 18px;
line-height: 25px;
font-weight: 700;
margin-bottom: 12px;
}

.body-description {
font-size: 24px;
font-weight: 500;
line-height: 120%;
letter-spacing: 0.08em;
margin-top: 24px;
}
Empty file added privacy.html
View file
Open in desktop
Empty file.
Binary file added top-logo.PNG
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added top.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added twitter-logo.PNG
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added youtube-logo.PNG
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading