Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added fonts/rokafsansmedium-normal.woff
Binary file not shown.
Binary file added image/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image/판다 얼굴.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
126 changes: 126 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<html lang="en">
<html lang="ko">

언어 설정을 "ko"로 변경하시면, 한국어 사용자에 맞춰 스크린리더가 사용될수있고 검색엔진에서도 페이지의 언어를 한국어 콘텐츠로 인식하게끔 만들어줄 수 있습니다. 웹 접근성을 생각했을때 스크린리더를 사용한다면 lang="en" 상태에서는 한국어 콘텐츠를 영어 발음으로 읽을 가능성이 있기때문에, 한국어 사용자를 대상으로한다면 "ko"로 변경하시는게 옳습니다 :)

<head>
<meta charset="UTF-8" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta 태그 사용이 조금 아쉽네요!
이런식으로 title, description, image등을 활용하시면 SEO에 도움이 되고, 소셜 미디어등에 공유 링크를 생성할때도 좀 더 나은 프리뷰를 제공해줄수있어요.

    <meta
      name="description"
      content="판다마켓 - 일상의 모든 물건을 거래하는 중고거래 플랫폼"
    />
    <meta property="og:title" content="판다마켓" />
    <meta
      property="og:description"
      content="일상의 모든 물건을 거래하는 중고거래 플랫폼"
    />
    <meta property="og:image" content="/image/판다 얼굴.png" />

<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="style.css" />
<title>판다마켓</title>
</head>
<body>
<header>
<nav>
<div class="container">
<a class="logo" href="/">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

접근성 향상을 위해 관련있는 속성들에 aria-label 이나 role 속성 추가를 해볼까요?
이 아티클 참고해보시면 좋을것같습니다!

<img src="/image/판다 얼굴.png" alt="image_logo" />
<span>판다마켓</span>
</a>
<a href="/login" class="btn">로그인</a>
</div>
</nav>
<div class="landing">
<div class="landing-content">
<div class="landing-title">
<h1 class="landing-text">
일상의 모든 물건을<br />
거래해 보세요
</h1>
<a href="/items" class="btn">구경하러 가기</a>
</div>
<img src="/image/Img_home_top.png" alt="image_landing" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

접근성 향상을 위해 alt 텍스트를 더 구체적으로 사용해주세요 :)
애플 공식 웹사이트를 참고해보시면 아래와 같이 정말 구체적으로 사용해주고있습니다!

<img src="/v/macbook-air/u/images/overview/design/color/design_top_skyblue__eepkvlvjzcia_large.jpg" onload="__lp(event)" alt="스카이 블루 색상 MacBook Air를 정면에서 바라본 모습과 위에서 내려다본 모습">

</div>
</div>
</header>
<main>
<section>
<div class="container">
<img src="/image/Img_home_01.png" alt="image_home_1" />
<div class="content">
<h1 class="header">Hot item</h1>
<h1 class="big">
인기 상품을<br />
확인해보세요
</h1>
<h1 class="small">
가장 HOT한 중고거래 물품을<br />
판다마켓에서 확인해보세요
</h1>
</div>
</div>
</section>
<section>
<div class="container">
<div class="content">
<h1 class="header">Search</h1>
<h1 class="big">
구매를 원하는<br />
상품을 검색하세요
</h1>
<h1 class="small">
구매하고 싶은 물품은 검색해서<br />
쉽게 찾아보세요
</h1>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모두 h1태그를 사용하셨네요! 올바른 heading 위계를 사용해주세요.

예시)

          <div class="content">
            <h2 class="header">Hot item</h2>
            <h3 class="big" id="hot-item-title">
              인기 상품을<br />
              확인해보세요
            </h3>
            <p class="small">
              가장 HOT한 중고거래 물품을<br />
              판다마켓에서 확인해보세요
            </p>

</div>
<img src="/image/Img_home_02.png" alt="image_home_2" />
</div>
</section>
<section>
<div class="container">
<img src="/image/Img_home_03.png" alt="image_home_3" />
<div class="content">
<h1 class="header">Register</h1>
<h1 class="big">
판매를 원하는<br />
상품을 등록하세요
</h1>
<h1 class="small">
어떤 물건이든 판매하고 싶은 상품을<br />
쉽게 등록하세요
</h1>
</div>
</div>
</section>
<div class="landing-bottom">
<div class="landing">
<div class="landing-content">
<div class="landing-title">
<h1 class="landing-text">
믿을 수 있는<br />
판다마켓 중고 거래
</h1>
</div>
<img src="/image/Img_home_bottom.png" alt="image_landing_bottom" />
</div>
</div>
</div>
</main>
<footer>
<div class="container">
<span class="logo">©codeit - 2024</span>
<div class="link">
<a href="/privacy">Privacy Policy</a>
<a href="/faq">FAQ</a>
</div>
<div class="icon">
<a href="https://www.facebook.com/?locale=ko_KR" target="blank">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보안을 위해 rel="noopener noreferrer" 를 추가해볼까요?

<img src="/image/ic_facebook.png" alt="icon_facebook" />
</a>
<a href="https://x.com/?lang=ko" target="blank">
<img src="/image/ic_twitter.png" alt="icon_twitter" />
</a>
<a href="https://www.youtube.com/" target="blank">
<img src="/image/ic_youtube.png" alt="icon_youtube" />
</a>
<a href="https://www.instagram.com/" target="blank">
<img src="/image/ic_instagram.png" alt="icon_instagram" />
</a>
</div>
</div>
</footer>
</body>
</html>
216 changes: 216 additions & 0 deletions style.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,216 @@
* {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 전역으로 처리해줘야하는 스타일 규칙들은 따로 용도를 명확히 구분한 파일을 만들어 관리해보면 어떨까요?

  • reset.css (스타일 초기화)
  • common.css (전역 스타일)

box-sizing: border-box;
}
@font-face {
font-family: 'ROKAFSansMedium';
src: url('./fonts/rokafsansmedium-normal.woff') format('woff');
font-weight: normal;
font-style: normal;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런건 디폴트라서 따로 명시해주지않으셔도됩니다.
CSS 초기값이 궁금하시다면 어떤 값이 초기값인지 찾아보시면서 코딩해보세요 :)

https://developer.mozilla.org/ko/docs/Web/CSS/font-weight

}
body {
margin: 0px;
font-family: pretendard;
white-space: nowrap;
}

.btn {
background-color: #3692ff;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자주 사용하는 값들은 이런식으로 변수 처리해주면 중복도 줄이고 재사용성도 올라가겠죠?

예시)

:root {
  /* Colors */
  --color-primary: #3692ff;
  --color-primary-dark: #1967d6;
  --color-text: #374151;
  --color-text-light: #9ca3af;
  --color-background: #ffffff;
  --color-background-alt: #fcfcfc;
  --color-background-landing: #cfe5ff;
  --color-background-footer: #111827;
  --color-text-light: #f3f4f6;
  --color-text-lighter: #f9fafb;

  /* Typography */
  --font-family-base: pretendard, sans-serif;
  --font-family-heading: "ROKAFSansMedium", sans-serif;

  /* Spacing */
  --spacing-xs: 8px;
  --spacing-sm: 12px;
  --spacing-md: 24px;
  --spacing-lg: 32px;
  --spacing-xl: 64px;
  --spacing-xxl: 138px;

  /* Layout */
  --container-max-width: 1520px;
  --container-content-width: 1120px;
  --container-section-width: 988px;

  /* Border Radius */
  --border-radius-sm: 8px;
  --border-radius-lg: 40px;
}

text-decoration: none;
display: flex;
align-items: center;
justify-content: center;
}

.btn:hover {
background-color: #1967d6;
}

nav {
height: 70px;
display: grid;
max-width: 1520px;
grid-template-columns: 200px minmax(0px, 1120px) 200px;
margin: 0px auto;
}

nav .container {
display: flex;
flex-direction: row;
grid-column: 2;
justify-content: space-between;
align-items: center;
}

nav .logo {
display: flex;
flex-direction: row;
align-items: center;
text-decoration: none;
gap: 8.6px;
font-family: 'ROKAFSansMedium';
font-weight: 700;
font-size: clamp(20px, 2vw, 25.63px);
color: #3692ff;
}

nav img {
width: 100%;
max-width: 40px;
min-width: 35px;
height: auto;
}

nav .btn {
max-width: 128px;
min-width: 60px;
width: 100%;
height: 48px;
border-radius: 8px;
color: #f3f4f6;
font-size: clamp(8px, 2vw, 16px);
font-weight: 600;
}

.landing .btn {
height: 56px;
font-size: clamp(10px, 2vw, 20px);
font-weight: 600;
color: #f9fafb;
border-radius: 40px;
margin-top: 32px;
}

.landing {
background-color: #cfe5ff;
}

.landing-bottom {
padding-top: 138px;
background-color: #fcfcfc;
}

.landing-content {
display: flex;
flex-direction: row;
justify-content: center;
align-items: center;
padding: 200px 200px 0px 200px;
gap: 7px;
}

.landing-title {
width: 100%;
max-width: 357px;
min-width: 148px;
height: auto;
margin-bottom: 60px;
}

.landing img {
width: 100%;
max-width: 746px;
min-width: 450px;
height: auto;
}

.landing-text {
color: #374151;
font-size: clamp(20px, 2vw, 40px);
font-weight: 700;
margin: 0px;
}

main {
background-color: #ffffff;
}

main section {
display: flex;
justify-content: center;
padding: 138px;
margin: 0px auto;
}

main section:nth-child(2n) {
text-align: right;
}

main .container {
width: 988px;
border-radius: 12px;
background-color: #fcfcfc;
display: flex;
justify-content: center;
gap: 64px;
}

main .content {
display: flex;
flex-direction: column;
justify-content: center;
}

main .content .header {
color: #3692ff;
font-size: clamp(9px, 2vw, 18px);
font-weight: 700px;
margin: 0 0 12px;
}

main .content .big {
color: #374151;
font-size: clamp(20px, 2vw, 40px);
font-weight: 700;
margin: 0 0 24px;
}

main .content .small {
color: #374151;
font-size: clamp(12px, 2vw, 24px);
font-weight: 500;
margin: 0;
}

main img {
width: 100%;
min-width: 300px;
max-width: 588px;
height: auto;
}

footer {
background-color: #111827;
height: 160px;
}

footer .container {
padding-top: 32.5px;
max-width: 1120px;
display: flex;
flex-direction: row;
justify-content: space-between;
margin: 0px auto;
font-size: clamp(8px, 2vw, 16px);
}

footer span {
color: #9ca3af;
font-weight: 400;
}

footer .link {
display: flex;
flex-direction: row;
justify-content: center;
gap: 30px;
}

footer .link a {
color: #e5e7eb;
text-decoration: none;
font-weight: 400;
}

footer .icon .img {
height: 18px;
}
Loading