[박준현] sprint2 #150
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,9 @@ | ||||||
| * { | ||||||
| margin: 0; | ||||||
| padding: 0; | ||||||
| box-sizing: border-box; | ||||||
| } | ||||||
| a ,a > button { | ||||||
|
Collaborator
There was a problem hiding this comment. 여기서도 이렇게!
Suggested change
|
||||||
| cursor: pointer; | ||||||
| } | ||||||
| /* aa */ | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| .login-container, | ||
| .signup-container { | ||
| width: 640px; | ||
| margin: 230px auto; | ||
| display: flex; | ||
| justify-items: center; | ||
| align-items: center; | ||
| flex-direction: column; | ||
| gap: 30px; | ||
| } | ||
|
|
||
| /* 로그인이미지 */ | ||
| .login-img-box, | ||
| .signup-img-box { | ||
| width: 400px; | ||
| height: 130px; | ||
| } | ||
| .login-img, | ||
| .signup-img { | ||
| width: 100%; | ||
| } | ||
|
|
||
| /* 이메일,비번 signup 닉네임 비밀번호 확인 */ | ||
| .login-email-box, | ||
| .login-password-box, | ||
| .signup-email-box, | ||
| .signup-password-box, | ||
| .signup-nickname-box, | ||
| .signup-ckpassword-box { | ||
| width: 100%; | ||
| justify-content: start; | ||
| } | ||
|
|
||
| .login-email-box h4, | ||
| .login-password-box h4, | ||
| .signup-email-box h4, | ||
| .signup-password-box h4, | ||
| .signup-nickname-box h4, | ||
| .signup-ckpassword-box h4 { | ||
| font-size: 18px; | ||
| margin-bottom: 10px; | ||
| font-weight: 500; | ||
| } | ||
|
|
||
| .login-email-input, | ||
| .login-password-input, | ||
| .signup-email-input, | ||
| .signup-password-input, | ||
| .signup-ckpassword-input, | ||
| .signup-nickname-input { | ||
| background-color: #F3F4F6; | ||
| border: none; | ||
| height: 55px; | ||
| width: 100%; | ||
| padding-left: 30px; | ||
| } | ||
|
|
||
| /* 비밀번호 눈알 */ | ||
|
|
||
| /* 로그인버튼 */ | ||
| .login-button-box, | ||
| .signup-button-box { | ||
| width: 100%; | ||
| } | ||
|
|
||
| .login-button, | ||
| .signup-button { | ||
| width: 100%; | ||
| height: 55px; | ||
| background-color: #3692FF; | ||
| border-radius: 40px; | ||
| color: white; | ||
| border: none; | ||
| } | ||
|
|
||
| /* 간편로그인 */ | ||
| .login-ezlogin-box, | ||
| .signup-ezlogin-box { | ||
| display: flex; | ||
| flex-direction: row; | ||
| width: 100%; | ||
| background-color: #E6F2FF; | ||
| height: 74px; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| padding: 30px; | ||
| } | ||
| .login-ezlogin-box h4, | ||
| .signup-ezlogin-box h4 { | ||
| font-weight: 400; | ||
| } | ||
| .logo { | ||
| width: 42px; | ||
| margin: 10px; | ||
| } | ||
| /* 판다마켓이 처음이신가요 */ | ||
| .login-footer, | ||
| .signup-footer { | ||
| margin-top: 20px; | ||
| } | ||
| .login-footer h5, | ||
| .signup-footer h5 { | ||
| font-weight: 500; | ||
| } | ||
| .login-footer a, | ||
| .signup-footer a { | ||
| color: #3692FF; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,54 @@ | ||
| <!DOCTYPE html> | ||
| <head> | ||
| <title>로그인페이지</title> | ||
| <meta charset="UTF-8"> | ||
| <link href="./css/common.css" rel="stylesheet" type="text/css" /> | ||
| <link href="./css/login-signup.css" rel="stylesheet" type="text/css" /> | ||
| </head> | ||
| <body> | ||
| <article> | ||
| <section> | ||
| <div class="login-container"> | ||
| <div class="login-img-box"> | ||
| <a href="/" aria-label="홈으로 이동"> | ||
|
Collaborator
There was a problem hiding this comment. 접근성을 위해 aria-label을 써주셨네요! 굳굳 👍 |
||
| <img class="login-img" src="./images/main-page/logo.png" alt="logo"> | ||
| </a> | ||
| </div> | ||
| <div class="login-email-box"> | ||
| <h4>이메일</h4> | ||
| <input type="email" placeholder="[email protected]" class="login-email-input" required> | ||
| </div> | ||
| <div class="login-password-box"> | ||
| <h4>비밀번호</h4> | ||
| <input type="password" class="login-password-input" required> | ||
| </div> | ||
| <div class="login-button-box"> | ||
| <button class="login-button"> | ||
| 로그인 | ||
| </button> | ||
| </div> | ||
| <div class="login-ezlogin-box"> | ||
| <div class="login-ezlogin"> | ||
| <h4>간편 로그인하기</h4> | ||
| </div> | ||
| <div class="login-ezlogin-logos"> | ||
| <a href="https://www.google.com" aria-label="구글로 이동" rel="noopener"> | ||
| <img class="logo" src="./images/main-page/google-logo.png" alt=""> | ||
|
Collaborator
There was a problem hiding this comment. 귀찮더라도 접근성을 위해 img에 alt 태그는 꼭 사용해주시는게 좋아요. <img src="/v/macbook-pro/aq/images/overview/themes/battery/battery_hero__d5zgrstiu9si_xlarge.jpg" onload="__lp(event)" alt="깜깜한 밤, 야외에서 삼각대에 장착한 카메라를 별이 가득한 하늘을 향해 놓은 채 카메라에 연결한 MacBook Pro를 무릎에 올려놓고 작업 중인 사람의 모습"> |
||
| </a> | ||
| <a href="https://www.kakaorp.com/page/" aria-label="카카오로 이동" rel="noopener"> | ||
| <img class="logo" src="./images/main-page/kakao-logo.png" alt=""> | ||
| </a> | ||
| </div> | ||
| </div> | ||
| <div class="login-footer"> | ||
| <h5> | ||
| 판다마켓이 처음이신가요? | ||
| <a href="signup.html">회원가입</a> | ||
| </h5> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| </article> | ||
| </body> | ||
|
|
||
| </html> | ||
|
Collaborator
There was a problem hiding this comment. sprint2에서부터 다음 미션 코드가 있네요! 미션별 요구사항마다 리뷰를 다르게 드려볼게요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <!DOCTYPE html> | ||
| <head> | ||
| <title>회원가입페이지</title> | ||
| <meta charset="UTF-8"> | ||
| <link href="./css/common.css" rel="stylesheet" type="text/css" /> | ||
| <link href="./css/login-signup.css" rel="stylesheet" type="text/css" /> | ||
| </head> | ||
| <body> | ||
| <article> | ||
| <section> | ||
| <div class="signup-container"> | ||
| <div class="signup-img-box"> | ||
| <a href="/" aria-label="홈으로 이동"> | ||
| <img class="signup-img" src="./images/main-page/logo.png" alt="logo"> | ||
| </a> | ||
| </div> | ||
| <div class="signup-email-box"> | ||
| <h4>이메일</h4> | ||
| <input type="email" placeholder="[email protected]" class="signup-email-input" required> | ||
| </div> | ||
| <div class="signup-nickname-box"> | ||
| <h4>닉네임</h4> | ||
| <input type="name" placeholder="판다" class="signup-nickname-input" required> | ||
| </div> | ||
| <div class="signup-password-box"> | ||
| <h4>비밀번호</h4> | ||
| <input type="password" class="signup-password-input" required> | ||
| </div> | ||
| <div class="signup-ckpassword-box"> | ||
| <h4>비밀번호 확인</h4> | ||
| <input type="password" class="signup-ckpassword-input" required> | ||
| </div> | ||
| <div class="signup-button-box"> | ||
| <button class="signup-button"> | ||
| 로그인 | ||
| </button> | ||
| </div> | ||
| <div class="signup-ezlogin-box"> | ||
| <div class="signup-ezlogin"> | ||
| <h4>간편 로그인하기</h4> | ||
| </div> | ||
| <div class="signup-ezlogin-logos"> | ||
| <a href="https://www.google.com" aria-label="구글로 이동" rel="noopener"> | ||
| <img class="logo" src="./images/main-page/google-logo.png" alt=""> | ||
| </a> | ||
| <a href="https://www.kakaorp.com/page/" aria-label="카카오로 이동" rel="noopener"> | ||
| <img class="logo" src="./images/main-page/kakao-logo.png" alt=""> | ||
| </a> | ||
| </div> | ||
| </div> | ||
| <div class="signup-footer"> | ||
| <h5> | ||
| 판다마켓이 처음이신가요? | ||
| <a href="login.html">로그인</a> | ||
| </h5> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| </article> | ||
| </body> | ||
|
|
||
| </html> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5,6 라인 사이에 공백 한칸 띄워줄까요?
지금은 좋은 포맷팅 습관을 들이기위해 수동으로 고쳐보시고,
나중에 포맷팅을 자동화하는 도구를 사용해보시면 좋을것같네요!
아래 아티클에서 규칙들 정도만 참고해보세요 :)
참고