Skip to content

[임재은] Sprint1 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addiescode-sj merged 6 commits into from
Apr 8, 2025
Merged

[임재은] Sprint1 #16

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab5d4eb
test.txt 추가
Apr 2, 2025
7b00ee6
스프린트미션1 - 임재은
Apr 3, 2025
d4c91c3
test2
Apr 4, 2025
b442559
test2
Apr 4, 2025
39b4c4c
PR완료인 상태에서 수정반영 테스트
Apr 4, 2025
897d6d2
리팩토링 완료
Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
Binary file added images/.DS_Store
View file
Open in desktop
Binary file not shown.
Binary file added images/bannerImg01.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/bannerImg02.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/bannerImg03.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/bottomBanner.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/facebook.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/instagram.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/kv.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/twitter.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/youtube.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
158 changes: 158 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,158 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

언어 설정을 "ko"로 변경하시면, 한국어 사용자에 맞춰 스크린리더가 사용될수있고 검색엔진에서도 페이지의 언어를 한국어 콘텐츠로 인식하게끔 만들어줄 수 있습니다. 웹 접근성을 생각했을때 스크린리더를 사용한다면 lang="en" 상태에서는 한국어 콘텐츠를 영어 발음으로 읽을 가능성이 있기때문에, 한국어 사용자를 대상으로한다면 "ko"로 변경하시는게 옳습니다 :)

Suggested change
<html lang="en">
<html lang="ko">

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다마켓</title>
<link
rel="stylesheet"
as="style"
crossorigin=""
href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="reset.css" />
<link rel="stylesheet" href="style.css" />
</head>
<body class="container">
<header>
<h1 class="logo">
<a href="./"
><img src="./images/logo.png" alt="판다마켓" aria-hidden="true" />
<span class="sr-only">판다마켓</span>
</a>
</h1>
<nav class="nav">
<p class="login_btn"><a href="./page/login.html">로그인</a></p>
</nav>
</header>
<main>
<div class="kv_section">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시맨틱 태그 사용을 늘려볼까요? main 아래 바로 섹션이면 div보다는 section을 사용하는게 좋을것같아요 :)

<div class="kv_inner">
<div class="kv_info">
<h2 class="title">일상의 모든 물건을 <br />거래해 보세요</h2>
<button class="btn">
<a href="./page/items.html">구경하러 가기</a>
</button>
</div>
</div>
</div>
<div class="banner_section">
<div class="banner_inner">
<div class="card first">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first와 같은 키워드를 사용하시는것보다는 엘리먼트의 역할에 따라 네이밍을 고려하시는게 좋아요.
지금은 과제라서 디자인이 변경될일은 없겠지만 변경된다면 이 이름을 다시 바꿔줘야겠죠? 이러한 네이밍이 늘어날수록 유지보수하기 애매해집니다 :)

<div class="img_wrap">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기에서는 언더바를 사용해주셨네요! 일관된 네이밍케이스를 지켜서 작성할수있도록 통일해줄까요?
아래 아티클 참고해보시면 좋을것같네요 :)

CSS 네이밍 컨벤션 참고
일반적인 네이밍 케이스

<img src="./images/bannerImg01.png" alt="인기 상품 소개 배너" />
</div>
<div class="card-info">
<div class="badge">Hot Item</div>
<h2 class="title">
인기 상품을<br />
확인해 보세요
</h2>
<p class="desc">
가장 HOT한 중고거래 물품을<br />
판다 마켓에서 확인해 보세요
</p>
</div>
</div>
<div class="card second">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기에서도 위 코멘트 참고해서 네이밍 변경해주세요! :)

<div class="img_wrap">
<img
src="./images/bannerImg02.png"
alt="상품검색 안내를 위한 이미지"
/>
</div>

<div class="card-info">
<div class="badge">Search</div>
<h2 class="title">
구매를 원하는<br />
상품을 검색하세요
</h2>
<p class="desc">
구매하고 싶은 물품은 검색해서<br />
쉽게 찾아보세요
</p>
</div>
</div>
<div class="card third">
<div class="img_wrap">
<img
src="./images/bannerImg03.png"
alt="상품 판매등록에 대한 이미지"
/>
</div>

<div class="card-info">
<div class="badge">Register</div>
<h2 class="title">
판매를 원하는<br />
상품을 등록하세요
</h2>
<p class="desc">
어떤 물건이든 판매하고 싶은 상품을<br />
쉽게 등록하세요
</p>
</div>
</div>
</div>
</div>
<div class="bottomBannerSection">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서도 네이밍 변경해주세요!

<div class="title">
믿을 수 있는<br />
판다마켓 중고 거래
</div>
</div>
</main>
<footer class="footer">
<ul class="footer_inner">
<li class="footer-item">©codeit - 2024</li>
<li class="footer-item">
<a href="./page/privacy.html">Privacy Policy</a>
<a href="./page/faq.html">FAQ</a>
</li>
<li class="footer-item">
<span class="icon"
><a
href="https://www.facebook.com/?locale=ko_KR"
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

외부 링크의 경우, 보안을 위해 rel="noopener noreferrer"를 추가해주세요! :)

noopener: 새 탭에서 열린 페이지가 원본 페이지에 접근하는 것을 방지
noreferrer: 리퍼러 정보가 새 페이지로 전달되는 것을 방지

target="_blank"
aria-label="Facebook 페이지로 이동"
><img
src="./images/facebook.png"
alt="facebook"
aria-hidden="true" /></a
></span>
<span class="icon"
><a
href="https://x.com/?lang=ko"
target="_blank"
aria-label="Twitter 페이지로 이동"
><img
src="./images/twitter.png"
alt="twitter"
aria-hidden="true" /></a
></span>
<span class="icon"
><a
href="https://www.youtube.com/?hl=ko&gl=KR&app=desktop"
target="_blank"
aria-label="youtube 페이지로 이동"
><img
src="./images/youtube.png"
alt="youtube"
aria-hidden="true" /></a
></span>
<span class="icon"
><a
href="https://www.instagram.com/"
target="_blank"
aria-label="Instagram 페이지로 이동"
><img
src="./images/instagram.png"
alt="instagram"
aria-hidden="true" /></a
></span>
</li>
</ul>
</footer>
</body>
</html>
11 changes: 11 additions & 0 deletions page/faq.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
faq
</body>
</html>
11 changes: 11 additions & 0 deletions page/instagram.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
instagram
</body>
</html>
11 changes: 11 additions & 0 deletions page/items.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>items</title>
</head>
<body>
items
</body>
</html>
11 changes: 11 additions & 0 deletions page/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
login
</body>
</html>
11 changes: 11 additions & 0 deletions page/privacy.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
privacy
</body>
</html>
11 changes: 11 additions & 0 deletions page/twitter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
twitter
</body>
</html>
11 changes: 11 additions & 0 deletions page/youtube.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
youtube
</body>
</html>
72 changes: 72 additions & 0 deletions reset.css
View file
Open in desktop
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 👍 좋은 시도입니다

Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
/* reset.css */

/* 박스 사이징 설정 */
*,
*::before,
*::after {
box-sizing: border-box;
margin: 0;
padding: 0;
}

/* 기본 글꼴 상속 */
html {
font-family: sans-serif;
line-height: 1.15;
-webkit-text-size-adjust: 100%;
font-size: 16px;
}

/* 블록 요소 기본값 초기화 */
body {
margin: 0;
}

/* 리스트 스타일 제거 */
ul,
ol {
list-style: none;
}

/* 링크 스타일 초기화 */
a {
text-decoration: none;
color: inherit;
}

/* 버튼 초기화 */
button,
input,
textarea,
select {
font: inherit;
border: none;
background: none;
outline: none;
cursor: pointer;
}

/* 이미지 초기화 */
img {
max-width: 100%;
height: auto;
display: block;
}

/* 테이블 스타일 초기화 */
table {
border-collapse: collapse;
border-spacing: 0;
}

/* 기본 헤딩 및 텍스트 스타일 초기화 */
h1,
h2,
h3,
h4,
h5,
h6,
p {
margin: 0;
font-weight: normal;
}
Loading