React 염휘건 sprint6 #187
Merged
React 염휘건 sprint6 #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addiescode-sj
approved these changes
Jun 2, 2025
Collaborator
addiescode-sj
left a comment
addiescode-sj
left a comment
There was a problem hiding this comment.
수고하셨습니다!
주요 리뷰 포인트
- 복잡도 감소를 위한 컴포넌트 분리
- 예외 케이스 처리하기
| // todo: /additem 으로 이동 | ||
| // /additem 으로 이동 | ||
| navigate('/additem'); | ||
| console.log('상품 추가 버튼 클릭'); |
Collaborator
There was a problem hiding this comment.
불필요한 로그는 PR 올리실때 지워봅시다! :)
Collaborator
There was a problem hiding this comment.
BEM 방식으로 잘 nesting 되어있네요. 굳굳 👍
Comment on lines
+55
to
+56
| }; | ||
| const removeTag = (t: string) => |
Collaborator
There was a problem hiding this comment.
55, 56 사이 공백 한칸 띄워줄까요? 함수와 함수 사이엔 공백 한칸씩 꼭 띄우도록합시다 :)
| const value = tagInput.trim(); | ||
| if (!value || tags.includes(value)) return; | ||
|
|
||
| setTags((prev) => [...prev, value]); |
Collaborator
There was a problem hiding this comment.
spread 연산자를 사용해 배열을 복사 후 새 아이템을 추가하는군요!
Array또한 레퍼런스 타입이라 array.push로 직접적으로 변경하지않고 지금과 같이 원본 배열을 변경하지않는 방식이 좋습니다 :)
이 과정에서 배열을 다룰때 발생할 수 있는 예외 케이스 (예를 들어, 중복값을 허용할것인지 등) 를 꼼꼼하게 더 처리해볼까요?
Comment on lines
+59
to
+61
| const handleSubmit = () => { | ||
| console.log({ images, name, description, price: Number(price), tags }); | ||
| }; |
Collaborator
There was a problem hiding this comment.
해당 함수는 실제 제출을 담당하지는 않고 로그만 찍는 용도인가요? :)
Comment on lines
+110
to
+115
| <input | ||
| className={style['product-add-page__input']} | ||
| placeholder="상품명을 입력해주세요" | ||
| value={name} | ||
| onChange={(e) => setName(e.target.value)} | ||
| /> |
Collaborator
There was a problem hiding this comment.
ProductAddPage의 복잡도를 감소시키기위해,
폼 컨트롤 + 업데이트 로직을 다른 컴포넌트 단위로 분리해보는건 어떨까요?
Form, FormInput 두개의 컴포넌트를 사용해 리팩토링해봐요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
상품 이미지는 최대 한개 업로드가 가능합니다.
-[x]이미지를 제외하고 input 에 모든 값을 입력하면 ‘등록' 버튼이 활성화 됩니다.
심화
주요 변경사항
스크린샷