[이태경] refactor/sprint5 #200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 인풋값 개별로 상태관리 할 수 있게 수정 - 인풋값 개별로 상태관리로 변경하면서 검증하는 handleFocusOut 함수 수정 - 불필요한 최적화 삭제 - AuthFOrmInput, Input, PasswordInput 컴포넌트 분리 - 리턴문 읽기 쉽게 수정
LeeTaegyung
commented
Jun 24, 2025
Comment on lines
+14
to
+21
| useEffect(() => { | ||
| updatePageSize(); | ||
| window.addEventListener("resize", updatePageSize); | ||
|
|
||
| return () => { | ||
| window.removeEventListener("resize", updatePageSize); | ||
| }; | ||
| }, [updatePageSize]); |
Collaborator
Author
There was a problem hiding this comment.
Q1.
아직 관심사 분리가 좀 잘 안되는거 같습니다.
피드백 주신대로 페이지네이션 로직을 커스텀훅으로 분리를 했는데, 분리를 하다보니 '그럼 resize 이벤트도 커스텀훅으로 분리를 해야하는건가?' 라는 고민이 들더라구요. usePagination 훅은 currentPage와 pageSize를 위해 만들었는데, resize 이벤트가 이 커스텀훅에 있는 것이 적합하지 않은것 같아서요. 강사님 의견이 궁금합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
중고마켓
중고마켓 반응형
심화
주요 변경사항
멘토에게