[나소연] sprint1 #24
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>판다마켓</title> | ||
| <link rel="stylesheet" as="style" crossorigin | ||
| href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css" /> | ||
| <link rel="stylesheet" href="style.css"> | ||
|
|
||
| <body> | ||
| <div class="container"> | ||
| <header> | ||
| <nav class="gnb"> | ||
| <a href="index.html"> | ||
| <img src="Icon/Panda-logo-md.png" class="panda-logo-md" alt="판다마켓 로고"> | ||
|
Comment on lines
+16
to
+17
Collaborator
There was a problem hiding this comment. 접근성 향상을 위해 https://joyhong-91.tistory.com/22 |
||
| </a> | ||
| <a href="login.html" class="login-button is-clickable button-deco">로그인</a> | ||
|
Collaborator
There was a problem hiding this comment.
|
||
| </nav> | ||
| <section class="banner"> | ||
| <div class="banner-wrapper"> | ||
| <div class="intro-text"> | ||
| <h2> | ||
| 일상의 모든 물건을 <br> 거래해 보세요 | ||
| </h2> | ||
| <a href="items.html" class="search is-clickable button-deco">구경하러 가기</a> | ||
| </div> | ||
| <img src="Image/Img_home_top.png" alt="판다마켓 Top" class="banner-image-top"> | ||
| </div> | ||
| </section> | ||
| </header> | ||
| <main class="contents"> | ||
|
Collaborator
There was a problem hiding this comment. contents보다는 feature-section으로 변경하시고, 아래 카드 영역과 콘텐트영역 클래스이름도 feature-card, feature-content 등등으로 변경하시면 좀더 클래스명이 직관적으로 보일거예요. 너무 일반적이거나 모호한 클래스명은 가독성, 유지보수성, 확장성이 모두 떨어질 수 있습니다. 그 이유는 너무 일반적인 클래스명은 프로젝트내에서 반복적으로 사용될 가능성이 있고, 나중에 다른 개발자가 동일한 클래스명으로 스타일을 또 만들면 스타일이 충돌되거나 꼬이는 문제가 생길 수도 있기 때문입니다. 모호한 클래스명의 경우에도 유지보수를 어렵게한다는 단점이 생깁니다. 이런 문제를 최대한 방지하기위해서는 거듭 강조하지만 |
||
| <section class="content"> | ||
| <img src="Image/Img_home_01.png" alt="Hot item" class="content-img"> | ||
| <div class="content-text"> | ||
| <h4>Hot item</h4> | ||
| <h2>인기 상품을<br>확인해 보세요</h2> | ||
| <h3>가장 HOT한 중고거래 물품을<br>판다 마켓에서 확인해 보세요</h3> | ||
| </div> | ||
| </section> | ||
| <section class="content"> | ||
| <div class="content-text content-right"> | ||
|
Collaborator
There was a problem hiding this comment.
|
||
| <h4>Search</h4> | ||
| <h2>구매를 원하는<br>상품을 검색하세요</h2> | ||
| <h3>구매하고 싶은 물품은 검색해서<br>쉽게 찾아보세요</h3> | ||
| </div> | ||
| <img src="Image/Img_home_02.png" alt="search" class="content-img"> | ||
| </section> | ||
| <section class="content"> | ||
| <img src="Image/Img_home_03.png" alt="register" class="content-img"> | ||
| <div class="content-text"> | ||
| <h4>Register</h4> | ||
| <h2>판매를 원하는<br>상품을 등록하세요</h2> | ||
| <h3>어떤 물건이든 판매하고 싶은 상품을<br>쉽게 등록하세요</h3> | ||
| </div> | ||
| </section> | ||
| </main> | ||
| <footer> | ||
| <section class="banner"> | ||
| <div class="banner-wrapper"> | ||
|
Comment on lines
+60
to
+61
Collaborator
There was a problem hiding this comment. 다른 부분에서도 봤는데 banner와 banner-wrapper가 필요한 중첩인지 생각해봅시다! |
||
| <h2> | ||
| 믿을 수 있는<br>판다마켓 중고 거래 | ||
| </h2> | ||
| <img src="Image/Img_home_bottom.png" alt="판다마켓 Bottom" class="banner-image-bottom"> | ||
| </div> | ||
| </section> | ||
| <section class="footer-bottom"> | ||
| <div class="footer-bottom-contents"> | ||
| <div class="copyright"> | ||
| <p>©codeit - 2024</p> | ||
| </div> | ||
| <ul class="footer-list"> | ||
| <li><a href="privacy.html">Privacy Policy</a></li> | ||
| <li><a href="faq.html">FAQ</a></li> | ||
| </ul> | ||
| <ul class="footer-list"> | ||
| <li><a href="https://www.facebook.com" target="_blank"><img src="Icon/ic_facebook.png" | ||
|
Collaborator
There was a problem hiding this comment. 외부 링크의 경우, 보안을 위해 rel="noopener noreferrer"를 추가해주세요! :) noopener: 새 탭에서 열린 페이지가 원본 페이지에 접근하는 것을 방지 |
||
| alt="페이스북" class="social-logo"></a></li> | ||
| <li><a href="https://x.com" target="_blank"><img src="Icon/ic_twitter.png" alt="트위터" | ||
| class="social-logo"></a></li> | ||
| <li><a href="https://www.youtube.com" target="_blank"><img src="Icon/ic_youtube.png" alt="유튜브" | ||
| class="social-logo"></a> | ||
| </li> | ||
| <li><a href="https://www.instagram.com" target="_blank"><img src="Icon/ic_instagram.png" | ||
| alt="인스타그램" class="social-logo"></a></li> | ||
|
|
||
| </ul> | ||
| </div> | ||
| </section> | ||
| </footer> | ||
| </div> | ||
| </body> | ||
|
|
||
| </html> | ||
Empty file.
Empty file.
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,197 @@ | ||
| body { | ||
|
Collaborator
There was a problem hiding this comment. 용도를 나눠 css 파일을 관리해볼까요?
|
||
| font-family: 'Pretendard', sans-serif; | ||
| margin: 10px 0 0; | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
Comment on lines
+5
to
+7
Collaborator
There was a problem hiding this comment. 공백은 한칸만 띄워주셔도 충분해요! 포맷팅도 일관적으로 지켜써볼수있도록 신경써봅시다 :) |
||
| /* Layout */ | ||
| .container { | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .gnb { | ||
| display: flex; | ||
| flex-direction: row; | ||
|
Collaborator
There was a problem hiding this comment. flex 속성을 사용하면 기본적으로 |
||
| justify-content: space-between; | ||
| align-items: center; | ||
| max-width: 1120px; | ||
| padding: 0 200px; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .banner { | ||
| display: flex; | ||
| flex-direction: row; | ||
| padding: clamp(66px, 13vw, 200px) 0 0; | ||
|
|
||
| width: 100%; | ||
| background-color: #cfe5ff; | ||
|
Collaborator
There was a problem hiding this comment. 자주 사용되는 값들은 css 변수로 처리해서 재사용해주면 코드 중복을 줄일수있어요 :) 예시) /* Variables */
:root {
--primary-color: #3692ff;
--text-primary: #374151;
--text-secondary: #9ca3af;
--text-light: #e5e7eb;
--background-primary: #fcfcfc;
--background-secondary: #cfe5ff;
--background-dark: #111827;
--border-radius-sm: 8px;
--border-radius-lg: 12px;
--border-radius-xl: 40px;
--container-width: 1120px;
--content-width: 988px;
} |
||
| } | ||
|
|
||
| .banner-wrapper { | ||
| display: flex; | ||
| flex-direction: row; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .intro-text { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .contents { | ||
| width: clamp(370px, 77vw, 1120px); | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .content { | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-around; | ||
| width: clamp(320px, 68vw, 988px); | ||
| height: clamp(148px, 30vw, 444px); | ||
| margin: clamp(46px, 9.5vw, 138px) auto; | ||
| border-radius: 12px; | ||
| background-color: #fcfcfc; | ||
| } | ||
|
|
||
| .content-right { | ||
| text-align: right; | ||
| } | ||
|
|
||
| .content-text { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| padding-right: clamp(3px, 0.6vw, 10px); | ||
| padding-left: clamp(6px, 1.3vw, 20px); | ||
| } | ||
|
|
||
| .bottom-line { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .footer-bottom { | ||
| background-color: #111827; | ||
|
|
||
|
|
||
| } | ||
|
|
||
| .footer-bottom-contents { | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| max-width: 1120px; | ||
| margin: 0 auto; | ||
| padding: clamp(3px, 0.6vw, 10px) clamp(6px, 1.3vw, 20px) clamp(10px, 2.2vw, 32px); | ||
| } | ||
|
|
||
| .footer-list { | ||
| display: flex; | ||
| flex-direction: row; | ||
| list-style: none; | ||
| gap: 12px; | ||
|
|
||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
| /* Typo */ | ||
|
|
||
| h2 { | ||
| font-weight: 700; | ||
| font-size: clamp(13px, 2.7vw, 40px); | ||
| line-height: 140%; | ||
| color: #374151; | ||
| } | ||
|
|
||
| h3 { | ||
| font-weight: 500; | ||
| font-size: clamp(8px, 1.6vw, 24px); | ||
| line-height: clamp(10px, 2.2vw, 32px); | ||
| color: #374151; | ||
| } | ||
|
|
||
| h4 { | ||
| font-weight: 700; | ||
| font-size: clamp(6px, 1.2vw, 18px); | ||
| line-height: clamp(8px, 1.8vw, 26px); | ||
| color: #3692ff; | ||
| } | ||
|
|
||
| .footer-list a { | ||
| color: #e5e7eb; | ||
| text-decoration: none; | ||
| font-weight: 400; | ||
| font-size: clamp(5px, 1.1vw, 16px); | ||
| line-height: 100%; | ||
| } | ||
|
|
||
| .copyright { | ||
| font-weight: 400; | ||
| font-size: clamp(5px, 1.1vw, 16px); | ||
| line-height: 100%; | ||
| color: #9ca3af; | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
| /* Component */ | ||
|
|
||
| .panda-logo-md { | ||
| width: clamp(51px, 10vw, 153px); | ||
| height: auto; | ||
| } | ||
|
|
||
| .button-deco { | ||
| background-color: #3692ff; | ||
| color: #f3f4f6; | ||
| text-decoration: none; | ||
| font-size: clamp(5px, 1.1vw, 16px); | ||
| font-weight: 600; | ||
| } | ||
|
|
||
| .login-button { | ||
|
|
||
| padding: clamp(4px, 0.8vw, 12px) clamp(7px, 1.5vw, 23px); | ||
| border-radius: 8px; | ||
| } | ||
|
|
||
| .search { | ||
| padding: clamp(5px, 1.2vw, 16px) clamp(41px, 8.6vw, 124px); | ||
| border-radius: 40px; | ||
| font-size: clamp(6px, 1.3vw, 20px); | ||
| font-weight: 600; | ||
| line-height: clamp(11px, 2.2vw, 32px); | ||
| } | ||
|
|
||
| .banner-image-top { | ||
| width: clamp(248px, 51vw, 746px); | ||
| height: auto; | ||
| } | ||
|
|
||
| .banner-image-bottom { | ||
| width: clamp(248px, 51vw, 746px); | ||
| height: auto; | ||
| } | ||
|
|
||
| .content-img { | ||
| width: clamp(193px, 40vw, 579px); | ||
| height: 100%; | ||
| } | ||
|
|
||
| .social-logo { | ||
| width: clamp(6px, 1.3vw, 20px); | ||
| height: auto; | ||
| } | ||
|
|
||
| .is-clickable { | ||
| cursor: pointer; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
언어 설정을 "ko"로 변경하시면, 한국어 사용자에 맞춰 스크린리더가 사용될수있고 검색엔진에서도 페이지의 언어를 한국어 콘텐츠로 인식하게끔 만들어줄 수 있습니다. 웹 접근성을 생각했을때 스크린리더를 사용한다면 lang="en" 상태에서는 한국어 콘텐츠를 영어 발음으로 읽을 가능성이 있기때문에, 한국어 사용자를 대상으로한다면 "ko"로 변경하시는게 옳습니다 :)