Skip to content

[최재호] sprint1 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addiescode-sj merged 2 commits into from
Apr 10, 2025
Merged

[최재호] sprint1 #39

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50051c4
Basic-최재호-sprint1
Alex-Choi0 Apr 5, 2025
706fedd
Basic-최재호-sprint1
Alex-Choi0 Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions faq.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>items</title>
</head>
<body>
<h1>빈 페이지</h1>
</body>
</html>
Binary file added icon_facebook.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added icon_instagram.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added icon_twiter.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added icon_youtube.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image2.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image3.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image4.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image5.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
149 changes: 149 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
<!DOCTYPE html>
<html lang="kr">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 조금 헷갈리죠 ㅎㅎ kr이 아니라 ko로 변경해주셔야 올바른 문법입니다!

Suggested change
<html lang="kr">
<html lang="ko">

Copy link
Collaborator Author

@Alex-Choi0 Alex-Choi0 Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 기억하도록 하겠습니다. 감사합니다.

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="./style.css" />
<title>판다마켓</title>
</head>
<body>
<header>
<nav>
<div class="top-header">
<div class="logo">
<a href="index.html"
><img
class="logo-img"
src="./logo.png"
alt="판다마켓 로고"
/></a>
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

접근성 향상을 위해 aria-label="홈으로 이동" 과 같이 관련있는 요소에 aria-label 혹은 role을 사용해볼까요?
아래 아티클 참고해보시고 접근성을 향상시키기 위해 어떤 노력을 할수있는지 더 찾아보시면 좋은 공부 될 것같아요 :)

https://joyhong-91.tistory.com/22
https://velog.io/@a_in/WAI-ARIA-role-aria-label

</div>
<div class="login">
<a href="./login.html" class="login-button button">로그인</a>
</div>
</div>
</nav>
</header>

<main>
<section class="section1">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아까 얘기한것과 동일한 이유로, section의 순서가 바뀌면 네이밍도 다 변경해야겠죠? 요것도 변경해주세요 :)

<div class="section1-div">
<div class="part1">
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도!
개선해야하는 이유와 배경을 이해하셨다면 다른 부분은 코멘트 안드려도 아시겠죠? :)

<div class="text">
<h2>일상의 모든 물건을</h2>
<h2>거래해보세요</h2>
</div>
<div class="section1-button">
<a href="./items.html" class="look-button button"
>구경하러 가기</a
>
</div>
</div>
<div class="part2">
<div class="part2-img">
<img
class="section1-img"
src="./image1.png"
alt="메인이미지"
/>
</div>
</div>
</div>
</section>
<section class="section2">
<div class="section2-div">
<div class="part1">
<div class="sub-image">
<img
class="subImage"
src="./image2.png"
alt="구매를 원하시는 상품을 검색하세요"
/>
</div>
<div class="sub-title left">
<p class="subTitle1">Hot Item</p>
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여러가지 네이밍케이스가 혼재되어있네요 :)
항상 일관적인 네이밍케이스와 네이밍컨벤션을 고려해주시는게 좋습니다.

아티클 추천해드릴게요!

CSS 네이밍 컨벤션
자주 쓰는 네이밍케이스 정리

두개 참고해보시고, 일관적인 네이밍 규칙을 적용해보시면 좋을 것 같습니다!

<p class="subTitle2">
구매를 원하는<br />상품을 검색하세요 확인해 보세요
</p>
<p class="subTitle3">
구매하고 싶은 물품은 검색해서<br />쉽게 찾아보세요
</p>
</div>
</div>
<div class="part2">
<div class="sub-image">
<img
class="subImage"
src="./image3.png"
alt="인기상품 그림"
/>
</div>
<div class="sub-title right">
<p class="subTitle1 right">Search</p>
<p class="subTitle2 right">
인기 상품을 <br />
확인해 보세요
</p>
<p class="subTitle3 right">
가장 Hot한 중고고래물품을<br />판다 마켓에서 확인해 보세요
</p>
</div>
</div>
<div class="part3">
<div class="sub-image">
<img
class="subImage"
src="./image4.png"
alt="구매를 원하시는 상품을 검색하세요"
/>
</div>
<div class="sub-title left">
<p class="subTitle1">Register</p>
<p class="subTitle2">판매를 원하는<br />상품을 등록하세요</p>
<p class="subTitle3">
어떤 물건이든 판매하고 싶은 상품을쉽게 등록하세요
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어떤 물건이든 판매하고 싶은 상품을쉽게 등록하세요 => 중간에 띄어쓰기 하나 빠져있네요!

Copy link
Collaborator Author

@Alex-Choi0 Alex-Choi0 Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 감사합니다. 수정하도록 하겠습니다.

</p>
</div>
</div>
</div>
</section>
</main>

<footer>
<section class="section1">
<div class="section1-div">
<div class="part1">
<div class="text">
<h2>믿을 수 있는</h2>
<h2>판다마켓 중고 거래</h2>
</div>
</div>
<div class="part2">
<div class="part2-img">
<img
class="section1-img"
src="./image5.png"
alt="메인이미지"
/>
</div>
</div>
</div>
</section>
<section class="section2">
<div class="licence">
<p>©codeit - 2024</p>
</div>
<div class="btn">
<a href="./privacy.html" class="privacy">Privacy Policy</a>
<a href="./faq.html" class="FAQ">FAQ</a>
</div>
<div class="social-icon button">
<a href="https://www.facebook.com/?locale=ko_KR" target="_blank"><img src="./icon_facebook.png" alt="facebook link" />
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

외부 링크의 경우, 보안을 위해 rel="noopener noreferrer"를 추가해주세요! :)

noopener: 새 탭에서 열린 페이지가 원본 페이지에 접근하는 것을 방지
noreferrer: 리퍼러 정보가 새 페이지로 전달되는 것을 방지

Copy link
Collaborator Author

@Alex-Choi0 Alex-Choi0 Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앞으로 외부 링크인 경우에는 rel="noopener noreferrer"를 추가하도록 하겠습니다.

<a href="https://x.com/?lang=ko" target="_blank"><img src="./icon_twiter.png" alt="twiter link" /></a>
<a href="https://www.youtube.com/?hl=ko&gl=KR&app=desktop" target="_blank"><img src="./icon_youtube.png" alt="youtube link" /></a>
<a href="https://www.instagram.com/" target="_blank"><img src="./icon_instagram.png" alt="instagram link" /></a>
</div>
</section>
</footer>
</body>
</html>
11 changes: 11 additions & 0 deletions items.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>items</title>
</head>
<body>
<h1>빈 페이지</h1>
</body>
</html>
11 changes: 11 additions & 0 deletions login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Login</title>
</head>
<body>
<h1>빈 페이지</h1>
</body>
</html>
Binary file added logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions privacy.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>items</title>
</head>
<body>
<h1>빈 페이지</h1>
</body>
</html>
160 changes: 160 additions & 0 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
* {
margin: 0 0;
padding: 0 0;
box-sizing: border-box;
}
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

용도를 나눠 css 파일을 관리해볼까요?

  • reset.css (css 초기화)
  • common.css (전역 스타일 처리)


a.button {
text-decoration: none;
color: #ffffff;
background-color: #3692ff;
padding: 10px 20px;
border-radius: 10px;
}

.button {
cursor: pointer;
}
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여러 곳에서 사용되는 공통된 스타일 규칙들을 추출해서 가장 기본이 되는 버튼 클래스를 만들고, modifier를 사용해 변형된 스타일을 추가하시는게 좀 더 확장성있게 개발하실수 있으면서도, 유지보수에 유리하고 코드 중복도 줄일 수 있을거예요.

아래 방식으로 리팩토링 해보시는걸 추천드려봅니다!

.btn {
  cursor: pointer;
  display: inline-block;
  text-decoration: none;
  text-align: center;
  border: none;
  background-color: #3692ff;
  color: #ffffff;
  padding: 10px 20px;
  border-radius: 10px;
  font-size: 16px;
  transition: background-color 0.2s ease;
}

.btn--rounded {
  border-radius: 50px;
}

.btn--small {
  padding: 8px 16px;
  font-size: 14px;
}

.btn--large {
  padding: 12px 24px;
  font-size: 18px;
}

.btn:hover {
  background-color: #2b74cc; /* Darker shade for hover */
}

.btn:active {
  transform: translateY(1px);
}

.btn:focus {
  outline: 2px solid #3692ff;
  outline-offset: 2px;
}

.btn--primary {
  background-color: #3692ff;
  color: #ffffff;
}

.btn--secondary {
  background-color: transparent;
  color: #3692ff;
  border: 2px solid #3692ff;
}

.btn--secondary:hover {
  background-color: #3692ff;
  color: #ffffff;
}


/* 헤더부분 */

nav {
align-items: center;
}

.top-header {
display: flex;
flex-direction: row;
justify-content: space-between;
align-items: center;
max-width: 1520px;
padding: 0 200px;
margin: 0 auto;
width: 100%;
}

.logo-img {
height: 50px;
width: auto;
}

.section1 {
background-color: #cfe5ff;
Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자주 쓰이는 값들은 css 변수로 관리해서 재사용해볼까요?
이렇게 해주면 마찬가지로 코드 중복을 줄이면서도 유지보수에 유리한 방향으로 코드를 개선할 수 있어요 :)

예시)

/* Variables */
:root {
    --primary-color: #3692ff;
    --text-primary: #374151;
    --text-secondary: #9ca3af;
    --text-light: #e5e7eb;
    --background-primary: #fcfcfc;
    --background-secondary: #cfe5ff;
    --background-dark: #111827;
    --border-radius-sm: 8px;
    --border-radius-lg: 12px;
    --border-radius-xl: 40px;
    --container-width: 1120px;
    --content-width: 988px;
}

height: 400px;
/* display: flex; */
/* flex-direction: column; */
}

.section1-img {
height: 250px;
width: auto;

Copy link
Collaborator

@addiescode-sj addiescode-sj Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음 미션부터는 포맷팅도 신경써봐요 :)
불필요한 공백은 없애볼까요?

Copy link
Collaborator Author

@Alex-Choi0 Alex-Choi0 Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 알겠습니다. 포멧팅도 신경쓰도록 하겠습니다.

position: relative;

top: 75px;
}

.section1-div {
display: flex;
gap: 10px;
align-items: center;
justify-content: center;
height: 400px;
width: auto;

position: relative;
}

.part2-img {
position: relative;
bottom: 0;
}

.section1-div .part1 {
display: flex;
flex-direction: column;
gap: 25px;
}

.section1-button {
width: 100%;
}

.look-button {
border-radius: 50px;
}

.section2-div .part1,
.section2-div .part3 {
display: flex;
flex-direction: row;
align-items: center;
justify-content: center;
gap: 50px;
margin-top: 50px;
}

.subImage {
height: 300px;
width: auto;
}

.sub-title {
width: 250px;
}

.subTitle1 {
font-size: 12px;
font-weight: 1000;
color: #3692ff;
margin-bottom: 20px;
}

.subTitle2 {
font-size: 25px;
font-weight: 1000;
margin-bottom: 20px;
}

.section2-div .part2 {
display: flex;
flex-direction: row-reverse;
align-items: center;
justify-content: center;
gap: 50px;
margin-top: 50px;
}

.right {
text-align: right;
}

footer .section2 {
background-color: #000000;

display: flex;
justify-content: space-around;
height: 200px;

padding-top: 50px;
}

.licence {
color: #ffffff;
}

.privacy,
.FAQ {
margin: 0;
padding: 0;
background-color: #000000;
margin-left: 20px;
color: #ffffff;
text-decoration: none;
}

.social-icon img {
height: 20px;
width: auto;
margin-left: 10px;
}