Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added img/.DS_Store
Binary file not shown.
Binary file added img/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Property [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/btn_large.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/btn_small_48.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
125 changes: 125 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="style.css" />
<title>판다마켓</title>
</head>
<body>
<header>
<div class="market">
<a class="market-icon" href="/"
><img src="img/Property [email protected]" alt=""
/></a>
<a class="market-login" href="/login"
><img src="img/btn_small_48.png" alt=""
/></a>
</div>
</header>
<main>
<div class="link">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서도 시맨틱 태그를 사용한다면 <main>바로 아래 섹션이니 <section>을 사용하는게 더 적합하겠죠?
아래 두개 문서 참고해서 학습해보시면 좋겠네요 :)

mdn
w3schools

<div class="link-img">
<div class="link-img-text">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 css 클래스 네이밍이 일관적이지 않게 쓰인 느낌이 드네요 :)
여러가지 방식이 있을 수 있겠지만, 네이밍 컨벤션중에 가장 일반적으로 사용되는 BEM도 참고해보시면 좋을것같아요!

<span
>일상의 모든 물건을<br />
거래해 보세요</span
><a href="/items"><img src="img/btn_large.png" alt="btn" /></a>
</div>

<img class="link-img-panda" src="img/Img_home_top.png" alt="" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귀찮더라도 img태그에는 꼭 alt를 사용해주세요! :)
웹 접근성뿐만 아니라, 이미지 로딩 실패 시 대체 텍스트를 표시하거나 검색엔진최적화에도 도움을 줄 수 있기 때문에 꼭 사용해주시는게 좋습니다.

레퍼런스로 애플 공식 웹사이트에 가서 alt텍스트를 어떻게 사용했는지 참고해보시면:

<img src="/kr/macbook-air/images/overview/design/design_hero_static__e56c1v71mr6u_large.jpg" onload="__lp(event)" alt="열려있는 MacBook Air 13 및 15의 모습. 한 대에는 디자인 작업을 진행 중인 화면이, 다른 한 대에는 이메일과 스프레드시트를 넘나들며 멀티태스킹을 하는 화면이 표시되어 있습니다">

이런식으로 alt 속성에 이미지 설명을 위해 구체적이고 명확한 설명을 제공하는 모습을 확인해보실 수 있습니다 :)

</div>
</div>
<div class="content">
<div class="content-main">
<div class="content-box">
Comment on lines +39 to +41
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

만약 BEM을 적용한다면,
content => main-content
content-main => main-content__item
content-box => main-content__body

이정도가 될 수 있겠네요! 어떤가요?

<img src="img/Img_home_01.png" alt="1" />
<div class="content-text">
<div class="content-text-item">Hot item</div>
<div class="content-text-main">
인기 상품을<br />확인해 보세요
</div>
<div class="content-text-info">
가장 HOT한 중고거래 물품을<br />
판다 마켓에서 확인해 보세요
</div>
</div>
</div>
</div>
<div class="content-main">
<div class="content-box">
<div class="content-text reverse">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 div 중첩을 피하고 reverse 클래스를 추가하는 형식으로 잘 작업해주셨네요 👍

<div class="content-text-item">Search</div>
<div class="content-text-main">
구매를 원하는<br />
상품을 검색하세요
</div>
<div class="content-text-info">
구매하고 싶은 물품은 검색해서<br />
쉽게 찾아보세요
</div>
</div>
<img src="img/Img_home_02.png" alt="2" />
</div>
</div>
<div class="content-main">
<div class="content-box">
<img src="img/Img_home_03.png" alt="3" />
<div class="content-text">
<div class="content-text-item">Register</div>
<div class="content-text-main">
판매를 원하는<br />
상품을 등록하세요
</div>
<div class="content-text-info">
어떤 물건이든 판매하고 싶은 상품을<br />
쉽게 등록하세요
</div>
</div>
</div>
</div>
</div>
<div class="link">
<div class="link-img link-bottom">
<div class="link-img-text">
<span
>믿을 수 있는<br />
판다마켓 중고 거래</span
>
</div>

<img class="link-img-panda" src="img/Img_home_bottom.png" alt="" />
</div>
</div>
</main>
<div class="footer">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시맨틱 태그의 활용도를 높여보시면 좋을것 같아요! :)
<footer></footer>

<div class="footer-box">
<span class="footer-codeit">©codeit - 2024</span>
<div class="footer-faq">
<a href="/pricacy">Privacy Policy</a>
<a href="/faq">FAQ</a>
</div>
<div class="footer-sns">
<a href="https://www.facebook.com/"
><img src="img/ic_facebook.png" alt=""
/></a>
<a href="https://x.com/?lang=en"
><img src="img/ic_twitter.png" alt=""
/></a>
<a href="https://www.youtube.com/"
><img src="img/ic_youtube.png" alt=""
/></a>
<a href="https://www.instagram.com/"
><img src="img/ic_instagram.png" alt=""
/></a>
</div>
</div>
</div>
</body>
</html>
133 changes: 133 additions & 0 deletions reset.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,133 @@
html,
body,
div,
span,
applet,
object,
iframe,
h1,
h2,
h3,
h4,
h5,
h6,
p,
blockquote,
pre,
a,
abbr,
acronym,
address,
big,
cite,
code,
del,
dfn,
em,
img,
ins,
kbd,
q,
s,
samp,
small,
strike,
strong,
sub,
sup,
tt,
var,
b,
u,
i,
center,
dl,
dt,
dd,
ol,
ul,
li,
fieldset,
form,
label,
legend,
table,
caption,
tbody,
tfoot,
thead,
tr,
th,
td,
article,
aside,
canvas,
details,
embed,
figure,
figcaption,
footer,
header,
hgroup,
menu,
nav,
output,
ruby,
section,
summary,
time,
mark,
audio,
video {
margin: 0;
padding: 0;
border: 0;
font-size: 100%;
font: inherit;
vertical-align: baseline;
}
/* HTML5 display-role reset for older browsers */
article,
aside,
details,
figcaption,
figure,
footer,
header,
hgroup,
menu,
nav,
section {
display: block;
}
body {
line-height: 1;
}
ol,
ul {
list-style: none;
}
blockquote,
q {
quotes: none;
}
blockquote:before,
blockquote:after,
q:before,
q:after {
content: "";
content: none;
}
table {
border-collapse: collapse;
border-spacing: 0;
}

input:focus {
outline: none;
}

a {
color: inherit;
text-decoration: none;
}
Loading
Loading