-
Notifications
You must be signed in to change notification settings - Fork 39
[이상달] Sprint2 #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
addiescode-sj
merged 23 commits into
codeit-bootcamp-frontend:Basic-이상달
from
asksa1256:part1-이상달-sprint2
Apr 11, 2025
The head ref may contain hidden characters: "part1-\uC774\uC0C1\uB2EC-sprint2"
Merged
[이상달] Sprint2 #45
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
12d29bf
palette color값 css 변수 등록 및 적용
asksa1256 664cee4
target="_blank" 요소에 rel="noopener noreferrer" 추가
asksa1256 425a1de
로그인 페이지 퍼블리싱
asksa1256 3bbff94
메인 페이지 .btn 크기별 클래스명 분기
asksa1256 158ccc9
회원가입 페이지 퍼블리싱
asksa1256 40ec2a9
로그인 페이지 클래스명 수정 (.container > .form-container / .signup-link > .form-…
asksa1256 6ef1b41
로그인, 회원가입 상단 여백 통일
asksa1256 2fd5e7d
로그인, 회원가입 반응형
asksa1256 99438c3
input에 name, autocomplete, required 속성 추가
asksa1256 456f23a
메인 페이지 모호한 클래스명 수정
asksa1256 92945c1
로그인, 회원가입 접근성 코드 정리
asksa1256 4b9505d
로그인, 회원가입 폼 요소 클래스명 수정
asksa1256 4e10bc7
button에 폰트 적용
asksa1256 359c80a
메인 페이지 SEO, 소셜 공유 메타 태그 추가
asksa1256 6629f1d
파비콘 추가
asksa1256 d72f23c
input에 placeholder 속성 추가 및 폰트 적용
asksa1256 279d5c3
모바일 화면부터 미디어쿼리 재정의
asksa1256 0f047f3
refactor(mentor): img lazy-loading 적용
asksa1256 1556112
refactor(mentor): 로그인, 회원가입 button type="submit" 명시
asksa1256 9bd1328
refactor(mentor): 비밀번호 확인 input type="password"로 변경
asksa1256 8b5f5da
refactor(mentor): aria-label 속성 누락된 요소에 추가
asksa1256 d354cc3
fix: 폼 로고 img width, height 설정 (layout shift 방지)
asksa1256 b52be83
fix: 웹폰트 → 커스텀 폰트로 변경
asksa1256 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,131 +3,174 @@ | |
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <meta | ||
| name="description" | ||
| content="판다마켓으로 일상의 모든 것을 거래해보세요." | ||
| /> | ||
| <meta property="og:title" content="판다마켓" /> | ||
| <meta | ||
| property="og:description" | ||
| content="판다마켓으로 일상의 모든 것을 거래해보세요." | ||
| /> | ||
| <meta property="og:image" content="images/logo-396.png" /> | ||
| <meta name="twitter:card" content="images/logo-396.png" /> | ||
| <meta name="twitter:title" content="판다마켓" /> | ||
| <meta | ||
| name="twitter:description" | ||
| content="판다마켓으로 일상의 모든 것을 거래해보세요." | ||
| /> | ||
| <title>판다마켓</title> | ||
| <link | ||
| rel="stylesheet" | ||
| as="style" | ||
| crossorigin | ||
| href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css" | ||
| rel="icon" | ||
| type="image/png" | ||
| sizes="16x16" | ||
| href="images/favicon-16x16.png" | ||
| /> | ||
| <link rel="stylesheet" href="styles/style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <div class="inner"> | ||
| <a href="/" aria-label="판다마켓 홈으로 이동"> | ||
| <picture> | ||
| <source srcset="images/logo-153.png" media="(min-width: 480px)" /> | ||
| <img src="images/logo-100.png" alt="판다마켓 로고" /> | ||
| </picture> | ||
| <header class="header"> | ||
| <div class="header-container"> | ||
| <a href="/" class="logo" aria-label="판다마켓 홈으로 이동"> | ||
| <img loading="eager" src="images/logo-153.png" alt="판다마켓 로고" /> | ||
| </a> | ||
| <a | ||
| href="login.html" | ||
| aria-label="로그인 페이지로 이동" | ||
| class="login-button btn btn-primary" | ||
| >로그인</a | ||
| > | ||
| <a href="login.html" class="login-button btn-sm btn-primary">로그인</a> | ||
| </div> | ||
| </header> | ||
| <main class="content"> | ||
| <div class="banner top" aria-label="상단 배너"> | ||
| <div class="inner"> | ||
| <div class="info"> | ||
| <h2>일상의 모든 물건을<br />거래해 보세요</h2> | ||
| <div class="banner banner-hero" aria-label="상단 배너"> | ||
| <div class="banner-container"> | ||
| <div class="banner-info"> | ||
| <h2 class="banner-title">일상의 모든 물건을<br />거래해 보세요</h2> | ||
| <a | ||
| href="items.html" | ||
| aria-label="상품 페이지로 이동" | ||
| class="btn btn-primary" | ||
| class="btn-lg btn-primary" | ||
| >구경하러 가기</a | ||
| > | ||
| </div> | ||
| <img | ||
asksa1256 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| class="banner-img" | ||
| srcset=" | ||
| images/Img_home_top_mb.png 448w, | ||
| images/Img_home_top.png 746w | ||
| " | ||
| sizes=" | ||
| (min-width: 768px) 746px, | ||
| 448px | ||
| " | ||
| loading="eager" | ||
| src="images/Img_home_top.png" | ||
| alt="팬더가 파란 장바구니를 메고 마을 가운데에 서있는 일러스트" | ||
| /> | ||
| </div> | ||
| </div> | ||
| <section class="section-hotitem" aria-label="인기 상품 확인"> | ||
| <div class="inner"> | ||
| <section class="section section-hotitem" aria-label="인기 상품 확인"> | ||
| <div class="section-container"> | ||
| <img | ||
| srcset=" | ||
| images/Img_home_01-344.png 344w, | ||
| images/Img_home_01-696.png 696w | ||
| " | ||
| sizes=" | ||
| (min-width: 960px) 580px, | ||
| (min-width: 768px) 580px, | ||
| (min-width: 480px) 696px, | ||
| 344px | ||
| " | ||
| loading="lazy" | ||
| src="images/Img_home_01.png" | ||
| alt="두 마리의 팬더가 인기 상품인 초록색 티셔츠를 보고 있는 모습입니다." | ||
| alt="두 마리의 팬더가 인기 상품인 초록색 티셔츠를 보고 있는 일러스트" | ||
| /> | ||
| <div class="info"> | ||
| <div class="info-label">Hot item</div> | ||
| <h2>인기 상품을<br />확인해 보세요</h2> | ||
| <p> | ||
| <div class="section-info"> | ||
| <div class="section-label">Hot item</div> | ||
| <h2 class="section-title">인기 상품을<br />확인해 보세요</h2> | ||
| <p class="section-desc"> | ||
| 가장 HOT한 중고거래 물품을<br /> | ||
| 판다 마켓에서 확인해 보세요 | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| <section class="section-search" aria-label="상품 검색"> | ||
| <div class="inner"> | ||
| <section class="section section-search" aria-label="상품 검색"> | ||
| <div class="section-container"> | ||
| <img | ||
| srcset=" | ||
| images/Img_home_02-344.png 344w, | ||
| images/Img_home_02-696.png 696w | ||
| " | ||
| sizes=" | ||
| (min-width: 960px) 580px, | ||
| (min-width: 768px) 580px, | ||
| (min-width: 480px) 696px, | ||
| 344px | ||
| " | ||
| loading="lazy" | ||
| src="images/Img_home_02.png" | ||
| alt="돋보기로 상품들 중 가운데 상품을 확대해서 보는 모습입니다." | ||
| alt="돋보기로 상품들 중 가운데 상품을 확대해서 보는 일러스트" | ||
| /> | ||
| <div class="info"> | ||
| <div class="info-label">Search</div> | ||
| <h2> | ||
| <div class="section-info"> | ||
| <div class="section-label">Search</div> | ||
| <h2 class="section-title"> | ||
| 구매를 원하는<br /> | ||
| 상품을 검색하세요 | ||
| </h2> | ||
| <p>구매하고 싶은 물품은 검색해서<br />쉽게 찾아보세요</p> | ||
| <p class="section-desc"> | ||
| 구매하고 싶은 물품은 검색해서<br />쉽게 찾아보세요 | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| <section class="section-register" aria-label="상품 등록"> | ||
| <div class="inner"> | ||
| <section class="section section-register" aria-label="상품 등록"> | ||
| <div class="section-container"> | ||
| <img | ||
| srcset=" | ||
| images/Img_home_03-344.png 344w, | ||
| images/Img_home_03-696.png 696w | ||
| " | ||
| sizes=" | ||
| (min-width: 960px) 580px, | ||
| (min-width: 768px) 580px, | ||
| (min-width: 480px) 696px, | ||
| 344px | ||
| " | ||
| loading="lazy" | ||
| src="images/Img_home_03.png" | ||
| alt="아래에 폴더들이 있고, 그 위에 마법봉으로 가운데의 연필꽂이, 공책, 하트 프레임 안경을 가리키는 모습입니다." | ||
| alt="아래에 폴더들이 있고, 그 위에 마법봉으로 가운데의 연필꽂이, 공책, 하트 프레임 안경을 가리키는 일러스트" | ||
| /> | ||
| <div class="info"> | ||
| <div class="info-label">Register</div> | ||
| <h2>판매를 원하는<br />상품을 등록하세요</h2> | ||
| <p>어떤 물건이든 판매하고 싶은 상품을<br />쉽게 등록하세요</p> | ||
| <div class="section-info"> | ||
| <div class="section-label">Register</div> | ||
| <h2 class="section-title">판매를 원하는<br />상품을 등록하세요</h2> | ||
| <p class="section-desc"> | ||
| 어떤 물건이든 판매하고 싶은 상품을<br />쉽게 등록하세요 | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| <div class="banner bottom" aria-label="하단 배너"> | ||
| <div class="inner"> | ||
| <div class="info"> | ||
| <h2> | ||
| <div class="banner" aria-label="하단 배너"> | ||
| <div class="banner-container"> | ||
| <div class="banner-info"> | ||
| <h2 class="banner-title"> | ||
| 믿을 수 있는<br /> | ||
| 판다마켓 중고 거래 | ||
| </h2> | ||
| </div> | ||
| <img | ||
| class="banner-img" | ||
| srcset=" | ||
| images/Img_home_bottom_mb.png 448w, | ||
| images/Img_home_bottom.png 746w | ||
| " | ||
| sizes=" | ||
| (min-width: 768px) 746px, | ||
| 448px | ||
| " | ||
| loading="lazy" | ||
| src="images/Img_home_bottom.png" | ||
| alt="팬더 두 마리가 파란 장바구니를 메고 서로 상품 후기를 주고받는 일러스트" | ||
| /> | ||
| </div> | ||
| </div> | ||
| </main> | ||
| <footer aria-label="하단 정보"> | ||
| <div class="inner"> | ||
| <footer class="footer" aria-label="하단 정보"> | ||
| <div class="footer-container"> | ||
| <div class="copyright">©codeit - 2024</div> | ||
| <div class="footer-menu"> | ||
| <a href="privacy.html" aria-label="개인정보처리방침" | ||
|
|
@@ -139,28 +182,36 @@ <h2> | |
| <a | ||
| href="https://www.facebook.com/?locale=ko_KR" | ||
| target="_blank" | ||
| aria-label="페이스북 열기" | ||
| aria-label="판다마켓 페이스북 열기" | ||
| title="클릭 시 판다마켓 페이스북으로 이동합니다." | ||
| rel="noopener noreferrer" | ||
| > | ||
| <img src="images/ic_facebook.png" alt="페이스북 아이콘" /> | ||
| </a> | ||
| <a | ||
| href="https://x.com/login?lang=ko" | ||
| target="_blank" | ||
| aria-label="트위터 열기" | ||
| aria-label="판다마켓 트위터 열기" | ||
| title="클릭 시 판다마켓 트위터로 이동합니다." | ||
| rel="noopener noreferrer" | ||
| > | ||
| <img src="images/ic_twitter.png" alt="트위터 아이콘" /> | ||
| </a> | ||
| <a | ||
| href="https://www.youtube.com/?hl=ko&gl=KR&app=desktop" | ||
| target="_blank" | ||
| aria-label="유튜브 열기" | ||
| aria-label="판다마켓 유튜브 열기" | ||
| title="클릭 시 판다마켓 유튜브로 이동합니다." | ||
| rel="noopener noreferrer" | ||
| > | ||
| <img src="images/ic_youtube.png" alt="유튜브 아이콘" /> | ||
| </a> | ||
| <a | ||
| href="https://www.instagram.com/" | ||
| target="_blank" | ||
| aria-label="인스타그램 열기" | ||
| aria-label="판다마켓 인스타그램 열기" | ||
| title="클릭 시 판다마켓 인스타그램으로 이동합니다." | ||
| rel="noopener noreferrer" | ||
| > | ||
| <img src="images/ic_instagram.png" alt="인스타그램 아이콘" /> | ||
| </a> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.