-
Notifications
You must be signed in to change notification settings - Fork 39
[이상달] Sprint1 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
addiescode-sj
merged 12 commits into
codeit-bootcamp-frontend:Basic-이상달
from
asksa1256:part1-이상달-sprint1
Apr 4, 2025
Merged
[이상달] Sprint1 #9
addiescode-sj
merged 12 commits into
codeit-bootcamp-frontend:Basic-이상달
from
asksa1256:part1-이상달-sprint1
Apr 4, 2025
The head ref may contain hidden characters: "part1-\uC774\uC0C1\uB2EC-sprint1"
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addiescode-sj
approved these changes
Apr 2, 2025
Collaborator
addiescode-sj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! 코멘트 보시고 조금만 다듬어보면 멋진 결과물 나올것같네요 :)
주요 리뷰 포인트
- 접근성 향상을 위한 속성 추가
- alt 속성 사용
- 네이밍케이스, 네이밍 컨벤션
Collaborator
질문에 대한 답변심화 요구사항 구현을 위해 크기, 폰트사이즈 관련 요소들을 모두 rem단위로 설정하고, 미디어 쿼리로 화면 크기가 작아짐에 따라 html에서 font-size를 줄였는데 문제에서 의도한 건 이 방식이 아닌 것 같아서요.. 다른 방법이 있다면 무엇인지 알고 싶습니다!추천하시는 class 작명법이 있다면 알려주시면 감사하겠습니다.두개 질문에 대한 답변 모두 본문 내 코멘트에서 피드백 드렸습니다! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
배포 링크
glowing-chaja-f558c3.netlify.app
스크린샷
멘토에게