-
Notifications
You must be signed in to change notification settings - Fork 26
[김참솔] Sprint 6 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kiJu2
merged 26 commits into
codeit-bootcamp-frontend:React-김참솔
from
cskime:React-김참솔-sprint6
Aug 4, 2025
The head ref may contain hidden characters: "React-\uAE40\uCC38\uC194-sprint6"
Merged
[김참솔] Sprint 6 #97
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
364c484
refactor(Sprint5): 불필요한 console.log 삭제
cskime 700e63b
feat(Sprint5): BASE_URL을 환경 변수로 관리
cskime 1a4411c
fix(Sprint5): Item 제목을 <h3> semantic tag로 교체
cskime d36e752
refactor(Sprint5): 베스트 상품의 정렬 로직을 useMemo hook으로 최적화
cskime 097687f
chore(Sprint5): 상용 환경 변수 추가
cskime 80a1b3d
fix(Sprint5): fix typo
cskime 83e9535
chore(Sprint6): styled-components package 설치
cskime a76bf33
feat(Sprint6): `/additem` path로 이동했을 때 '중고마켓' 링크를 active 상태로 유지
cskime d0c8777
refactor(Sprint6): 파일 이름을 kebab-case로 변경 (add-item-page)
cskime 76b0be8
feat(Sprint6): `styled-components`로 Button component 구현
cskime 25b0054
fix(Sprint5): `exhaustive-deps` warning 제거
cskime 4e9f92c
feat(Sprint6): Item 및 section 관련 component를 `styled-components`로 교체
cskime d78c40b
refactor(Sprint6): ItemsPage를 styled-components로 교체, kebab-case 이름 변경
cskime eb3ec33
feat(Sprint6): Section에서 header와 content의 gap을 설정할 수 있도록 변경
cskime fa9ad93
feat(Sprint6): 상품 등록 화면 기본 구조 구현
cskime ec790dc
fix(Sprint6): Custom prop에 transient prop 적용
cskime 0011b05
feat(Sprint6): 상품 등록하기 - 상품 이미지 추가 구현
cskime 5895461
feat(Sprint6): 상품 등록하기 - 이미지 추가 최대 1개 제한, 추가한 이미지 삭제 구현
cskime aec59f2
feat(Sprint6): Mobile에서 SectionHeader의 Button action이 오른쪽 상단에 고정되도록 수정
cskime cd8d67e
fix(Sprint6): 상품 등록하기 - mobile에서 상품 이미지 input과 preview가 영역을 1:1로 차지하…
cskime 4261082
feat(Sprint6): 상품 등록하기 - Text input component 구현
cskime 0cc760a
feat(Sprint6) 상품 등록하기 - 태그 목록 구현
cskime d94f0b2
fix(Sprint6): SectionHeaderAction wrapper에 전달된 prop을 Button에 모두 전달
cskime 85176e7
feat(Sprint6): 상품 등록하기 - title, desc, price input을 입력했을 때만 등록 버튼 활성화
cskime 1519cf3
feat(Sprint6): 상품 등록하기 - 가격 input에 숫자만 입력, 콤마 formatting 적용
cskime d847985
feat(Sprint6): 태그 추가/삭제 구현
cskime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
cskime marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| VITE_API_BASE_URL=https://panda-market-api.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| VITE_API_BASE_URL=https://panda-market-api.vercel.app |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,20 @@ | ||
| import "./Button.css"; | ||
| import styled from "styled-components"; | ||
|
|
||
| function Button({ title, onClick }) { | ||
| return ( | ||
| <button className="Button" onClick={onClick}> | ||
| {title} | ||
| </button> | ||
| ); | ||
| const StyledButton = styled.button` | ||
| background-color: ${({ disabled }) => | ||
| disabled ? "var(--color-cool-gray-400)" : "var(--color-primary-100)"}; | ||
| padding: 8px 23px; | ||
| color: var(--color-cool-gray-100); | ||
| font-size: 16px; | ||
| font-weight: 600; | ||
| line-height: 26px; | ||
| border-radius: 8px; | ||
| border: none; | ||
| cursor: ${({ disabled }) => (disabled ? "default" : "pointer")}; | ||
| `; | ||
|
|
||
| function Button({ children, ...props }) { | ||
| return <StyledButton {...props}>{children}</StyledButton>; | ||
cskime marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| export default Button; | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 개발 환경과 운영 환경을 따로 분리하셨군요 ! 😉👍