[김원] Sprint 12 #186
Merged
[김원] Sprint 12 #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
Nov 19, 2024
Collaborator
dongqui
left a comment
dongqui
left a comment
There was a problem hiding this comment.
원님 고생 많으셨습니다 :)
기능 구현 자체는 이제 너무 잘하시고, 전반적으로 상태 범위를 줄이고, 컴포넌트화를 조금만 더 해보시면 더욱 좋을 거 같습니다!! 👍
| const { pathname } = request.nextUrl; | ||
|
|
||
| // 인증이 필요한 페이지 목록 (비공개 페이지) | ||
| const privatePages = ["/addArticle", "/addItem"]; |
| }; | ||
|
|
||
| // 드롭다운 외부 클릭 처리 | ||
| useEffect(() => { |
Collaborator
There was a problem hiding this comment.
드랍다운을 컴포넌트화 하고 해당 로직을 넣으면 좀 더 깔끔할 거 같아요!
| setIsEditing(false); | ||
| } catch (error) { | ||
| console.error("댓글 수정 실패:", error); | ||
| setAlertMessage("댓글 수정에 실패했습니다."); |
Collaborator
There was a problem hiding this comment.
alert상태를 하나로 관리해보는 것은 어떨까요!? 🤔
| if (isLoading) return; | ||
| // Intersection Observer 설정 | ||
| const observer = useRef<IntersectionObserver | null>(null); | ||
| const lastCommentRef = useCallback( |
Collaborator
There was a problem hiding this comment.
observer disconnect할 수 있는 ㅂ부분이 필요하겠네요!
|
|
||
| return ( | ||
| <> | ||
| <div className="py-6 relative"> |
Collaborator
There was a problem hiding this comment.
컴포넌화하면 jsx부분도 훨씬 깔끔해질 거 같습니다!
| import { ArticleSchema } from "@/zod/articleSchema"; | ||
| import { ArticleSortOption } from "@/types/article"; | ||
|
|
||
| export const useArticle = () => { |
Collaborator
There was a problem hiding this comment.
안티패턴으로 보입니다..!
모든 훅을 한 곳에 모으다보니 사용하지 않은 곳에서도 훅이 실행되죠! 가령 AllArticleSection에서는 useArticles만 필요하지만 아래 모든 훅들이 다 들어가게 됩니다..!
| const { data: articleDetail } = useArticleDetail(articleId); | ||
|
|
||
| // 초기 좋아요 상태 설정 | ||
| useEffect(() => { |
Collaborator
There was a problem hiding this comment.
mutation 내부에서 처리하시는 게 좀 더 깔끔할 거 같아요
| }, [productDetail?.images]); | ||
|
|
||
| // 드롭다운 외부 클릭 처리 | ||
| useEffect(() => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
배포 사이트
https://next-panda-market.vercel.app
기본 요구사항
체크리스트 [기본]
중고마켓
상품 상세
상품 등록
자유게시판
게시글 상세
게시글 등록
체크리스트 [심화]
주요 변경사항
스크린샷
멘토에게