Skip to content

Conversation

@summerDev96
Copy link
Collaborator

@summerDev96 summerDev96 commented Jul 23, 2025

📦 Pull Request

📝 요약(Summary)

  • 필터 컴포넌트에 custom 폰트 적용 및 공통 컴포넌트 듀얼 슬라이더 적용
  • _document 파일 내 공통 Head 메타 태그 설정
  • _app.tsx 파일 내 공통 Head title 설정 및 tanstack-query 프로바이더 및 클라이언트 설정 추가

💬 공유사항 to 리뷰어

custom 폰트 적용, DualSlider props 제대로 넘기는지 확인해주시면 될 것 같습니다!

🗂️ 관련 이슈

와인 목록 페이지에서 사용 예정 (모바일에서는 모달 추가 필요)

📸 스크린샷

image

✅ 체크리스트

  • 빌드 및 테스트 통과
  • ESLint/Prettier 검사 통과

@summerDev96 summerDev96 requested review from Luganic and youdaeng2 July 23, 2025 07:22
Copy link
Member

@youdaeng2 youdaeng2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

<div className='flex gap-2.5'>
<span className='custom-text-xl-bold'>WINE TYPES</span>
<div className='flex gap-3'>
{/* todo: 공통 뱃지로 변경 필요 */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뱃지 컴포넌트 넣어주셨다면 주석 제거하셔도 좋을 것 같습니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

놓친 부분인데 찾아주셨네요! 주석 제거하겠습니다

/>
<div className='flex flex-col gap-2'>
<span className='custom-text-xl-bold'>PRICE</span>
<DualSlider max={1000000} value={priceRange} onChange={setPriceRange} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 넘겨주신 것 같습니다!

Comment on lines 21 to 31
<Head>
<title>WINE</title>
<meta charSet='UTF-8' />
<meta name='viewport' content='width=device-width, initial-scale=1' />
<meta name='description' content='와인 리뷰 사이트' />
<meta property='og:title' content='WINE' />
<meta property='og:description' content='와인 리뷰 사이트' />
{/* todo: 배포 후 이미지, url 변경 필요 */}
<meta property='og:image' content='' />
<meta property='og:url' content='' />
<meta property='og:type' content='website' />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 중간 점검 끝난 후에 이미지 넣어주고 세세하게 건드려보면 될 것 같네요

</div>
<Head>
<title>WINE</title>
<meta charSet='UTF-8' />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠짐없이 잘 넣으신 것 같네요!

<meta property='og:type' content='website' />
</Head>
<QueryClientProvider client={queryClient}>
{!hideHeader && <Gnb />}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 렌더링까지 잘 줄이신 것 같습니다. 고생하셨습니다!

@summerDev96 summerDev96 merged commit 3ffeb9c into codeit-part3-7:dev Jul 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants