Refactor: 공통 필터 컴포넌트, app 파일 Head와 tanstack-query 설정 #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youdaeng2
approved these changes
Jul 23, 2025
| <div className='flex gap-2.5'> | ||
| <span className='custom-text-xl-bold'>WINE TYPES</span> | ||
| <div className='flex gap-3'> | ||
| {/* todo: 공통 뱃지로 변경 필요 */} |
Member
There was a problem hiding this comment.
뱃지 컴포넌트 넣어주셨다면 주석 제거하셔도 좋을 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
놓친 부분인데 찾아주셨네요! 주석 제거하겠습니다
| /> | ||
| <div className='flex flex-col gap-2'> | ||
| <span className='custom-text-xl-bold'>PRICE</span> | ||
| <DualSlider max={1000000} value={priceRange} onChange={setPriceRange} /> |
src/pages/_app.tsx
Outdated
Comment on lines
21
to
31
| <Head> | ||
| <title>WINE</title> | ||
| <meta charSet='UTF-8' /> | ||
| <meta name='viewport' content='width=device-width, initial-scale=1' /> | ||
| <meta name='description' content='와인 리뷰 사이트' /> | ||
| <meta property='og:title' content='WINE' /> | ||
| <meta property='og:description' content='와인 리뷰 사이트' /> | ||
| {/* todo: 배포 후 이미지, url 변경 필요 */} | ||
| <meta property='og:image' content='' /> | ||
| <meta property='og:url' content='' /> | ||
| <meta property='og:type' content='website' /> |
Member
There was a problem hiding this comment.
고생하셨습니다! 중간 점검 끝난 후에 이미지 넣어주고 세세하게 건드려보면 될 것 같네요
Luganic
approved these changes
Jul 23, 2025
src/pages/_app.tsx
Outdated
| </div> | ||
| <Head> | ||
| <title>WINE</title> | ||
| <meta charSet='UTF-8' /> |
| <meta property='og:type' content='website' /> | ||
| </Head> | ||
| <QueryClientProvider client={queryClient}> | ||
| {!hideHeader && <Gnb />} |
Collaborator
There was a problem hiding this comment.
불필요한 렌더링까지 잘 줄이신 것 같습니다. 고생하셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
📝 요약(Summary)
💬 공유사항 to 리뷰어
custom 폰트 적용, DualSlider props 제대로 넘기는지 확인해주시면 될 것 같습니다!
🗂️ 관련 이슈
와인 목록 페이지에서 사용 예정 (모바일에서는 모달 추가 필요)
📸 스크린샷
✅ 체크리스트