✨[Feat] 모임 찾기 검색 debounce 적용 #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cloud0406
approved these changes
Jan 22, 2025
Contributor
cloud0406
left a comment
cloud0406
left a comment
There was a problem hiding this comment.
지금 내부에 메모리 누수 방지용 코드가 따로 없는 것 같아서 이 부분도 추가하면 좋을 것 같습니다!
수고하셨습니다~.~
| function SearchInput({ value, onChange }: SearchInputProps) { | ||
| const [inputValue, setInputValue] = useState(value); | ||
|
|
||
| const debouncedOnChange = useMemo( |
Contributor
There was a problem hiding this comment.
p4: 여기 혹시 useMemo를 사용하신 이유가 있을까요? 이 부분은 useCallback이 어울리지 않을까 해서요!
Contributor
Author
There was a problem hiding this comment.
메모리 누수 방지용 코드에 대해서는 알아봐야 할 것 같아요!
useCallback 말고 useMemo를 사용한 이유는, 처음에는 useCallback으로 햇었는데 lint 에러가 발생하더라구요.
밑에 블로그 보고 해결했습니다.
내용은 "useCallback은 인라인 함수를 기대합니다. debounce나 throttle이 반환하는 함수를 전달하는 것은 적절하지 않습니다. 왜냐하면 ESLint 규칙이 어떤 의존성을 포함해야 하는지 정확히 파악할 수 없기 때문입니다. useMemo를 사용해서 해결해라"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
모임 검색 부분에 debounce 적용했습니다