Refactor/link card store #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
99minji
commented
Nov 16, 2024
99minji
commented
- link card store 에 totalcount 추가했습니다~!
Collaborator
|
옹 제 Linkpage 브랜치 merge 하고 push 하셨나봐여? |
hongggyelim
reviewed
Nov 16, 2024
| interface UpdateLinkBody { | ||
| url: string; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
import getLinks 는 사용하지않으면 삭제되어야할 것 같습니당
hongggyelim
reviewed
Nov 16, 2024
| } | ||
|
|
||
| export const useLinkCardStore = create<LinkCardStore>((set) => ({ | ||
| export const useLinkCardStore = create<LinkCardStore>((set, get) => ({ |
Collaborator
There was a problem hiding this comment.
get 이 추가된 이유가 궁금합니다! 밑에서 쓰이고있는거같진 않아서욥
hongggyelim
reviewed
Nov 16, 2024
| export const useLinkCardStore = create<LinkCardStore>((set) => ({ | ||
| export const useLinkCardStore = create<LinkCardStore>((set, get) => ({ | ||
| linkCardList: [], | ||
| totalCount: 0, |
Collaborator
There was a problem hiding this comment.
초기값을 null로 지정하고, interface LinkCardStore 에서는 number| null 로 타입 지정하는것이 좋을것같습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.