Skip to content

Refactor: 즐겨찾기 페이지 리팩토링 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
99minji merged 8 commits into from
Nov 19, 2024
Merged

Refactor: 즐겨찾기 페이지 리팩토링 #116

99minji merged 8 commits into from
Nov 19, 2024

Conversation

@99minji
Copy link
Collaborator

@99minji 99minji commented Nov 18, 2024

작업 사항

  • Design - link 페이지 상단 높이 기준으로 즐겨찾기 height 값 수정 & 하단 여백 css 수정
  • Feat - 즐겨찾기에서 링크 페이지로 돌아가는 버튼 생성
  • Fix - 페이지네이션 pageSize 값 재수정 필요 PC (9개) / TB,MO (6개)
  • Feat - debounce 로 적용하여 리렌더링 실행
  • Feat - 토큰 없을 때 즐겨찾기 페이지에서 로그인으로 리다이렉트
  • Fix - 즐겨찾기 목록 없을 때 컴포넌트 분리

@99minji 99minji linked an issue Nov 18, 2024 that may be closed by this pull request
즐겨찾기 리팩토링 #110
Closed
@99minji 99minji changed the title 즐겨찾기 페이지 리팩토링 Refactor: 즐겨찾기 페이지 리팩토링 Nov 18, 2024
venise5224
venise5224 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@venise5224 venise5224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨씁니다

@junjeeong
Copy link
Collaborator

junjeeong commented Nov 19, 2024 •
edited
Loading

피그마에는 모바일일 때 10개인데 6개로 줄이신건 의도하신걸까요??
크게 상관없을 것 같긴 하네요~

hongggyelim
hongggyelim reviewed Nov 19, 2024
View reviewed changes
lib/utils.ts Outdated
Copy link
Collaborator

@hongggyelim hongggyelim Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 파일 바로 삭제해주셔도 됩니당 !

hongggyelim
hongggyelim approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@hongggyelim hongggyelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당 !

@99minji 99minji merged commit 53c43e3 into develop Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongggyelim hongggyelim hongggyelim approved these changes

@venise5224 venise5224 venise5224 approved these changes

Assignees

@99minji 99minji

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

즐겨찾기 리팩토링

5 participants

@99minji @junjeeong @hongggyelim @venise5224