Feat: 공통 Button 컴포넌트 구현 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venise5224
approved these changes
Nov 6, 2024
Collaborator
|
승인 없을때도 머지가 되는거같네용 |
hongggyelim
reviewed
Nov 6, 2024
| type?: "positive" | "negative"; | ||
| size?: string; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
onClick, disabled 도 옵셔널로 추가되었으면 좋겠습니다
Collaborator
There was a problem hiding this comment.
button type="button/submit"이것도 받아야하지않을까요?
99minji
approved these changes
Nov 6, 2024
Collaborator
99minji
left a comment
99minji
left a comment
There was a problem hiding this comment.
디자인엔 없지만 hover 시 디자인도 있었으면 좋겠네용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 이슈 번호
[linkbray 버튼 UI 구현 #7 ]
🔎 작업 내용
이미지