Feat: CardItem 컴포넌트 구현, timeAgo 유틸함수 구현, star.svg kebab.svg 다운로드 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
타입오류 뜹니다! |
Collaborator
Author
고쳤습니다! |
venise5224
approved these changes
Nov 7, 2024
| <section className="relative w-full h-[60%]"> | ||
| <Image | ||
| src={info.imageSource || `/images/no-content.svg`} | ||
| objectFit="cover" |
Collaborator
There was a problem hiding this comment.
objectFit="cover" 이거 현재 버전에서 경고 뜰거에요
style={{ objectFit: 'cover' }} 이렇게 바꾸면 👍
hongggyelim
reviewed
Nov 7, 2024
| <section className="w-full h-[40%] flex flex-col justify-between gap-[10px] pt-[15px] px-[20px] pb-[10px]"> | ||
| <div className="flex justify-between"> | ||
| <span className="text-sm text-gray-400"> | ||
| {createdTime || "1일 전"} |
Collaborator
There was a problem hiding this comment.
작성시간 계산하는거는 나중에 따로 구현하실건가욤?
Collaborator
There was a problem hiding this comment.
util/timeAgo를 제가 못봤었네요 ㅎ
hongggyelim
reviewed
Nov 7, 2024
| <Image src="/icons/kebab.svg" alt="kebab button" fill /> | ||
| </div> | ||
| </div> | ||
| <div className="text-[black100] text-lg "> |
Collaborator
There was a problem hiding this comment.
저는 text-black100 으로 작성해도 정상적으로 적용되더라구요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
설명