Feat: 로그인 페이지 UI 구현 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venise5224
approved these changes
Nov 6, 2024
|
|
||
| return ( | ||
| <div className="mb-6"> | ||
| <label htmlFor={type} className="text-[14px] block mb-[12px]"> |
Collaborator
There was a problem hiding this comment.
htmlFor에 type을 넣는 이유가 있나요 ?.?
추가로 input와 이어주려면 id에 type을 넣어줘야하는건가요?
Contributor
Author
There was a problem hiding this comment.
- label이랑 input을 연결해주는 느낌입니당
- 네 맞아용
Collaborator
There was a problem hiding this comment.
회원가입 페이지를 만들때 비밀번호와 비밀번호 인풋이 같은 타입으로 들어갈거같은데 괜찮을까용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 이슈 번호
[linkbray 로그인 페이지 UI 구현 #2 ]
🔎 작업 내용
이미지