Feat: SearchInput 컴포넌트 구현, global.css input outline:none 추가, tailwind.config 반응형 값 수정 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hongggyelim
reviewed
Nov 7, 2024
| return ( | ||
| <form | ||
| onSubmit={handleSubmit} | ||
| className="flex gap-[8px] w-[1024px] h-[54px] items-center px-[16px] py-[15px] bg-gray-100 rounded-[10px] md:w-[704px] md:h-[54px] sm:w-[325px] sm:h-[43px] transition-all" |
Collaborator
There was a problem hiding this comment.
혹시 민지님이 작업하신 Container (layout) 에 들어가는거면 w-full 로 해도되지않을까요?
Collaborator
Author
There was a problem hiding this comment.
저희는 특정 페이지에서만 쓰이긴 하지만 ui 컴포넌트는 다른 곳에서 금방 쓸 수 있도록 재사용성을 고려해서 만들어야 한다고 생각했습니다! 고로 부모 컴포넌트에 종속적으로 크기를 갖는 게 아닌 이 친구만의 고유한 width가 있어야 한다고 생각했습니다!
hongggyelim
reviewed
Nov 7, 2024
| const [value, setValue] = useState(""); | ||
|
|
||
| const handleChange = (e: ChangeEvent<HTMLInputElement>) => { | ||
| setValue(e.target.value); |
Collaborator
There was a problem hiding this comment.
입력값을 받을때 debounce를 적용해봐도 좋을것같습니다 !
hongggyelim
reviewed
Nov 7, 2024
pages/index.tsx
Outdated
| <div className="flex justify-center items-center mt-[20px]"> | ||
| <SearchInput /> | ||
| </div> | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
앟 이거는 삭제하겠습니다! 잘못 들어간 겁니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
SearchInput.mov
설명