Feat: 랜딩페이지 제작 #42
Merged
Feat: 랜딩페이지 제작 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongggyelim
reviewed
Nov 8, 2024
pages/index.tsx
Outdated
| return ( | ||
| <main> | ||
| <div className="flex flex-col items-center bg-gray100"> | ||
| <h1 className="mt-[28px] text-[32px] leading-[42px] font-bold md:mt-[40px] lg:mt-[70px] md:text-[64px] md:leading-[80px] text-center"> |
Collaborator
There was a problem hiding this comment.
mt-[28px] text-[32px] mt-7 text-8 로 대체가 가능할것같습니다 : )
md:mt-[40px] 도 마찬가지 입니다
Collaborator
There was a problem hiding this comment.
그냥 7은 아마 rem으로 들어갈텐데 저희는 px로 통일해서 저렇게 적어주신 걸거에요!
hongggyelim
approved these changes
Nov 8, 2024
Collaborator
hongggyelim
left a comment
hongggyelim
left a comment
There was a problem hiding this comment.
수고하셨습니다
테일윈드 자체 속성(?)으로 사용할수있는 값들은 추후 수정해보셔도 좋을것같아요
99minji
approved these changes
Nov 8, 2024
pages/index.tsx
Outdated
| </div> | ||
|
|
||
| <div className="flex flex-col items-center gap-[80px] px-[33px] pt-[40px] pb-[80px] md:pt-[80px] md:pb-[170px] md:gap-[100px] lg:pt-[120px]"> | ||
| <section className="flex flex-col md:flex-row md:items-center md:gap-[51px] lg:gap-[157px]"> |
Collaborator
There was a problem hiding this comment.
section style 이 공통인데 요론건 공통으로 빼도 좋을 것 같아여 ㅎㅎ
pages/index.tsx
Outdated
| /> | ||
| </section> | ||
|
|
||
| <section className="flex flex-col md:flex-row-reverse md:items-center md:gap-[51px] lg:gap-[157px]"> |
Collaborator
There was a problem hiding this comment.
공통으로 빼고 여기section 에만 md:flex-row-reverse 추가해주면 될 것 같네여!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
스크린샷