Feat:Footer UI 구현 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venise5224
requested review from
99minji,
hongggyelim,
junjeeong and
mungyun
Closed
junjeeong
approved these changes
Nov 11, 2024
mungyun
approved these changes
Nov 12, 2024
Comment on lines
+10
to
+11
| <footer className="bg-black200 pt-8 sm:px-8 pb-[108px] md:px-[104px] lg:px-[104px]"> | ||
| <nav className="relative flex justify-between"> |
components/Layout/Footer.tsx
Outdated
Comment on lines
26
to
49
| <li> | ||
| <Link href={"https://www.facebook.com/codeit.kr/"} target="_blank"> | ||
| <Image src={Facebook} width={20} height={20} alt="facebook" /> | ||
| </Link> | ||
| </li> | ||
| <li> | ||
| <Link href={"https://x.com/"} target="_blank"> | ||
| <Image src={twitter} width={20} height={20} alt="twitter" /> | ||
| </Link> | ||
| </li> | ||
| <li> | ||
| <Link | ||
| href={"https://www.youtube.com/channel/UCCM79CPm2WbBYTRaiNEExbg"} | ||
| target="_blank" | ||
| > | ||
| <Image src={youtube} width={20} height={20} alt="youtube" /> | ||
| </Link> | ||
| </li> | ||
| <li> | ||
| <Link href={"https://www.instagram.com/codeit_kr/"} target="_blank"> | ||
| <Image src={instagram} width={20} height={20} alt="instagram" /> | ||
| </Link> | ||
| </li> | ||
| </ul> |
Contributor
There was a problem hiding this comment.
이 부분 SNS만 관리하는 컴포넌트로 분리해주시면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
스크린샷