Feat : 페이지네이션 작업 #76
Merged
Feat : 페이지네이션 작업 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
junjeeong
approved these changes
Nov 13, 2024
| useEffect(() => { | ||
| const handleResize = () => { | ||
| const width = window.innerWidth; | ||
| setMaxPagesToShow(width > 1024 ? 5 : 3); |
Collaborator
There was a problem hiding this comment.
뭔가 햇더니 "1 2 3 ..... end" "1 2 3 4 5 .... end" 이냐의 분기점이군요👍
venise5224
approved these changes
Nov 13, 2024
|
|
||
| switch (req.method) { | ||
| case "GET": | ||
| const { page = "1", pageSize = "10" } = req.query; |
Collaborator
There was a problem hiding this comment.
const page = parseInt((query.page as string) || "1", 10);
const pageSize = parseInt((query.pageSize as string) || "6", 10);
page, pageSize가 number 타입으로 넘어오는데 값이 없을 때는 string 타입으로 들어가게 되는데 문제가 없을까요 ?
Collaborator
Author
There was a problem hiding this comment.
쿼리 파라미터는 문자열로 받아오기 때문에 number 로 지정하면 오류가 생기더라구요!
undefined 가 발생할 수도 있어어 string 으로 해주고 parseInt 를 사용해서 number 타입으로 변환하도록 했습니다~!
| {/* 페이지 번호와 생략 표시 */} | ||
| {getPageNumbers().map((pageNum, index) => | ||
| typeof pageNum === "number" ? ( | ||
| <li key={index} className={LiStyle}> |
Collaborator
There was a problem hiding this comment.
key에 index말고 다른게 딱히 생각나지는 않네요 😥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Linkbrary #18]
작업 내용
Screenshot.2024-11-13.at.10.52.31.webm
추가 내용