Skip to content

Refactor : 드롭다운 재사용 가능한 컴포넌트로 구현 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mungyun merged 1 commit into from
Nov 13, 2024
Merged

Refactor : 드롭다운 재사용 가능한 컴포넌트로 구현 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions components/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,35 @@
import Link from "next/link";
import React from "react";

interface DropdownItem {
label: string;
href?: string;
onClick?: () => void;
}

interface DropdownProps {
onEdit?: () => void;
openDelete?: () => void;
items: DropdownItem[];
}

const Dropdown = ({ onEdit, openDelete }: DropdownProps) => {
const Dropdown = ({ items }: DropdownProps) => {
const buttonStyle =
"block w-full py-2 text-sm hover:bg-gray200 hover:text-purple100";

return (
<div className="absolute top-[17px] right-0 flex flex-col gap-[2px] min-w-[100px] bg-white shadow-lg rounded">
<button className={buttonStyle} onClick={onEdit}>
수정하기
</button>
<button className={buttonStyle} onClick={openDelete}>
삭제하기
</button>
{items.map((item, index) =>
// href가 있으면 Link로 렌더링
item.href ? (
<Link key={index} href={item.href} className={buttonStyle}>
{item.label}
</Link>
) : (
// href가 없으면 버튼으로 렌더링
<button key={index} onClick={item.onClick} className={buttonStyle}>
{item.label}
</button>
)
)}
</div>
);
};
Expand Down
19 changes: 14 additions & 5 deletions components/LinkCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ interface LinkCardProps {
url: string;
createdAt: string;
};
onEdit?: () => void;
openEdit?: () => void;
openDelete?: () => void;
}

const LinkCard = ({ onEdit, openDelete, info }: LinkCardProps) => {
const LinkCard = ({ openEdit, openDelete, info }: LinkCardProps) => {
const [isSubscribed, setIsSubscribed] = useState(false);
const [isDropdownOpen, setIsDropdownOpen] = useState(false);
const { isOpen: isModalOpen } = useModalStore(); // 모달 열림 상태 구독
Expand All @@ -38,6 +38,17 @@ const LinkCard = ({ onEdit, openDelete, info }: LinkCardProps) => {
// dropdown 버튼
const toggleDropdown = () => setIsDropdownOpen((prev) => !prev);

const dropdownItems = [
{
label: "수정하기",
onClick: openEdit,
},
{
label: "삭제하기",
onClick: openDelete,
},
];

Copy link
Collaborator

@hongggyelim hongggyelim Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item 넘겨줄때 onClick에 대한 핸들러도 같이 넘겨주는거군요! 👍

return (
<div className="w-[340px] h-[344px] rounded-[12px] shadow-lg overflow-hidden cursor-pointer hover:scale-105 hover:duration-300">
<section className="relative w-full h-[60%]">
Expand Down Expand Up @@ -79,9 +90,7 @@ const LinkCard = ({ onEdit, openDelete, info }: LinkCardProps) => {
>
<Image src="/icons/kebab.svg" alt="kebab button" fill />
</button>
{isDropdownOpen && (
<Dropdown onEdit={onEdit} openDelete={openDelete} />
)}
{isDropdownOpen && <Dropdown items={dropdownItems} />}
</div>
)}
</div>
Expand Down
2 changes: 1 addition & 1 deletion pages/link/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const LinkPage = ({ linkList, folderList }: LinkPageProps) => {
{linkCardList.map((link) => (
<LinkCard
key={link.id}
onEdit={() => openEdit(link.url, link.id)}
openEdit={() => openEdit(link.url, link.id)}
openDelete={() => openDelete(link.url, link.id)}
info={link}
/>
Expand Down
Loading