Feat: 링크 검색 기능, 링크 추가 기능 구현 #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongggyelim
reviewed
Nov 13, 2024
| const handleClick = () => { | ||
| // Addmodal 띄우면서 link 전달 | ||
| openModal("AddModal", { list: folderList, link: link }); | ||
| }; |
Collaborator
There was a problem hiding this comment.
잘 적용해주셨군요👍
영상 올려주신거 보니까 모달 한번 클릭하면 isLoading & 버튼 disabled 처리해서 중복으로 추가 방지하도록 해야겠습니다
Collaborator
There was a problem hiding this comment.
링크 추가 후에도 인풋에 입력값이 남아있어서 여기서 초기값 "" 으로 setLink 해주는게 좋을것같아요!
hongggyelim
reviewed
Nov 13, 2024
pages/link/index.tsx
Outdated
| const res = await proxy.get("/api/links", { | ||
| params: { search }, | ||
| }); | ||
| console.log(res.data); |
Collaborator
There was a problem hiding this comment.
테스트를 위해 콘솔 출력 해보신거라면 테스트 후에는 해당 코드를 삭제하는것이 좋겠습니다! :)
hongggyelim
approved these changes
Nov 14, 2024
99minji
approved these changes
Nov 14, 2024
components/Layout/CardsLayout.tsx
Outdated
Comment on lines
9
to
12
| <div className="grid place-items-center grid-cols-1 my-[24px] md:grid-cols-2 lg:grid-cols-3 gap-5 md:gap-6 lg:gap-[20px] w-full"> | ||
| {children} | ||
| </div> | ||
| ); |
Collaborator
There was a problem hiding this comment.
CardsLayout 레이아웃에 margin 을 추가하면 즐겨찾기 페이지에서도 css 가 적용되어서 아래 영역에 추가하는 게 더 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
링크 검색
default.mov
이 때 옵션에 params:{search}를 추가해줘야만 proxy서버에서 req.query 객체에 search값이 들어가 있습니다.
(params 옵션에 search 를 붙혀주면 "/api/links?search=000" 이런식으로 가고 없으면 "/api/links"로 가는 원리입니다.)
링크 추가
default.mov
( 이 때 부모에게 받은 folderList와 AddLinkInput가 갖고있는 link 상태값을 props로 전달합니다.)
남은 작업