Feat: 구글 간편 로그인 기능 구현 #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongggyelim
reviewed
Nov 14, 2024
| <div className="flex gap-4"> | ||
| <Link href="https://accounts.google.com/o/oauth2/v2/auth?scope=openid%20profile%20email&response_type=token&redirect_uri=http://localhost:3000/google&client_id=1079911783112-7rg5ecp9ia9lorm7pit0m2nb2ti1rpt0.apps.googleusercontent.com"> | ||
| <Link | ||
| href={`https://accounts.google.com/o/oauth2/v2/auth?scope=https://www.googleapis.com/auth/userinfo.profile&response_type=code&redirect_uri=http://localhost:3000/api/auth/sign-in/google&client_id=${process.env.GOOGLE_CLIENT_ID}`} |
Collaborator
There was a problem hiding this comment.
GOOGLE_CLIENT_ID는 .env 파일에서 관리하는거죠? 한번 공유 주시면 좋겠습니다 : )
Contributor
Author
There was a problem hiding this comment.
아이디 생성 과정에 대해서 말씀하시는거죠?? 팀 미팅때 공유해드리겠습니당~
hongggyelim
approved these changes
Nov 14, 2024
Collaborator
hongggyelim
left a comment
hongggyelim
left a comment
There was a problem hiding this comment.
Oauth 인증 관련 흐름만 대략 알고있었는데 코드도 작성할게 은근 많아보이네요 수고하셨습니다 !
99minji
approved these changes
Nov 14, 2024
Collaborator
99minji
left a comment
99minji
left a comment
There was a problem hiding this comment.
나중에 간편 로그인 구현할 때 많은 도움이 될 것 같습니닷! 감사합니다 👍
Comment on lines
+15
to
+19
| .post("/api/auth/sign-up/google", { | ||
| name: "박문균", | ||
| token: accessToken, | ||
| redirectUri: "http://localhost:3000/google", | ||
| }) |
Collaborator
There was a problem hiding this comment.
테스트 하기 위해 name 을 고정으로 넣어보신 건가욧!?
Contributor
Author
There was a problem hiding this comment.
아 이 페이지는 없애야하는 데 깜빡했네여 merge하기 전에 수정해서 push할게욥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 내용