fix:로그아웃 시 로그인 페이지로 리다이렉트 #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venise5224
requested review from
99minji,
hongggyelim,
junjeeong and
mungyun
hongggyelim
reviewed
Nov 14, 2024
components/Dropdown.tsx
Outdated
| item.href ? ( | ||
| <Link key={index} href={item.href} className={buttonStyle}> | ||
| <Link | ||
| key={index} |
Collaborator
There was a problem hiding this comment.
key=new Date() 로 하는게 좋을것같아요!
Collaborator
Author
There was a problem hiding this comment.
new Date() 도 컴포넌트가 생성될때마다 달라지니 고유성이 보장되지 않는거같아요 ㅠ_ㅠ
item.label은 고유할테니 이값으로 key를 설정할게요 !
hongggyelim
reviewed
Nov 14, 2024
components/HeaderMenu.tsx
Outdated
| }, | ||
| { | ||
| label: "로그아웃", | ||
| href: "/login", |
Collaborator
There was a problem hiding this comment.
저의 개인적인 의견으로는 랜딩페이지로 이동 시키는게 낫지않을까 싶습니닷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
로그아웃 시 로그인 페이지로 리다이렉트 해놓았습니다.