Feat: 페이지네이션 merge 이후 Link 페이지 개선, useViewport useFetchLinks 훅 추가 #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongggyelim
reviewed
Nov 14, 2024
| { src: "/icons/share.svg", alt: "공유", text: "공유" }, | ||
| { src: "/icons/pen.svg", alt: "이름 변경", text: "이름 변경" }, | ||
| { src: "/icons/delete.svg", alt: "삭제", text: "삭제" }, | ||
| ].map(({ src, alt, text }) => ( |
hongggyelim
reviewed
Nov 14, 2024
lib/api/fetchProxy.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| import { proxy } from "./axiosInstanceApi"; | |||
|
|
|||
| // SSR에서 proxy로 요청 보낼 때 사용하는 로직 ㅜㅊ상화 | |||
99minji
approved these changes
Nov 14, 2024
Comment on lines
16
to
26
| useEffect(() => { | ||
| const fetchLinks = async () => { | ||
| const res = await proxy.get("/api/links", { params: { search } }); | ||
| const res = await proxy.get("/api/links", { | ||
| params: { | ||
| page: query.page, | ||
| pageSize: isTablet ? 6 : 10, | ||
| search: query.search, | ||
| }, | ||
| }); | ||
| setLinkCardList(res.data.list); | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
링크 검색
default.mov
이 때 옵션에 params:{search}를 추가해줘야만 proxy서버에서 req.query 객체에 search값이 들어가 있습니다.
(params 옵션에 search 를 붙혀주면 "/api/links?search=000" 이런식으로 가고 없으면 "/api/links"로 가는 원리입니다.)
링크 추가
default.mov
( 이 때 부모에게 받은 folderList와 AddLinkInput가 갖고있는 link 상태값을 props로 전달합니다.)
폴더 추가
default.mov
남은 작업