폴더 수정/삭제 모달 기능 구현 #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junjeeong
approved these changes
Nov 14, 2024
| } catch (error) { | ||
| console.log(error); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
value가 없으면 모달이 닫히고 끝나는 건가요??
"값이 반드시 필요합니다" 와 같은 경고 toast가 뜨면 자연스러울 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
네 요건 toast 브랜치에서 작업해서 따로 올릴게요!
mungyun
approved these changes
Nov 14, 2024
Contributor
mungyun
left a comment
mungyun
left a comment
There was a problem hiding this comment.
전반적으로 불필요한 console.log도 삭제해주시면 좋을 것 같습니다! 고생하셨어요~
| return ( | ||
| <EditModal | ||
| folderName={props.folderName || "폴더이름"} | ||
| folderId={props.folderId || 1} |
Contributor
There was a problem hiding this comment.
이렇게 설정하면 id가 중복되는 경우가 발생할 수 있는 것 아닌가요??
Collaborator
Author
There was a problem hiding this comment.
folderId={Number(props.folderId)} 로 수정했습니다
이렇게 하면 값이 없을때는 undefined로 들어가도 에러 발생하지않네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
진행 중 작업