Feat : 즐겨찾기 기능 구현 #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Collaborator
|
고생하셨습니다! |
junjeeong
approved these changes
Nov 14, 2024
| /> | ||
| {/* isFavoritePage일 때만 즐겨찾기 버튼 렌더링 */} | ||
| {!isFavoritePage && ( | ||
| <div |
Collaborator
There was a problem hiding this comment.
케밥 버튼과 즐겨찾기 버튼이 isFavoritePage이냐 아니냐에 따라서 조건부 렌더링이 되니
컴포넌트로 따로 만들어도 좋을 것 같다는 생각이 드네요!
Collaborator
Author
There was a problem hiding this comment.
오 리팩토링 때 진행해보겠습니다~!
| </div> | ||
| <CardsLayout> | ||
| {linkCardList.map((link) => ( | ||
| <LinkCard |
Collaborator
There was a problem hiding this comment.
컴포넌트가 많이 가벼워진게 보기 좋네요!
hongggyelim
reviewed
Nov 15, 2024
| await putLinkFavorite(info.id, { favorite: !isSubscribed }); | ||
| updateFavorite(info.id, !isSubscribed); | ||
| } catch (error) { | ||
| console.error("즐겨찾기 설정 중 오류 발생:", error); |
Collaborator
There was a problem hiding this comment.
이 부분도 토스트 적용하는게 좋을까요? (즐겨찾기 추가/실패)
Collaborator
Author
There was a problem hiding this comment.
이 부분보다는 드롭다운에 수정하기, 삭제하기 했을 때 토스팅 적용이 더 나을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈번호 #85
작업내용