feature/#228 - 404 페이지, 에러 컴포넌트 #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haksoo0918
requested review from
crazyupinc-design,
horororok,
junghwaYang and
solprime
junghwaYang
approved these changes
Dec 27, 2024
Contributor
junghwaYang
left a comment
junghwaYang
left a comment
There was a problem hiding this comment.
ErrorMessage 컴포넌트에서 아이콘은 제외하고 텍스트만 넣어주셨네요!
그럼 패칭 이슈에 대해서는 아이콘 없이 텍스트만 보여주면 되는걸까요??
Collaborator
Author
영역이 클지 작을지 몰라서 우선은 아이콘은 빼고 처리했습니다. 코드도 숫자로 넣었다가 다시 문자열로 넣었는데 저런 부분이 꽤 고민되더군요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
close #228
변경 사항 요약
Doc
codestringtitlestringchildrenReactNode테스트 결과