Feature/#217 스낵바 훅 사용 및 스낵바 공통으로 app에 배치 #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 향후 처리까지 너무 많은 기능을 담고 있어서 삭제 후 Context로 사용
- 너무 긴 시간동안 열려있는듯해서 수정
junghwaYang
requested review from
crazyupinc-design,
haksoo0918,
horororok and
solprime
Collaborator
|
수정해서 올려놨으니 확인부탁드립니다 |
Contributor
Author
확인했습니다 감사합니다 |
Contributor
Author
|
@crazyupinc-design 지이님 디벨롭 머지하신거 스낵바 정상적으로 나오는지 확인 해주세요 |
Contributor
Author
|
@haksoo0918 페이지 이동 동작을 변경하면서 스낵바 텍스트 길이를 최소화 하였습니다 확인해주세요 |
crazyupinc-design
approved these changes
Dec 28, 2024
Collaborator
crazyupinc-design
left a comment
crazyupinc-design
left a comment
There was a problem hiding this comment.
로그인, 회원가입, 마이페이지 스낵바 확인했습니다
수고많으셨습니다 !
haksoo0918
approved these changes
Dec 28, 2024
Collaborator
haksoo0918
left a comment
haksoo0918
left a comment
There was a problem hiding this comment.
이렇게 많은 페이지를...
얼릉 머지 하시져 ㅎㅎ
수고하셨습니다. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
close #217
변경 사항 요약
whitespace-nowrap를 제거하고, 모바일에서는 최소값으로280px이 들어갑니다. 두줄이상들어가는 텍스트의 경우'텍스트가 \n 두줄로 넘어갑니다.'이런식으로 표현해주시고 되도록 두줄이 넘어가지않도록 사용해주셨으면 합니다.Doc
showSnackbarmessagestringseveritystring�autoHideDurationnumber테스트