Feature/#249 qa 달력 인풋창 #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazyupinc-design
requested review from
haksoo0918,
horororok,
junghwaYang and
solprime
junghwaYang
requested changes
Dec 28, 2024
Contributor
junghwaYang
left a comment
junghwaYang
left a comment
There was a problem hiding this comment.
달력에 다크모드가 지원이 안된다는건 무척 아쉽지만 어쩔수없네요 😭
아니면 팀원분들께 여쭤보고 다크모드를 지원하지않아도 사용의사가 있으면 사용해도 나쁘지않을것같긴한데요~.. 자세한건 회의때 얘기 나누어볼까요?
haksoo0918
approved these changes
Dec 28, 2024
Collaborator
haksoo0918
left a comment
haksoo0918
left a comment
There was a problem hiding this comment.
커스터마이징이 어려우시면 기본 date 타입을 사용하시는것도 좋은거 같아요.
수고하셨습니다. 👍
Collaborator
Author
추천해주신 기본 date 타입으로 적용했습니다. |
junghwaYang
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
close #249
변경 사항 요약
=> 포커스 영역 수정했습니다.
추천 검색어를 선택시 포커스 영역이 따로 잡히는데 원인을 찾을 수가 없습니다.
=> 다크모드가 지원되지 않아서 달력을 삭제했습니다. 아래와 같이 8자리 순서대로 입력되도록 변경
Doc
컴포넌트 인 경우 props를 입력해주세요hooks 및 utils 인 경우 input,output을 입력해주세요테스트 결과
베이스(develop) 브랜치에 포함되기 위한 코드는 모두 정상적으로 작동이 되어야 합니다.컴포넌트의 경우 스크린샷을 포함해주세요.