Skip to content

#15 snack bar 컴포넌트 제작 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
junghwaYang merged 9 commits into from
Dec 16, 2024
Merged

#15 snack bar 컴포넌트 제작 #32

junghwaYang merged 9 commits into from
Dec 16, 2024

Conversation

@junghwaYang
Copy link
Contributor

@junghwaYang junghwaYang commented Dec 15, 2024 •
edited
Loading

이슈 번호

close #15

변경 사항 요약

  • SnackBar 컴포넌트 제작 완료
  • state props를 외부로 받아서 스타일에 따라 노출
  • setTimeout 등 이벤트리스너는 컴포넌트 내부에서 동작하지않고 외부에서 작성하여 props만 string으로 전달
props type dec
*state fail, success, info, null snackbar 상태 props

테스트 결과

  • info
    image

  • success
    image

  • fail
    image

@junghwaYang
✨ snackbar icon svg 추가
406e02b
@junghwaYang
✨ SnackBar 컴포넌트 완료
aa36296 
- 스타일 컴포넌트 임으로 그 외 동작은 외부에서 작성
@junghwaYang
✨ snackbar 컴포넌트 test
b3cb6f6
@junghwaYang junghwaYang added the 📁 컴포넌트 컴포넌트 개발 관련 작업 label Dec 15, 2024
@junghwaYang junghwaYang self-assigned this Dec 15, 2024
solprime
solprime approved these changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@solprime solprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예시 참고해서 사용하겠습니다 감사합니다

haksoo0918
haksoo0918 approved these changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@haksoo0918 haksoo0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

심플하게 잘 만드신거 같아여. 👍

@junghwaYang junghwaYang merged commit 80673d0 into develop Dec 16, 2024
1 check passed
@junghwaYang junghwaYang deleted the feature/#15_SnackBar-컴포넌트-제작 branch December 16, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haksoo0918 haksoo0918 haksoo0918 approved these changes

@solprime solprime solprime approved these changes

Assignees

@junghwaYang junghwaYang

Labels

📁 컴포넌트 컴포넌트 개발 관련 작업

Projects

프로젝트 현황
Status: 완료

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SnackBar 컴포넌트 제작

4 participants

@junghwaYang @haksoo0918 @solprime