Feature/#36 gnb 컴포넌트 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solprime
requested review from
crazyupinc-design,
haksoo0918,
horororok and
junghwaYang
junghwaYang
requested changes
Dec 16, 2024
Contributor
junghwaYang
left a comment
junghwaYang
left a comment
There was a problem hiding this comment.
여러 기능이 복합적으로 들어가있다보니 고민이 많으셨을것같아요
제가 남겨드린 리뷰 읽어보시고 조금 더 유지보수하기 편한 방향으로 수정되면 더 좋을것같아요!
기능적인 부분에는 흠잡을것없이 완벽합니당 고생많으셨어요 !
junghwaYang
requested changes
Dec 16, 2024
Contributor
junghwaYang
left a comment
junghwaYang
left a comment
There was a problem hiding this comment.
components/GNB 보다는
components/Headers 가 더 이해하기 쉬울 것 같아요~
Contributor
|
|
junghwaYang
requested changes
Dec 16, 2024
Contributor
junghwaYang
left a comment
junghwaYang
left a comment
There was a problem hiding this comment.
이전 리뷰 반영 확인했습니다!!
너무 고생많으셨어요..!! 이거 하나만 더 부탁드립니다!
해당 부분 수정완료되면 approve 처리 하겠습니다!
junghwaYang
approved these changes
Dec 16, 2024
haksoo0918
approved these changes
Dec 17, 2024
Collaborator
haksoo0918
left a comment
haksoo0918
left a comment
There was a problem hiding this comment.
isMobile 과 mo: 클래스를 같이 사용하셨던데, 어떤 기준으로 두개를 나누어 적용하셨는지 궁금합니다.
소스가 길어서 보는데도 오래 걸렸는데 작업하시는데 힘드셨을것 같아요. 수고하셨습니다. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
close #36
변경 사항 요약
테스트 결과
로그인 전
로그인 전(모바일)
로그인 후
로그인 후(모바일)
